Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029193Openbravo ERP04. Warehouse managementpublic2015-02-16 19:122015-04-01 08:31
Reporterumartirena 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1.2Fixed in Version 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029193: [Cost Adjustments] Orphan Lines cost calculation fails under certain circumstances
DescriptionOrphan Lines cost calculation cannot calculate the cost of a return from customer when is a backdated transaction.
Steps To ReproduceIn F&B:
 * Enable "RM Allow Orphan Line" preference.
 * Have a valid average costing rule for F&B España org.
 * Create a Product
 * Add a Costing Record:
  - Org: F&B España
  - Cost: 5
  - Cost Type: Average
  - Starting Date: 01/01/2014
  - Ending Date: 31/12/9999
 * Create a Goods Shipment:
  - Org: F&B España
  - Business Partner: Alimentos y Supermercados
  - Movement Date: 10/02/2015
 * Add a Line:
  - Product: The new product
  - Qty: 10
  - Storage Bin: RN 0-0-0
 * Complete it
 * Go to Return from Customer window
 * Create a Header:
  - Org: F&B España
  - Business Partner: Alimentos y Supermercados
  - Order Date: 05/02/2015
 * Click on "Insert Orphan Line":
  - Product: The new product
  - Returned: 5
  - Unit Price: 12
  - Tax: Arrendamiento 21% (Cobros) - IVA Normal
 * Click OK and Book it
 * Go to Return Material Receipt:
 * Create a Header:
  - Org: F&B España
  - Business Partner: Alimentos y Supermercados
  - Movement Date: 05/02/2015
 * Click on Pick/Edit Lines:
 * Select the line created in previous Return from Customer
  - Returned: 5
  - Storage Bin: RN 0-0-0
 * Click Done and Complete it
 * Go to Process Request window
 * Run Costing Background process
 
 * Realize that the process ends successfully but the following message is obtained in Process Log:

 "No average cost found for the product on a date"

 
Proposed SolutionThe process should be able to calculate the cost of the product on that case looking at Costing tab of the Product and finding a valid Average Cost.
Additional Information
TagsApproved
Relationships
blocks defect 0028962 closed umartirena [Cost Adjustments] Orphan Lines cost calculation fails under certain circumstances 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-09 09:29umartirenaTypedefect => backport
2015-03-09 09:29umartirenaTarget Version => 3.0PR15Q1.2
2015-03-09 18:40hgbotCheckin
2015-03-09 18:40hgbotNote Added: 0075340
2015-03-09 18:40hgbotStatusscheduled => resolved
2015-03-09 18:40hgbotResolutionopen => fixed
2015-03-09 18:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/bc69189429632bbbcec2c1b755e3a6e1b6334163 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/a9299e79b9d8b7caf59002e69e6534305df64d69 [^]
2015-03-09 18:41aferrazNote Added: 0075341
2015-03-09 18:41aferrazStatusresolved => closed
2015-03-09 20:00dmitry_mezentsevTag Attached: Approved
2015-04-01 08:06hgbotCheckin
2015-04-01 08:06hgbotNote Added: 0076201
2015-04-01 08:06hgbotStatusclosed => resolved
2015-04-01 08:06hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/a9299e79b9d8b7caf59002e69e6534305df64d69 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/a9299e79b9d8b7caf59002e69e6534305df64d69 [^]
2015-04-01 08:31priyamStatusresolved => closed
2015-04-01 08:31priyamNote Added: 0076274

Notes
(0075340)
hgbot   
2015-03-09 18:40   
Repository: erp/backports/3.0PR15Q1.2
Changeset: a9299e79b9d8b7caf59002e69e6534305df64d69
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 17 17:25:49 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/a9299e79b9d8b7caf59002e69e6534305df64d69 [^]

Fixes Bug 29193: Cost properly calculated for orphan lines in Cost Adjustments

The process was failing for orphan lines because it was trying to get the cost from a Purchase Price or an Standard Cost, and there is none. Before checking those two, the process now tries to find an Average Cost for that product on the movement date of the orphan line, and if it founds it assigns to the transaction.

---
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CostingAlgorithmAdjustmentImp.java
---
(0075341)
aferraz   
2015-03-09 18:41   
Code review + Testing OK
(0076201)
hgbot   
2015-04-01 08:06   
Repository: erp/backports/3.0PR15Q2
Changeset: a9299e79b9d8b7caf59002e69e6534305df64d69
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 17 17:25:49 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/a9299e79b9d8b7caf59002e69e6534305df64d69 [^]

Fixes Bug 29193: Cost properly calculated for orphan lines in Cost Adjustments

The process was failing for orphan lines because it was trying to get the cost from a Purchase Price or an Standard Cost, and there is none. Before checking those two, the process now tries to find an Average Cost for that product on the movement date of the orphan line, and if it founds it assigns to the transaction.

---
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CostingAlgorithmAdjustmentImp.java
---
(0076274)
priyam   
2015-04-01 08:31   
closed again, as the status changed due the merge tag of 3.0PR15Q1.2 to backports/3.0PR15Q2