Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029181Retail ModulesWeb POSpublic2015-03-08 05:572015-06-11 17:56
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in VersionRR15Q2 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029181: Running js unit tests locally results in js error
DescriptionWhen running these tests in a local machine:
https://code.openbravo.com/tools/automation/pi-mobile-sandbox/file/16fe952b5550/src-test/org/openbravo/test/mobile/retail/extmodules/unittest [^]

I get a js error because the global var testSuite is not defined.
Steps To ReproduceStart OB
Start selenium
Run unit test suite
Proposed SolutionInstead of using a global var called: testSuite
change to the more common approach of using the OB namespace, for example: OB.POS.JSUNITTEST
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-08 05:57mtaalNew Issue
2015-03-08 05:57mtaalAssigned To => mtaal
2015-03-08 05:57mtaalTriggers an Emergency Pack => No
2015-03-08 05:57mtaalDescription Updatedbug_revision_view_page.php?rev_id=7901#r7901
2015-03-08 07:12hgbotCheckin
2015-03-08 07:12hgbotNote Added: 0075271
2015-03-09 00:21hgbotCheckin
2015-03-09 00:21hgbotNote Added: 0075288
2015-03-09 00:21hgbotStatusnew => resolved
2015-03-09 00:21hgbotResolutionopen => fixed
2015-03-09 00:21hgbotFixed in SCM revision => http://code.openbravo.com/tools/automation/pi-mobile/rev/ee286b4fae6909f41322cfabdddcdefface76934 [^]
2015-03-13 11:05OrekariaReview Assigned To => Orekaria
2015-03-13 11:05OrekariaStatusresolved => closed
2015-03-13 11:05OrekariaFixed in Version => RR15Q2
2015-05-27 16:05hgbotCheckin
2015-05-27 16:05hgbotNote Added: 0077818
2015-05-27 16:05hgbotStatusclosed => resolved
2015-05-27 16:05hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/ee286b4fae6909f41322cfabdddcdefface76934 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/3ea7563a69cf77a8bcdebac39f52ce131ad8459f [^]
2015-06-11 17:56marvintmStatusresolved => closed

Notes
(0075271)
hgbot   
2015-03-08 07:12   
Repository: erp/pmods/org.openbravo.retail.unittest
Changeset: c53026aa59f5fb096816319e6c91f017ca3dd579
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 08 07:11:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.unittest/rev/c53026aa59f5fb096816319e6c91f017ca3dd579 [^]

Related to issue 29181: Running js unit tests locally results in js error
Introduce correct global namespace for js unit test runs

---
M web/org.openbravo.retail.unittest/source/discount-tests.js
---
(0075288)
hgbot   
2015-03-09 00:21   
Repository: tools/automation/pi-mobile
Changeset: ee286b4fae6909f41322cfabdddcdefface76934
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 08 07:14:25 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ee286b4fae6909f41322cfabdddcdefface76934 [^]

Fixes issue 29181: Running js unit tests locally results in js error (I & II)
Changed calls to use correct new global object containing the unit tests

---
M src-test/org/openbravo/test/mobile/common/unittest/terminals/UnitTestTerminalNonSecure.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/CombosUnitTest.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/PriceListIncludingTaxesUnitTest.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/PriceListNotIncludingTaxesUnitTest.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/TaxZonesUnitTest.java
---
(0077818)
hgbot   
2015-05-27 16:05   
Repository: tools/automation/pi-mobile
Changeset: 3ea7563a69cf77a8bcdebac39f52ce131ad8459f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 08 07:14:25 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3ea7563a69cf77a8bcdebac39f52ce131ad8459f [^]

Fixes issue 29181: Running js unit tests locally results in js error (I & II)
Changed calls to use correct new global object containing the unit tests

---
M src-test/org/openbravo/test/mobile/common/unittest/terminals/UnitTestTerminalNonSecure.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/CombosUnitTest.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/PriceListIncludingTaxesUnitTest.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/PriceListNotIncludingTaxesUnitTest.java
M src-test/org/openbravo/test/mobile/retail/extmodules/unittest/tests/discounts/TaxZonesUnitTest.java
---