Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029180Retail ModulesWeb POSpublic2015-03-08 05:552015-03-16 14:18
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in VersionRR15Q2 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029180: WebPOS build fails on Oracle
DescriptionThis build step fails:

Because a specific stored procedure call does not work correctly on Oracle: M_GET_STOCK_PARAM.xml.
Steps To ReproduceStacktrace:

2015-03-07 21:29:03,717 [main] WARN VBS1001.VerifySimpleSale - org.junit.internal.runners.model.MultipleFailureException: There were 2 errors:
    [junit] com.thoughtworks.selenium.SeleniumException(The database didn't return the expected data in the query = "SELECT m_product_id, name FROM m_product WHERE m_product_id IN (SELECT m_product_id FROM c_orderline WHERE c_order_id IN (SELECT c_order_id FROM c_order WHERE documentno = 'VBS1001/0000001')) ORDER BY name")
    [junit] java.lang.AssertionError(1 Errors in the OBPOS_Errors table while importing POS data: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
    [junit] TYPE --> Order
    [junit] ERROR -->
    [junit] org.openbravo.base.exception.OBException: Error in OrderLoader:
    [junit] at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:295)
    [junit] at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:117)
    [junit] at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:87)
    [junit] at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:51)
    [junit] at org.openbravo.mobile.core.process.JSONProcessSimple.exec(JSONProcessSimple.java:34)
    [junit] at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:39)
    [junit] at org.openbravo.mobile.core.process.MobileService.execClassName(MobileService.java:154)
    [junit] at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:77)
    [junit] at org.openbravo.mobile.core.process.MobileService.doPost(MobileService.java:48)
    [junit] at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    [junit] at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:222)
    [junit] at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:449)
    [junit] at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:88)
    [junit] at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:51)
    [junit] at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    [junit] at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    [junit] at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    [junit] at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    [junit] at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    [junit] at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    [junit] at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    [junit] at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    [junit] at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    [junit] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    [junit] at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    [junit] at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    [junit] at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    [junit] at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    [junit] at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    [junit] at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    [junit] at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
    [junit] at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
    [junit] at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:776)
    [junit] at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:705)
    [junit] at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:898)
    [junit] at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
    [junit] at java.lang.Thread.run(Thread.java:701)
    [junit] Caused by: java.lang.IllegalStateException: java.sql.SQLSyntaxErrorException: ORA-00904: "M_GET_STOCK_PARAM": invalid identifier
    [junit]
    [junit] at org.openbravo.service.db.CallStoredProcedure.call(CallStoredProcedure.java:142)
    [junit] at org.openbravo.retail.posterminal.OrderLoader.callProcessGetStock(OrderLoader.java:1801)
    [junit] at org.openbravo.retail.posterminal.OrderLoader.createShipmentLines(OrderLoader.java:846)
    [junit] at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:244)
    [junit] ... 45 more
    [junit] Caused by: java.sql.SQLSyntaxErrorException: ORA-00904: "M_GET_STOCK_PARAM": invalid identifier
    [junit]
    [junit] at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
    [junit] at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
    [junit] at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
    [junit] at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
    [junit] at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
    [junit] at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
    [junit] at oracle.jdbc.driver.T4CPreparedStatement.doOall8(T4CPreparedStatement.java:207)
    [junit] at oracle.jdbc.driver.T4CPreparedStatement.executeForDescribe(T4CPreparedStatement.java:863)
    [junit] at oracle.jdbc.driver.OracleStatement.executeMaybeDescribe(OracleStatement.java:1153)
    [junit] at oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1275)
    [junit] at oracle.jdbc.driver.OracleStatement.doScrollExecuteCommon(OracleStatement.java:4656)
    [junit] at oracle.jdbc.driver.OraclePreparedStatement.doScrollPstmtExecuteUpdate(OraclePreparedStatement.java:10410)
    [junit] at oracle.jdbc.driver.OraclePreparedStatement.executeInternal(OraclePreparedStatement.java:3574)
    [junit] at oracle.jdbc.driver.OraclePreparedStatement.executeQuery(OraclePreparedStatement.java:3620)
    [junit] at oracle.jdbc.driver.OraclePreparedStatementWrapper.executeQuery(OraclePreparedStatementWrapper.java:1491)
    [junit] at org.openbravo.service.db.CallStoredProcedure.call(CallStoredProcedure.java:131)
    [junit] ... 48 more
Proposed SolutionChange the call to this stored procedure to use a new class: StockUtils
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0028909 closed marvintm can't create orders in Oracle 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-08 05:55mtaalNew Issue
2015-03-08 05:55mtaalAssigned To => mtaal
2015-03-08 05:55mtaalTriggers an Emergency Pack => No
2015-03-08 07:31hgbotCheckin
2015-03-08 07:31hgbotNote Added: 0075272
2015-03-08 07:31hgbotStatusnew => resolved
2015-03-08 07:31hgbotResolutionopen => fixed
2015-03-08 07:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c0a35478e6ff9ca6637b7b97502189dcd5fa1842 [^]
2015-03-09 09:43malsasuaRelationship addedhas duplicate 0028909
2015-03-10 15:04hgbotCheckin
2015-03-10 15:04hgbotNote Added: 0075400
2015-03-13 12:22OrekariaReview Assigned To => Orekaria
2015-03-13 12:22OrekariaStatusresolved => closed
2015-03-13 12:22OrekariaFixed in Version => RR15Q2
2015-03-13 12:52OrekariaStatusclosed => new
2015-03-13 12:52OrekariaResolutionfixed => open
2015-03-13 12:52OrekariaFixed in VersionRR15Q2 =>
2015-03-13 12:52OrekariaStatusnew => scheduled
2015-03-13 12:52OrekariaStatusscheduled => resolved
2015-03-13 12:52OrekariaFixed in Version => RR15Q2
2015-03-13 12:52OrekariaResolutionopen => fixed
2015-03-16 12:05malsasuaReview Assigned ToOrekaria => malsasua
2015-03-16 12:05malsasuaNote Added: 0075616
2015-03-16 12:05malsasuaStatusresolved => closed
2015-03-16 14:16hgbotCheckin
2015-03-16 14:16hgbotNote Added: 0075623
2015-03-16 14:16hgbotStatusclosed => resolved
2015-03-16 14:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c0a35478e6ff9ca6637b7b97502189dcd5fa1842 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90f3289fee29796d2fd9b1eb32581c865ad14c0e [^]
2015-03-16 14:18malsasuaNote Added: 0075624
2015-03-16 14:18malsasuaStatusresolved => closed

Notes
(0075272)
hgbot   
2015-03-08 07:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c0a35478e6ff9ca6637b7b97502189dcd5fa1842
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Mar 08 07:31:15 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c0a35478e6ff9ca6637b7b97502189dcd5fa1842 [^]

Fixes issue 29180: WebPOS build fails on Oracle
Uses StockUtil class to call M_GET_STOCK_PARAM stored procedure

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0075400)
hgbot   
2015-03-10 15:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 26039be0b399a6ed28dc6757774217a906568e5d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 10 14:06:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26039be0b399a6ed28dc6757774217a906568e5d [^]

Related to issue 29180: WebPOS build fails on Oracle
Return processid so that it reads the right stock info

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0075616)
malsasua   
2015-03-16 12:05   
verified
(0075623)
hgbot   
2015-03-16 14:16   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 90f3289fee29796d2fd9b1eb32581c865ad14c0e
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon Mar 16 14:16:01 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90f3289fee29796d2fd9b1eb32581c865ad14c0e [^]

fixed issue 29180: removed unused variables

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0075624)
malsasua   
2015-03-16 14:18   
verified last changeset