Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029169ModulesWarehouse Pickingpublic2015-03-06 12:222015-04-27 11:47
Reporterngarcia 
Assigned Toreinaldoguerra 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toumartirena
Support ticket
OBNetwork customer
Regression introduced in release
Summary0029169: Cannot delete a picking list line if the sales order line was delivered in another goods shipment
DescriptionCannot delete a picking list line if the sales order line was delivered in another goods shipment
Steps To ReproduceAs group admin role:
   Create a Sales Order with a product that has stock
   Generate the Picking List
   Do not process it
   Create a Goods Shipment associated to the sales order
   Go to the Picking List and try to Delete the line
   You will get the following error:
      "org.openbravo.base.exception.OBException: OBWPL_ErrorDeletingLine"
   The log shows:

Caused by: org.openbravo.base.exception.OBException: CannotReleasedMoreReserved
  Where: SQL statement "UPDATE m_reservation_stock SET quantity = quantity + $1 WHERE m_reservation_stock_id = $2 "
PL/pgSQL function "m_reserve_stock_manual" line 104 at SQL statement
    at org.openbravo.materialmgmt.ReservationUtils.reserveStockManual(ReservationUtils.java:130)
    at org.openbravo.warehouse.pickinglist.ad_actionButton.DeletePickingLine.execute(DeletePickingLine.java:63)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035542 closed aferraz Wrong stock reservation when deleting lines or canceling partially shipped orders' picking lists 
related to defect 0035600 new Triage Omni WMS An exception is thrown in Eclipse and the popup to Delete line in the PL is not opened 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-06 12:22ngarciaNew Issue
2015-03-06 12:22ngarciaAssigned To => naiaramartinez
2015-03-06 12:22ngarciaResolution time => 1432159200
2015-03-06 12:57ngarciaAssigned Tonaiaramartinez => Sandrahuguet
2015-03-20 16:01reinaldoguerraAssigned ToSandrahuguet => reinaldoguerra
2015-03-20 16:01reinaldoguerraStatusnew => scheduled
2015-03-30 21:41reinaldoguerraNote Added: 0076158
2015-04-27 11:45hgbotCheckin
2015-04-27 11:45hgbotNote Added: 0076777
2015-04-27 11:45hgbotStatusscheduled => resolved
2015-04-27 11:45hgbotResolutionopen => fixed
2015-04-27 11:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/8c6a6a82680931fc6a08e79b6a559ed22e637931 [^]
2015-04-27 11:47umartirenaReview Assigned To => umartirena
2015-04-27 11:47umartirenaNote Added: 0076778
2015-04-27 11:47umartirenaStatusresolved => closed
2017-03-17 11:24aferrazRelationship addedrelated to 0035542
2017-03-22 16:42markmm82Relationship addedrelated to 0035600

Notes
(0076158)
reinaldoguerra   
2015-03-30 21:41   
Test plan used:
1- Login into Openbravo ERP
2- As system administrator go to module management and install "Warehouse Picking" module
3- Rebuild de systema and login again
4- Go to Enterprise module management window and install "Warehouse Picking" reference data.
5- Go to Preference window and create a new record. Select property: Enable Stock Reservations and set value: Y
6- Logout and login.
7- Go to Sales order window and create a new header.
8- Go to lines tab and create a new one selecting a product with stock, for example Vino Blanco
9- Book the order and then click on Generate Picking List button. Complete the process. A new goods shipment and reservation will be also created.
10- Go to Goods Shipment window and create a new record
11- Click on Create Lines From button and select the sales order. Complete the process selecting a storage bin.
12- Complete the shipment.
13- Go to Warehouse Picking List window and select previously created record.
11- Go to lines tab and click on Delete Line button
12- The line now will be deleted, also the shipment associated with the picking list will be also deleted.
13- Repeat steps 7-9
14- Go to Goods Shipment window and select record created during last picking list generation.
15- Complete this shipment.
16- Go to Warehouse Picking List window and select created record during last picking list generation.
17- Go to lines tab and click on Delete Line button
18- An error message will be properly shown as this picking list is related to a shipment completed.
(0076777)
hgbot   
2015-04-27 11:45   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 8c6a6a82680931fc6a08e79b6a559ed22e637931
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri Apr 24 20:41:51 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/8c6a6a82680931fc6a08e79b6a559ed22e637931 [^]

Fixes issue 29169: Cannot delete a picking list line if the sales order line was delivered in another goods shipment
Do not undo reservation for already released quantity

---
M src/org/openbravo/warehouse/pickinglist/ad_actionButton/DeletePickingLine.java
---
(0076778)
umartirena   
2015-04-27 11:47   
Code Review + Testing OK