Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029161Retail ModulesWeb POSpublic2015-03-06 09:372015-03-13 13:03
Reporteraaroncalero 
Assigned Toaaroncalero 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q2Fixed in Version 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029161: [MultiUPC] Refactor the Retail MultiUPC module to use the new BarcodeHandler componen structure
DescriptionThe Retail MultiUPC module needs to be refactored to work with the last refactor of the OB.UI.BarcodeActionHandler component (issue 0029160)
Steps To ReproduceAfter the fix for the issue 29160 the OB.UI.BarcodeActionHandler will be refactored. Verify that after that fix, the current multiUPC module doesn't work as expected.
Proposed SolutionWe will make use of the new structure of the BarcodeActionHandler to extend the search in a more performance-friendly way, taking into account that chaining two OB.Dal.find is more efficient than executing a joint query.
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0029160RR15Q2 closed aaroncalero The BarcodeActionHandler component should be refactored to allow more specific extensions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-06 09:37aaroncaleroNew Issue
2015-03-06 09:37aaroncaleroAssigned To => aaroncalero
2015-03-06 09:37aaroncaleroOBNetwork customer => No
2015-03-06 09:37aaroncaleroTriggers an Emergency Pack => No
2015-03-06 09:38aaroncaleroRelationship addeddepends on 0029160
2015-03-06 11:18hgbotCheckin
2015-03-06 11:18hgbotNote Added: 0075239
2015-03-06 11:18hgbotStatusnew => resolved
2015-03-06 11:18hgbotResolutionopen => fixed
2015-03-06 11:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.multiupc/rev/9b108c01be9869238d78aff33625413d0fc643f3 [^]
2015-03-13 13:03adrianromeroReview Assigned To => adrianromero
2015-03-13 13:03adrianromeroNote Added: 0075552
2015-03-13 13:03adrianromeroStatusresolved => closed

Notes
(0075239)
hgbot   
2015-03-06 11:18   
Repository: erp/pmods/org.openbravo.retail.multiupc
Changeset: 9b108c01be9869238d78aff33625413d0fc643f3
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 06 11:15:11 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.multiupc/rev/9b108c01be9869238d78aff33625413d0fc643f3 [^]

Fixed issue 29161: [MultiUPC] Refactor the Retail MultiUPC module to use the new BarcodeHandler component structure

Removed the addWhereFilter function as it is no longer used
Extended the searchProductCallback query to execute two back-to-back finds instead of a single query for better performance
Added index by upc to the multiupc clientside table

---
M src/org/openbravo/retail/multiupc/MultiUPCProperties.java
M web/org.openbravo.retail.multiupc/js/extendUPCSearch.js
M web/org.openbravo.retail.multiupc/js/multiupc.js
---
(0075552)
adrianromero   
2015-03-13 13:03   
Verified