0029131: Bad performance and degradation on the execution on the generate picking list process

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0029131

Modules

Warehouse Picking

public

2015-03-04 16:43

2015-04-09 11:28

Reporter

egoitz

Assigned To

eduardo_Argal

Priority

immediate

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

dmiguelez

Support ticket

34806

OBNetwork customer

OBPS

Regression introduced in release

Summary

0029131: Bad performance and degradation on the execution on the generate picking list process

Description

The process takes long becuase each generation takes long due to the memory usage.
There is also degradation and the time for each execution of the loop increases.

Steps To Reproduce

-Execute the process Generate picking list for a order with 2600 lines.

Proposed Solution

On the method processOrder from Utilities java class you can replace the
loop
for (OrderLine orderLine : order.getOrderLineList()) {

with

a loop that reads all the id's obtained with a query object:

    final StringBuilder hqlString = new StringBuilder();
    hqlString.append(" select e.id ");
    hqlString.append(" from OrderLine as e");
    hqlString.append(" where e.salesOrder.id = :order");
    Query query = OBDal.getInstance().getSession().createQuery(hqlString.toString());

    query.setParameter("order", order.getId());

    List<String> stroLines = query.list();



    for ( String strline : stroLines ) {
        OrderLine orderLine = OBDal.getInstance().get(OrderLine.class, strline)

That improves a lot the performance of each execution but does not solve the degradation problem.

Additional Information