Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029119Openbravo ERPZ. Otherspublic2015-03-03 19:302015-05-07 22:16
Reportermaite 
Assigned Toreinaldoguerra 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029119: "Select credit payments" functionality should consider defined conversion rate when "Use credit" process is run
Description"Select credit payments" functionality should consider defined conversion rate when "Use credit" process is run
Steps To Reproduce1. Define conversion rate between EUR and MXN for today as multiplied by 8
2. Define Financial Account in MXN currency for Spain organization. Add Transferencia payment method
3. Configure MXN Financial Account as Bebidas Alegres default financial account
4. Register payment out to generate 150 EUR of credit to Bebidas Alegres BP
5. Register Purchase Invoice for Bebidas Alegres, today's date and total gross amount 150
6. Process invoice and realize that "Select credit payments" functionality is launched. Select available credit and run "Use credit" option
7. Navigate to created Payment Out and realize that conversion rate in payment's header and Exchange Rate tab has been set to 1 instead of 8

NOTE: if you create Payment Out document manually setting same BP, FA and PM you can see that Exchange Rate is set to 8, which is expected behaviour. Exchange rate will not affect to payment's amount (as it is zero) but it will affect to payment's posting
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-03 19:30maiteNew Issue
2015-03-03 19:30maiteAssigned To => Sandrahuguet
2015-03-03 19:30maiteModules => Core
2015-03-03 19:30maiteResolution time => 1428357600
2015-03-03 19:30maiteTriggers an Emergency Pack => No
2015-03-03 19:30maiteIssue Monitored: networkb
2015-03-10 17:11reinaldoguerraAssigned ToSandrahuguet => reinaldoguerra
2015-03-10 17:11reinaldoguerraStatusnew => scheduled
2015-03-11 17:11reinaldoguerraNote Added: 0075454
2015-03-13 10:35jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-04-27 18:23hgbotCheckin
2015-04-27 18:23hgbotNote Added: 0076793
2015-04-27 18:23hgbotStatusscheduled => resolved
2015-04-27 18:23hgbotResolutionopen => fixed
2015-04-27 18:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d9749c89a0db088078bf699831102eb37b652014 [^]
2015-04-27 18:23hgbotCheckin
2015-04-27 18:23hgbotNote Added: 0076794
2015-04-27 18:23hgbotCheckin
2015-04-27 18:23hgbotNote Added: 0076795
2015-04-27 18:23vmromanosReview Assigned To => vmromanos
2015-04-27 18:23vmromanosNote Added: 0076796
2015-04-27 18:23vmromanosStatusresolved => closed
2015-05-07 22:16hudsonbotCheckin
2015-05-07 22:16hudsonbotNote Added: 0077163
2015-05-07 22:16hudsonbotCheckin
2015-05-07 22:16hudsonbotNote Added: 0077164
2015-05-07 22:16hudsonbotCheckin
2015-05-07 22:16hudsonbotNote Added: 0077165

Notes
(0075454)
reinaldoguerra   
2015-03-11 17:11   
Test plan used:
1- Login into Openbravo ERP
2- Go to Conversion Rates window and create a new record
   Currency: EUR
   To Currency: MXN
   Valid From Date: Today
   Multiple Rate By: 8
3- Go to Financial Account window and create a new header
   Organization: España S.A.
   Name: MXN Financial Account
   Currency: MXN
4- Go to Payment Method tab and create a new record, select Transferencia as Payment Method
5- Go to Business Partner window and select "Bebidas Alegres, S.L.". Go to Vendor tab and select "MXN Financial Account" as PO Financial Account
6- Go to Payment Out window and create a new header
   Payment Date: Today
   Paying To: Bebidas Alegres, S.L.
   Payment Method: Transferencia
   Paying From: Cuenta de Banco - EUR
   Generated Credit: 150
7- Click on Add Details button, select "Leave the credit to be used later" as Overpayment Action. Click on Done button. Now 150 EUR are generated as credit.
8- Go to Purchase Invoice window and create a new header, select Bebidas Alegres, S.L. as Business Partner
9- Go to lines tab and create a new record, select product: Cerveza Ale 0,5L and Invoiced Quantity: 92. Check that Total Gross Amount is more than 150
10- Complete the invoice and realize that "Select credit payments" functionality is launched. Select available credit and run "Use credit" option
11- A new Payment Out is created, realize that now Exchange Rate in payment's header and Exchange Rate tab has been set now to 8.
(0076793)
hgbot   
2015-04-27 18:23   
Repository: erp/devel/pi
Changeset: d9749c89a0db088078bf699831102eb37b652014
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Wed Mar 11 10:44:04 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/d9749c89a0db088078bf699831102eb37b652014 [^]

Fixed bug 29119: "Use credit" process should consider defined conversion rate.

The currencies conversion rate, defined for payment's date, is now taken into account when the credit left by the payment, is used during the invoice's process.
Now the field exange rate, is well defined in the new payment created, if exists a conversion between the currencies of the invoice's and the payment's financial account, for the payment's date.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0076794)
hgbot   
2015-04-27 18:23   
Repository: erp/devel/pi
Changeset: 1095937f5f0baad2054a1b55accc6b89064746ab
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Apr 27 18:11:20 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1095937f5f0baad2054a1b55accc6b89064746ab [^]

Related to issue 29119: Applied OB code format

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0076795)
hgbot   
2015-04-27 18:23   
Repository: erp/devel/pi
Changeset: 10bc53bcdb3b8600d51d26f30f504f10c5158b01
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Apr 27 18:20:37 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/10bc53bcdb3b8600d51d26f30f504f10c5158b01 [^]

Related to issue 29119: Search for conversion rate when different currencies

The code in charge of getting the conversion rate will be executed only for different currencies

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0076796)
vmromanos   
2015-04-27 18:23   
Code review + testing OK
(0077163)
hudsonbot   
2015-05-07 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077164)
hudsonbot   
2015-05-07 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077165)
hudsonbot   
2015-05-07 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test