Openbravo Issue Tracking System - Retail Modules
View Issue Details
0029107Retail ModulesDiscounts and Promotionspublic2015-03-03 10:242015-05-13 18:16
asiermartirena 
asiermartirena 
normalminoralways
closedfixed 
5
 
RR15Q3 
marvintm
No
0029107: Show discount percent in manual discounts lines (Web POS)
When selecting a manual discount, user needs to include the discount percentage. This percentage is not shown in lines.
This issue is to add the percent number plus "%" icon next to the discount line, in order to be clearer when using this type of discounts.
Add a manual discount, select the percent which is going to be applied and check that the disctount percent value is not shown.
Patch added to solve this problem.
No tags attached.
blocks feature request 0029465RR16Q1 closed Retail QA: RR15Q3: Add tests for Mobile applications 
diff discountsPatch2.diff (2,041) 2015-03-23 13:08
https://issues.openbravo.com/file_download.php?file_id=7923&type=bug
Issue History
2015-03-03 10:24asiermartirenaNew Issue
2015-03-03 10:24asiermartirenaAssigned To => marvintm
2015-03-03 10:24asiermartirenaFile Added: posterminalPatch.diff
2015-03-03 10:24asiermartirenaTriggers an Emergency Pack => No
2015-03-03 10:26asiermartirenaFile Added: discountsPatch.diff
2015-03-04 11:34OrekariaRelationship addedblocks 0028933
2015-03-23 13:08asiermartirenaFile Added: discountsPatch2.diff
2015-03-23 13:09asiermartirenaFile Added: posterminalDiscountsPatch.diff
2015-03-23 13:10asiermartirenaFile Deleted: discountsPatch.diff
2015-03-23 13:10asiermartirenaFile Deleted: posterminalPatch.diff
2015-03-30 18:54OrekariaRelationship addedblocks 0029465
2015-03-30 18:54OrekariaRelationship deletedblocks 0028933
2015-04-22 10:14asiermartirenaFile Deleted: posterminalDiscountsPatch.diff
2015-04-22 11:06asiermartirenaReview Assigned To => marvintm
2015-05-05 16:25hgbotCheckin
2015-05-05 16:25hgbotNote Added: 0077021
2015-05-06 08:20hgbotCheckin
2015-05-06 08:20hgbotNote Added: 0077033
2015-05-08 13:57asiermartirenaStatusnew => scheduled
2015-05-08 13:57asiermartirenaNote Added: 0077238
2015-05-08 14:01asiermartirenaStatusscheduled => resolved
2015-05-08 14:01asiermartirenaResolutionopen => fixed
2015-05-12 18:50marvintmNote Added: 0077353
2015-05-12 20:21guillermogilIssue Monitored: marvintm
2015-05-12 20:23hgbotCheckin
2015-05-12 20:23hgbotNote Added: 0077358
2015-05-13 18:16marvintmAssigned Tomarvintm => asiermartirena
2015-05-13 18:16marvintmStatusresolved => closed
2015-05-13 18:16marvintmFixed in Version => RR15Q3

Notes
(0077021)
hgbot   
2015-05-05 16:25   
Repository: tools/automation/pi-mobile
Changeset: 9e902ab48757766441a3f873e7cb8ad0751ca2a1
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Tue May 05 14:33:16 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9e902ab48757766441a3f873e7cb8ad0751ca2a1 [^]

Related to issue 29107:Show discount percent in manual discounts lines

Discount name has been modified
Now it shows the manual percent append to the discount name

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/ReceiptDiscount.java
---
(0077033)
hgbot   
2015-05-06 08:20   
Repository: tools/automation/pi-mobile
Changeset: 21579d20524551778b97b243d646452d20ba6243
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed May 06 08:18:45 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/21579d20524551778b97b243d646452d20ba6243 [^]

Related to issue 29107:Show discount percent in manual discounts lines

Modified wrong discount label

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java
---
(0077238)
asiermartirena   
2015-05-08 13:57   
This issue is solved by the following commit:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/d946053a006e [^]
(0077353)
marvintm   
2015-05-12 18:50   
The standard getIdentifier logic is duplicated in three rules which basically work like the standard case. They need to be removed, only the percentage one should have a getIdentifier definition.
(0077358)
hgbot   
2015-05-12 20:23   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: e4ef881a7483170662d9520b2d7c14b9b7106a52
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Tue May 12 20:22:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e4ef881a7483170662d9520b2d7c14b9b7106a52 [^]

Related to issue 29107:Show discount percent in manual discounts lines

Removed not needed functions due to duplicate code

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---