Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029097Openbravo ERPA. Platformpublic2015-03-02 12:292015-04-01 11:52
Reporteregoitz 
Assigned ToAugustoMauch 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-03-05
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/1ea574e6513ced497aaa66952a0eb3ff48525669 [^]
Triggers an Emergency PackNo
Summary0029097: Not possible to move a menu entry on the tree if you not have the module indevelpment
DescriptionA menu entry of a core element only can be moved on the tree structure defining core as indevelopment.
Steps To Reproduce-Define a template as indevelopment
-Go to menu window
-click on tree button
-Try to move a entry on the tree structure.
*an error is raised:

The node must belong to a module that is in development in order to be reparented.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 00259063.0PR14Q2 closed AugustoMauch Tree Extension Project 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-03-02 12:29egoitzNew Issue
2015-03-02 12:29egoitzAssigned To => AugustoMauch
2015-03-02 12:29egoitzModules => Core
2015-03-02 12:29egoitzRegression level => Production - Confirmed Stable
2015-03-02 12:29egoitzTriggers an Emergency Pack => No
2015-03-02 12:38AugustoMauchRegression date => 2014-03-05
2015-03-02 12:38AugustoMauchRegression introduced in release => 3.0PR14Q2
2015-03-02 12:38AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/1ea574e6513ced497aaa66952a0eb3ff48525669 [^]
2015-03-02 12:39AugustoMauchRelationship addedcaused by 0025906
2015-03-02 12:40AugustoMauchNote Added: 0075074
2015-03-02 13:32rafarodaIssue Monitored: rafaroda
2015-03-02 13:35jonalegriaesarteResolution time => 1393974000
2015-03-02 13:38egoitzSeveritymajor => minor
2015-03-02 13:42AugustoMauchIssue Monitored: alostale
2015-03-02 13:42AugustoMauchReview Assigned To => alostale
2015-03-02 13:47hgbotCheckin
2015-03-02 13:47hgbotNote Added: 0075086
2015-03-02 13:47hgbotStatusnew => resolved
2015-03-02 13:47hgbotResolutionopen => fixed
2015-03-02 13:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f1360ce4b3d1861653f726626296ea743e16c52f [^]
2015-03-02 13:51AugustoMauchNote Added: 0075087
2015-03-03 16:09hudsonbotCheckin
2015-03-03 16:09hudsonbotNote Added: 0075122
2015-03-09 09:39alostaleNote Added: 0075294
2015-03-09 09:39alostaleStatusresolved => closed
2015-03-09 09:39alostaleFixed in Version => 3.0PR15Q2
2015-03-19 07:17hgbotCheckin
2015-03-19 07:17hgbotNote Added: 0075762
2015-03-19 07:17hgbotStatusclosed => resolved
2015-03-19 07:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f1360ce4b3d1861653f726626296ea743e16c52f [^] => http://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/17972a6e9e7ba9bb11b3e702c817cc839feacef4 [^]
2015-03-19 07:22priyamNote Added: 0075763
2015-03-19 07:22priyamStatusresolved => closed
2015-04-01 11:51hgbotCheckin
2015-04-01 11:51hgbotNote Added: 0076303
2015-04-01 11:51hgbotStatusclosed => resolved
2015-04-01 11:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/17972a6e9e7ba9bb11b3e702c817cc839feacef4 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/2b06105e638c31e50f3e68103f90aa1b5d5427bc [^]
2015-04-01 11:52priyamNote Added: 0076304
2015-04-01 11:52priyamStatusresolved => closed

Notes
(0075074)
AugustoMauch   
2015-03-02 12:40   
The MenuTreeOperationManager class should be updated to allow moving menu tree nodes if there is a template in development, even if the module owner of the tree node being moved is not in development
(0075086)
hgbot   
2015-03-02 13:47   
Repository: erp/devel/pi
Changeset: f1360ce4b3d1861653f726626296ea743e16c52f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 02 13:45:56 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f1360ce4b3d1861653f726626296ea743e16c52f [^]

Fixes bug 29097: A menu tree node can be moved with a template in development

When the Openbravo Trees were reimplemented [1], there was a problem reimplementing the logic done when a Menu tree item is moved. Before the reimplementation, it was possible to move a menu tree item if the module it belonged to was in development or if there was any template module in development. The reimplementation did not take into account the templates, so from then on it has not been possible to moved menu tree nodes having a template in development.

To fix this, templates are taken into accout in the MenuTreeOperationManager class.

[1] https://issues.openbravo.com/view.php?id=25906 [^]

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/treeChecks/MenuTreeOperationManager.java
---
(0075087)
AugustoMauch   
2015-03-02 13:51   
A test has been defined in testlink [1]

[1] http://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8056 [^]
(0075122)
hudsonbot   
2015-03-03 16:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f4fc528722d4 [^]
Maturity status: Test
(0075294)
alostale   
2015-03-09 09:39   
Code reviewed

Tested with and without templates in dev
(0075762)
hgbot   
2015-03-19 07:17   
Repository: erp/backports/3.0PR14Q3.8
Changeset: 17972a6e9e7ba9bb11b3e702c817cc839feacef4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 02 13:45:56 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR14Q3.8/rev/17972a6e9e7ba9bb11b3e702c817cc839feacef4 [^]

Fixes bug 29097: A menu tree node can be moved with a template in development

When the Openbravo Trees were reimplemented [1], there was a problem reimplementing the logic done when a Menu tree item is moved. Before the reimplementation, it was possible to move a menu tree item if the module it belonged to was in development or if there was any template module in development. The reimplementation did not take into account the templates, so from then on it has not been possible to moved menu tree nodes having a template in development.

To fix this, templates are taken into accout in the MenuTreeOperationManager class.

[1] https://issues.openbravo.com/view.php?id=25906 [^]

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/treeChecks/MenuTreeOperationManager.java
---
(0075763)
priyam   
2015-03-19 07:22   
closing the issue, as the status changed to resolved when changeset transplanted to Q3
(0076303)
hgbot   
2015-04-01 11:51   
Repository: erp/backports/3.0PR15Q1.3
Changeset: 2b06105e638c31e50f3e68103f90aa1b5d5427bc
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 02 13:45:56 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.3/rev/2b06105e638c31e50f3e68103f90aa1b5d5427bc [^]

Fixes bug 29097: A menu tree node can be moved with a template in development

When the Openbravo Trees were reimplemented [1], there was a problem reimplementing the logic done when a Menu tree item is moved. Before the reimplementation, it was possible to move a menu tree item if the module it belonged to was in development or if there was any template module in development. The reimplementation did not take into account the templates, so from then on it has not been possible to moved menu tree nodes having a template in development.

To fix this, templates are taken into accout in the MenuTreeOperationManager class.

[1] https://issues.openbravo.com/view.php?id=25906 [^]

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/treeChecks/MenuTreeOperationManager.java
---
(0076304)
priyam   
2015-04-01 11:52   
closing the issue, as the status changed to resolved when changeset transplanted to 15Q1