Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029090Openbravo ERPA. Platformpublic2015-02-27 09:572015-11-23 21:17
caristu 
caristu 
lowtrivialalways
closedfixed 
5
 
3.0PR16Q1 
alostale
Core
No
0029090: Archiving while emailing should add attachment description "generated by e-mailing"
Archiving while emailing should add Attachment description "generated by e-mailing" instead of "generated by printing"
1) Send a document, for example a Sales Order, by e-mail, in the e-mail popup check the "Archive" checkbox
2) Notice that in the generated attachment the followin text is added: "generated by printing". It is more correct if it would add "generated by e-mailing"
In the ReportManager, the createAttachmentForReport() is putting directly the "Generated by printing " text in the attachment.

This method could be overriden by creating a new one that includes a String parameter for setting the text for the attachment. This way this new method could be called from the PrintController class in the e-mail generation part.
No tags attached.
related to design defect 0031496 acknowledged Triage Platform Base hardcoded and not translatable attachment description when printing/emailing document 
Issue History
2015-02-27 09:57caristuNew Issue
2015-02-27 09:57caristuAssigned To => AugustoMauch
2015-02-27 09:57caristuModules => Core
2015-02-27 09:57caristuResolution time => 1427925600
2015-02-27 09:57caristuTriggers an Emergency Pack => No
2015-02-27 09:57caristuIssue Monitored: networkb
2015-03-06 09:13alostaleStatusnew => acknowledged
2015-03-09 17:28jonalegriaesarteResolution time1427925600 =>
2015-03-11 08:10alostaleTarget Version3.0PR15Q2 =>
2015-03-17 14:37alostaleAssigned ToAugustoMauch => platform
2015-11-11 11:38alostalePriorityhigh => low
2015-11-16 09:44caristuAssigned Toplatform => caristu
2015-11-16 09:44caristuStatusacknowledged => scheduled
2015-11-16 09:57caristuReview Assigned To => alostale
2015-11-16 09:58caristuIssue Monitored: alostale
2015-11-16 10:01hgbotCheckin
2015-11-16 10:01hgbotNote Added: 0081863
2015-11-16 10:01hgbotStatusscheduled => resolved
2015-11-16 10:01hgbotResolutionopen => fixed
2015-11-16 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1f9854b6abd21a3b8bbf4ba7c2ceaa03cbcec842 [^]
2015-11-16 12:25alostaleNote Added: 0081870
2015-11-16 12:25alostaleStatusresolved => closed
2015-11-16 12:25alostaleFixed in Version => 3.0PR16Q1
2015-11-16 12:37alostaleRelationship addedrelated to 0031496
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082230

Notes
(0081863)
hgbot   
2015-11-16 10:01   
Repository: erp/devel/pi
Changeset: 1f9854b6abd21a3b8bbf4ba7c2ceaa03cbcec842
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Nov 16 10:00:45 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1f9854b6abd21a3b8bbf4ba7c2ceaa03cbcec842 [^]

fixes issue 29090: Archiving on email adds description 'generated by e-mailing'

Now the ReportManager overloads the createAttachmentForReport method in order to allow the ability of passing a description for the attachment

---
M src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0081870)
alostale   
2015-11-16 12:25   
code reviewed + tested
(0082230)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test