Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029076Openbravo ERP04. Warehouse managementpublic2015-02-26 12:442015-03-09 20:01
Reporterumartirena 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release3.0PR14Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029076: [Cost Adjustments] / by zero error while calculating backdated cost for movement qty 0 receipt
Description/ by zero error is obtained in Cost Adjustments while calculating backdated cost for movement qty 0 receipts.
Steps To ReproduceIn pgadmin III, open m_inout_post function:

 * Comment the 3 following lines (not reproducible in pi due to this issue https://issues.openbravo.com/view.php?id=26163 [^]):

IF v_Message_Qty != '' THEN
             RAISE EXCEPTION '%', '@Inline@ '||v_Message_Qty||' '||'@ProductNotNullAndMovementQtyZero@' ; --OBTG:-20000--
END IF;

 * Save the function.


In live.builds as F&B International:

 * Create a Product for F&B España. Add a Purchase Pricelist of 10.
 * Go to Goods Receipt and create a Header:
   - Org: F&B España
   - Movement Date: 05/02/2015
 * Add a line:
   - Product: The created product
   - Movement Qty: 10
 * Complete it
 * Create another Goods Receipt Header:
   - Org: F&B España
   - Movement Date: 15/02/2015
 * Add a line:
   - Product: The created product
   - Movement Qty: 0
 * Complete it
 * Create another Goods Receipt Header:
   - Org: F&B España
   - Movement Date: 10/02/2015
 * Add a line:
   - Product: The created product
   - Movement Qty: 12
 * Complete it
 * Run Costing Background process
 * Realize that following error is obtained:

ERROR org.openbravo.costing.CostingBackground - / by zero
java.lang.ArithmeticException: / by zero
    at java.math.BigDecimal.divideAndRound(BigDecimal.java:1424)
    at java.math.BigDecimal.divide(BigDecimal.java:1398)
    at java.math.BigDecimal.divide(BigDecimal.java:1513)
    at org.openbravo.costing.AverageCostAdjustment.getRelatedTransactionsByAlgorithm(AverageCostAdjustment.java:305)
    at org.openbravo.costing.CostingAlgorithmAdjustmentImp.searchRelatedTransactionCosts(CostingAlgorithmAdjustmentImp.java:160)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00291943.0PR15Q1.2 closed umartirena [Cost Adjustments] / by zero error while calculating backdated cost for movement qty 0 receipt 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-26 12:44umartirenaNew Issue
2015-02-26 12:44umartirenaAssigned To => Sandrahuguet
2015-02-26 12:44umartirenaOBNetwork customer => No
2015-02-26 12:44umartirenaModules => Core
2015-02-26 12:44umartirenaRegression introduced in release => 3.0PR14Q4
2015-02-26 12:44umartirenaTriggers an Emergency Pack => No
2015-02-26 12:44umartirenaAssigned ToSandrahuguet => umartirena
2015-02-26 13:03umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7787#r7787
2015-02-26 15:41umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7792#r7792
2015-02-26 19:36hgbotCheckin
2015-02-26 19:36hgbotNote Added: 0074998
2015-02-26 19:36hgbotStatusnew => resolved
2015-02-26 19:36hgbotResolutionopen => fixed
2015-02-26 19:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/67607f6caaeef3bbc200e13b54801928b42396ee [^]
2015-02-27 16:11hudsonbotCheckin
2015-02-27 16:11hudsonbotNote Added: 0075049
2015-03-06 15:18aferrazReview Assigned To => aferraz
2015-03-06 15:18aferrazNote Added: 0075251
2015-03-06 15:18aferrazStatusresolved => closed
2015-03-09 09:31umartirenaNote Added: 0075293
2015-03-09 09:31umartirenaStatusclosed => new
2015-03-09 09:31umartirenaResolutionfixed => open
2015-03-09 09:31umartirenaStatusnew => scheduled
2015-03-09 09:31umartirenaStatusscheduled => resolved
2015-03-09 09:31umartirenaFixed in Version => pi
2015-03-09 09:31umartirenaResolutionopen => fixed
2015-03-09 09:32umartirenaStatusresolved => closed
2015-03-09 20:01dmitry_mezentsevTag Attached: Approved
2015-03-09 20:01dmitry_mezentsevTag Detached: Approved

Notes
(0074998)
hgbot   
2015-02-26 19:36   
Repository: erp/devel/pi
Changeset: 67607f6caaeef3bbc200e13b54801928b42396ee
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Feb 26 15:29:20 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67607f6caaeef3bbc200e13b54801928b42396ee [^]

Fixes bug 29076: Division by zero error managed in Costing Background.

Under certain circumnstance a division by zero error was happening in Cost Adjustments process inside Costing Background (when calculating backdated adjustments of a transaction of movementqty zero). This problem has been managed by being sure that this division will not happen again. If the movementqty of the transaction is zero, the cost of the full transaction will be zero as well.

---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
(0075049)
hudsonbot   
2015-02-27 16:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7f9c56fa7aba [^]
Maturity status: Test
(0075251)
aferraz   
2015-03-06 15:18   
Code review + Testing OK
(0075293)
umartirena   
2015-03-09 09:31   
Reopened to add backport for 3.0PR15Q1.2