Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0029073 | Openbravo ERP | 07. Sales management | public | 2015-02-26 11:29 | 2015-03-27 10:25 |
|
| Reporter | egoitz | |
| Assigned To | umartirena | |
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR15Q2 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | eduardo_Argal |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0029073: Review deleting logic of tax lines in C_INVOICELINE_TRG2 |
| Description | When posting a Sales Invoice, logic for recreating the tax lines should be reviewed in order to modify existing ones instead of deleting and recreating them. |
| Steps To Reproduce | Using PG:
-Enable function statistics:
-In postgresql.conf set track_functions = all
-/etc/init.d/postgresql reload
-Create a sales invoice with one line
-Reset pg statistics: select pg_stat_reset();
-Book it
* Check function calls: select funcname, calls, total_time, self_time from pg_stat_user_functions order by self_time desc |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0027338 | | new | dmiguelez | Review deleting logic of tax lines in C_ORDERLINE_TRG2 | | related to | defect | 0027160 | | closed | eduardo_Argal | C_Order_Post poor performance | | related to | defect | 0029431 | | closed | umartirena | It is not possible to delete an invoice line when using price including taxes |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-02-26 11:29 | egoitz | New Issue | |
| 2015-02-26 11:29 | egoitz | Assigned To | => Sandrahuguet |
| 2015-02-26 11:29 | egoitz | Modules | => Core |
| 2015-02-26 11:29 | egoitz | Resolution time | => 1425337200 |
| 2015-02-26 11:29 | egoitz | Triggers an Emergency Pack | => No |
| 2015-02-26 11:30 | egoitz | Relationship added | related to 0027338 |
| 2015-02-26 11:50 | jpcalvente | Issue Monitored: jpcalvente | |
| 2015-02-26 12:04 | egoitz | Target Version | => 3.0PR15Q2 |
| 2015-02-27 11:25 | dmitry_mezentsev | Relationship added | related to 0027160 |
| 2015-03-23 10:28 | eduardo_Argal | Status | new => scheduled |
| 2015-03-23 10:28 | eduardo_Argal | Assigned To | Sandrahuguet => umartirena |
| 2015-03-23 10:28 | hgbot | Checkin | |
| 2015-03-23 10:28 | hgbot | Note Added: 0075845 | |
| 2015-03-23 10:28 | hgbot | Status | scheduled => resolved |
| 2015-03-23 10:28 | hgbot | Resolution | open => fixed |
| 2015-03-23 10:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/35a4e54c3ffc47aa4c1ee6507085032b6ac32ae6 [^] |
| 2015-03-23 10:31 | eduardo_Argal | Review Assigned To | => eduardo_Argal |
| 2015-03-23 10:31 | eduardo_Argal | Note Added: 0075846 | |
| 2015-03-23 10:31 | eduardo_Argal | Status | resolved => closed |
| 2015-03-23 16:24 | hudsonbot | Checkin | |
| 2015-03-23 16:24 | hudsonbot | Note Added: 0075884 | |
| 2015-03-27 10:25 | umartirena | Relationship added | related to 0029431 |
|
Notes |
|
|
(0075845)
|
|
hgbot
|
|
2015-03-23 10:28
|
|
Repository: erp/devel/pi
Changeset: 35a4e54c3ffc47aa4c1ee6507085032b6ac32ae6
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Mar 11 13:52:26 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/35a4e54c3ffc47aa4c1ee6507085032b6ac32ae6 [^]
Fixes bug 29073: InvoiceLine tax delete only is done when is needed
C_INVOICELINE_TRG2 has been changed to better manage when Invoice Line taxes are deleted and created again. Instead of doing it on every time an invoiceline is inserted or updated, it will be done when certain values in Invoice Line are changed and this affects in the related Invoice Line Tax record. The result will be the same, because with the previous code when there was no change in the Invoice Line the Invoice Line taxes were recreated with the same values as before, and now will be skipped.
Apart of this previous change, all not used variables have been removed, and in the same way a complete select sentence that was obtaining values that were not used later.
---
M src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
---
|
|
|
|
|
Code Reviewed and tested.
Performance figures in testing (using 4000 lines invoice)
Before: 732696.439;
After: 88269.735; |
|
|
|
|
|