Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0029064 | Openbravo ERP | A. Platform | public | 2015-02-25 13:15 | 2015-05-07 22:16 |
|
| Reporter | caristu | |
| Assigned To | NaroaIriarte | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | 3.0PR15Q3 | Fixed in Version | 3.0PR15Q3 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | OBPS |
| Web browser | |
| Modules | Core |
| Support ticket | 34651 |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0029064: When you create a note, the created record in table obuiapp_note has context organization instead of document organization |
| Description | When you create a note, the created record in table obuiapp_note has context organization instead of document organization |
| Steps To Reproduce | -Login to ERP
-Your context should have "España Norte" organization
-Go to window sales order and select an order with organization "F&B US East Coast"
-Create a Note for that order
-Login with a role that only have access to "F&B US East Coast" verify that can not see the new Note
The problem is that created record in table obuiapp_note has context organization instead of document organization.
It will be necessary a modulescript |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0028842 | | closed | NaroaIriarte | When you attach a file, the created record in table c_file has context organization instead of document organization | | has duplicate | defect | 0029057 | | closed | AugustoMauch | When you create a note, the created record in table has context organization instead of document organization |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-02-25 13:15 | caristu | New Issue | |
| 2015-02-25 13:15 | caristu | Assigned To | => AugustoMauch |
| 2015-02-25 13:15 | caristu | OBNetwork customer | => Yes |
| 2015-02-25 13:15 | caristu | Modules | => Core |
| 2015-02-25 13:15 | caristu | Support ticket | => 34651 |
| 2015-02-25 13:15 | caristu | Resolution time | => 1431468000 |
| 2015-02-25 13:15 | caristu | Triggers an Emergency Pack | => No |
| 2015-02-25 13:15 | caristu | Relationship added | related to 0028842 |
| 2015-02-25 13:16 | caristu | Issue Monitored: networkb | |
| 2015-02-25 13:16 | caristu | version | => pi |
| 2015-02-25 13:16 | caristu | Target Version | => 3.0PR15Q2 |
| 2015-02-25 13:19 | jecharri | Relationship added | has duplicate 0029057 |
| 2015-02-25 16:34 | alostale | Status | new => scheduled |
| 2015-02-25 16:34 | alostale | Assigned To | AugustoMauch => NaroaIriarte |
| 2015-02-25 16:34 | alostale | fix_in_branch | => pi |
| 2015-03-13 10:35 | jonalegriaesarte | Target Version | 3.0PR15Q2 => 3.0PR15Q3 |
| 2015-03-13 10:35 | jonalegriaesarte | fix_in_branch | pi => |
| 2015-03-30 08:30 | alostale | Severity | minor => major |
| 2015-04-22 17:01 | hgbot | Checkin | |
| 2015-04-22 17:01 | hgbot | Note Added: 0076698 | |
| 2015-04-22 17:01 | hgbot | Status | scheduled => resolved |
| 2015-04-22 17:01 | hgbot | Resolution | open => fixed |
| 2015-04-22 17:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f919925114f0ef8544e4137a66ecbb8d1c083128 [^] |
| 2015-04-22 17:01 | hgbot | Checkin | |
| 2015-04-22 17:01 | hgbot | Note Added: 0076699 | |
| 2015-04-24 12:54 | alostale | Review Assigned To | => alostale |
| 2015-04-24 13:48 | alostale | Note Added: 0076752 | |
| 2015-04-24 13:48 | alostale | Status | resolved => closed |
| 2015-04-24 13:48 | alostale | Fixed in Version | => 3.0PR15Q3 |
| 2015-04-24 14:07 | hgbot | Checkin | |
| 2015-04-24 14:07 | hgbot | Note Added: 0076753 | |
| 2015-05-07 22:16 | hudsonbot | Checkin | |
| 2015-05-07 22:16 | hudsonbot | Note Added: 0077143 | |
| 2015-05-07 22:16 | hudsonbot | Checkin | |
| 2015-05-07 22:16 | hudsonbot | Note Added: 0077144 | |
| 2015-05-07 22:16 | hudsonbot | Checkin | |
| 2015-05-07 22:16 | hudsonbot | Note Added: 0077154 | |
|
Notes |
|
|
(0076698)
|
|
hgbot
|
|
2015-04-22 17:01
|
|
Repository: erp/devel/pi
Changeset: f919925114f0ef8544e4137a66ecbb8d1c083128
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Apr 22 16:57:29 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f919925114f0ef8544e4137a66ecbb8d1c083128 [^]
Fixed issue 29064:There are problems with the organization of the notes.
There were two problems:
First: When a note was created, it had context organization instead of document organization.
To fix this, a new field which stores the note's organization has been created in the "ob-view-form-notes.js".
Second: If a note was added with an organization and after that the organization of the note
was changed, there were problems to handle it.
A new manual datasource has been created for handling the fetch,add and remove operations of the notes,
making sure that the organization filter is disabled. So, we grant the fact that if a user of one
organization creates a note and after that the organization of the note is changed to another one which
the user has not access, the user will be able to see or delete the note.
---
M modules/org.openbravo.client.application/src-db/database/sourcedata/OBSERDS_DATASOURCE.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
A modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
---
|
|
|
|
(0076699)
|
|
hgbot
|
|
2015-04-22 17:01
|
|
Repository: erp/devel/pi
Changeset: 347fbcf3401ff71f69a642171b624869b9ba8865
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Apr 22 16:58:41 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/347fbcf3401ff71f69a642171b624869b9ba8865 [^]
Related with issue 29064: Added test for the new NoteDataSource
A test for making sure that the new manual data source for the notes works properly.
It does the fetch, add and remove methods of the NoteDataSource.java.
The testFetchNotes test has a user of an American organization which creates a new note, so the note's
organization is the same American organization. After that the organization of the note is changed to
another one which is a Spanish organization for making sure that the two organization are divergent.
After that a fetch is done, now, the user has no access to the new organization of the note, but it have
to be possible fetching the note. This is what this test does, a fetch making sure that the filter by the
organizations is not done.
The class DatasourceTestUtil has been modified for the correct performance of the testRemoveNotes.
---
M src-test/src/org/openbravo/test/AllWebserviceTests.java
M src-test/src/org/openbravo/test/datasource/DatasourceTestUtil.java
A src-test/src/org/openbravo/test/datasource/TestNoteDatasource.java
---
|
|
|
|
|
|
|
|
(0076753)
|
|
hgbot
|
|
2015-04-24 14:07
|
|
Repository: erp/devel/pi
Changeset: 7eac27cd74409e5afa62baa57a45236d898dba4d
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Apr 24 14:04:00 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7eac27cd74409e5afa62baa57a45236d898dba4d [^]
Related with issue 29064: Restricted the method's visbilty.
The method's visibility has been modified from protected to private because the method
was only used in the current class.
---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|