Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029029Openbravo ERP09. Financial managementpublic2015-02-23 17:002015-04-01 08:47
Reporteraferraz 
Assigned Toaferraz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-01-30
Regression introduced in release3.0MP20
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/ddafe117203b20b2319a0f81db5a836af99bc44c [^]
Triggers an Emergency PackNo
Summary0029029: SL_Journal_Period raises an exception when it is called from G/L Journal Batch tab
DescriptionWhen SL_Journal_Period callout is called from G/L Journal Batch tab, it raises an exception because acctSchema is null.
Steps To ReproduceAs group admin role:

Create a record in the GL Journal window
Change the Document date
Realize a NullPointerException is raised in the log of Openbravo.
Proposed SolutionSLJournalPeriodData.getCurrencyRate should be call only if acctSchema is not null
Additional Information
TagsNo tags attached.
Relationships
caused by defect 00219753.0MP20 closed ioritzCia It does not take into account the 'Rate' value defined in G/L Journal window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-23 17:00aferrazNew Issue
2015-02-23 17:00aferrazAssigned To => aferraz
2015-02-23 17:00aferrazModules => Core
2015-02-23 17:00aferrazTriggers an Emergency Pack => No
2015-02-23 17:28aferrazRegression level => Production - Confirmed Stable
2015-02-23 17:28aferrazRegression date => 2013-01-30
2015-02-23 17:28aferrazRegression introduced in release => 3.0MP20
2015-02-23 17:28aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/ddafe117203b20b2319a0f81db5a836af99bc44c [^]
2015-02-23 17:32aferrazRelationship addedcaused by 0021975
2015-02-24 17:00aferrazPrioritynormal => immediate
2015-02-25 18:20hgbotCheckin
2015-02-25 18:20hgbotNote Added: 0074923
2015-02-25 18:20hgbotStatusnew => resolved
2015-02-25 18:20hgbotResolutionopen => fixed
2015-02-25 18:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e72f5b99ab8bcd4a2f5e74566397ab32711543ec [^]
2015-02-25 18:22SandrahuguetReview Assigned To => Sandrahuguet
2015-02-25 18:22SandrahuguetNote Added: 0074926
2015-02-25 18:22SandrahuguetStatusresolved => closed
2015-02-25 18:22SandrahuguetFixed in Version => 3.0PR15Q2
2015-02-25 18:27aferrazNote Added: 0074931
2015-02-26 22:39hudsonbotCheckin
2015-02-26 22:39hudsonbotNote Added: 0075002
2015-04-01 08:05hgbotCheckin
2015-04-01 08:05hgbotNote Added: 0076195
2015-04-01 08:05hgbotStatusclosed => resolved
2015-04-01 08:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e72f5b99ab8bcd4a2f5e74566397ab32711543ec [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/59ef94f008159dd15e1e873f70ee0468fa0b1484 [^]
2015-04-01 08:47priyamStatusresolved => closed
2015-04-01 08:47priyamNote Added: 0076280

Notes
(0074923)
hgbot   
2015-02-25 18:20   
Repository: erp/devel/pi
Changeset: e72f5b99ab8bcd4a2f5e74566397ab32711543ec
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Feb 23 18:52:28 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e72f5b99ab8bcd4a2f5e74566397ab32711543ec [^]

Fixes issue 29029: SL_Journal_Period raises a NullPointer Exception

AcctSchema will be retrieved only if acctSchemaId is not null (G/L Journal Header tab). In other case (G/L Journal Batch tab) it will not.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period.java
---
(0074926)
Sandrahuguet   
2015-02-25 18:22   
Code review + testing OK
(0074931)
aferraz   
2015-02-25 18:27   
Test case added in Testlink:
http://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8046 [^]
(0075002)
hudsonbot   
2015-02-26 22:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bcc51efc87d5 [^]
Maturity status: Test
(0076195)
hgbot   
2015-04-01 08:05   
Repository: erp/backports/3.0PR15Q2
Changeset: 59ef94f008159dd15e1e873f70ee0468fa0b1484
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Feb 23 18:52:28 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/59ef94f008159dd15e1e873f70ee0468fa0b1484 [^]

Fixes issue 29029: SL_Journal_Period raises a NullPointer Exception

AcctSchema will be retrieved only if acctSchemaId is not null (G/L Journal Header tab). In other case (G/L Journal Batch tab) it will not.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period.java
---
(0076280)
priyam   
2015-04-01 08:47   
closed again, as the status changes due to merge of tag 15Q1.2 to backport repo Q2