Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029024Retail ModulesWeb POSpublic2015-02-23 13:542015-04-15 18:11
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q3 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029024: Improve the detection and documentation of supported browsers
DescriptionThe detection of supported browsers must be improved to match the Openbravo documentation published in http://wiki.openbravo.com/wiki/Retail:Hardware_and_Peripherals_Guide [^]
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029604 closed adrianromero OB.UTIL.SupportedBrowser information must me moved to file main.js 
causes defect 0029361 closed adrianromero Browser not supported message does not appear properly in some devices 
causes defect 0029362 closed adrianromero Browser not supported texts must be improved 
Attached Filespng Screenshot_2015-03-12-13-10-25.png (328,674) 2015-03-12 13:20
https://issues.openbravo.com/file_download.php?file_id=7886&type=bug
png Not_Supported.png (245,959) 2015-03-20 13:20
https://issues.openbravo.com/file_download.php?file_id=7906&type=bug
png

png Not_Recommended.png (288,684) 2015-03-20 13:20
https://issues.openbravo.com/file_download.php?file_id=7907&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-02-23 13:54adrianromeroNew Issue
2015-02-23 13:54adrianromeroAssigned To => marvintm
2015-02-23 13:54adrianromeroTriggers an Emergency Pack => No
2015-02-23 13:54adrianromeroAssigned Tomarvintm => adrianromero
2015-02-23 13:54adrianromeroStatusnew => scheduled
2015-03-10 16:23hgbotCheckin
2015-03-10 16:23hgbotNote Added: 0075409
2015-03-10 16:25adrianromeroNote Added: 0075410
2015-03-10 16:28adrianromeroReview Assigned To => marvintm
2015-03-12 13:19OrekariaFile Added: Screenshot_2015-03-12-13-10-25.png
2015-03-12 13:20OrekariaFile Deleted: Screenshot_2015-03-12-13-10-25.png
2015-03-12 13:20OrekariaFile Added: Screenshot_2015-03-12-13-10-25.png
2015-03-20 13:20dbazFile Added: Not_Supported.png
2015-03-20 13:20dbazFile Added: Not_Recommended.png
2015-03-20 13:33dbazNote Added: 0075801
2015-03-20 16:02adrianromeroRelationship addedcauses 0029361
2015-03-20 16:33adrianromeroRelationship addedcauses 0029362
2015-03-24 13:19hgbotCheckin
2015-03-24 13:19hgbotNote Added: 0075923
2015-03-24 13:19hgbotStatusscheduled => resolved
2015-03-24 13:19hgbotResolutionopen => fixed
2015-03-24 13:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/278e5d453c090c42036eb0ac93e041242008b187 [^]
2015-03-30 13:01OrekariaNote Added: 0076135
2015-03-30 13:01OrekariaStatusresolved => new
2015-03-30 13:01OrekariaResolutionfixed => open
2015-04-07 15:59hgbotCheckin
2015-04-07 15:59hgbotNote Added: 0076368
2015-04-07 15:59hgbotStatusnew => resolved
2015-04-07 15:59hgbotResolutionopen => fixed
2015-04-07 15:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/278e5d453c090c42036eb0ac93e041242008b187 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8326d00e1bc40f434070e98b3e71d0b2080219bc [^]
2015-04-15 10:22OrekariaNote Added: 0076546
2015-04-15 10:22OrekariaStatusresolved => new
2015-04-15 10:22OrekariaResolutionfixed => open
2015-04-15 10:22OrekariaNote Edited: 0076546bug_revision_view_page.php?bugnote_id=0076546#r8250
2015-04-15 18:04adrianromeroRelationship addedrelated to 0029604
2015-04-15 18:08adrianromeroReview Assigned Tomarvintm => Orekaria
2015-04-15 18:10OrekariaStatusnew => scheduled
2015-04-15 18:10OrekariaStatusscheduled => resolved
2015-04-15 18:10OrekariaFixed in Version => RR15Q2
2015-04-15 18:10OrekariaResolutionopen => fixed
2015-04-15 18:11OrekariaNote Added: 0076563
2015-04-15 18:11OrekariaStatusresolved => closed
2015-04-15 18:11OrekariaFixed in VersionRR15Q2 => RR15Q3

Notes
(0075409)
hgbot   
2015-03-10 16:23   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2bfe8a47cd10ed2c24a1b9c7049d9a126fc6f325
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Feb 23 13:59:15 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2bfe8a47cd10ed2c24a1b9c7049d9a126fc6f325 [^]

Issue 0029024: Improve the detection and documentation of supported browsers
* Added new functions to check browser.
* Added object with browsers requirements

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0075410)
adrianromero   
2015-03-10 16:25   
These are the changesets that implements this functionality:

changeset: 1175:2bfe8a47cd10
user: Adrián Romero <adrianromero@openbravo.com>
date: Mon Feb 23 13:59:15 2015 +0100
summary: Issue 0029024: Improve the detection and documentation of supported browsers

changeset: 1188:9690bda61629
parent: 1175:2bfe8a47cd10
user: Adrián Romero <adrianromero@openbravo.com>
date: Fri Feb 27 10:43:42 2015 +0100
summary: Moving supported browsers information

changeset: 1222:0115fa66cea6
parent: 1195:85a5d1d1b477
user: Adrián Romero <adrianromero@openbravo.com>
date: Tue Mar 10 11:59:45 2015 +0100
summary: Implementing supported browsers list

changeset: 1224:441dc5d7f0fe
user: Adrián Romero <adrianromero@openbravo.com>
date: Tue Mar 10 12:04:21 2015 +0100
summary: Fixing jslint warning

changeset: 1225:abbe7e2d8225
user: Adrián Romero <adrianromero@openbravo.com>
date: Tue Mar 10 12:56:43 2015 +0100
summary: Removing not needed object

changeset: 1226:b40efdc7fd90
user: Adrián Romero <adrianromero@openbravo.com>
date: Tue Mar 10 13:03:36 2015 +0100
summary: Fixing messages

changeset: 1227:a0dbd71ad574
tag: tip
user: Adrián Romero <adrianromero@openbravo.com>
date: Tue Mar 10 16:04:53 2015 +0100
summary: Removing throw exception when websql functionality does not exist
(0075801)
dbaz   
2015-03-20 13:33   
There are several things to be fine tuned.

The testing resolution should be the lowest supported one: 1024x768 (iPad)
Take a look to [Not_Supported.png] and [Not_Recommended.png] attached images.

Detected problems:

* In both cases the text exceeds the green box. (Review it also in the smartphone case)

* [Not_Supported.png]: The word "preferred" should be changed by "recommended", as it is the term used in the ERP, the documentation, the [Not_Recommended.png] case, ...

* [Not_Supported.png]: As in the ERP, the "or higher" text should be shown in the recommended browser case (ERP issue: https://issues.openbravo.com/view.php?id=28797 [^])
(0075923)
hgbot   
2015-03-24 13:19   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 278e5d453c090c42036eb0ac93e041242008b187
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Mar 24 13:18:26 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/278e5d453c090c42036eb0ac93e041242008b187 [^]

Fixes issue 0029024: Improve the detection and documentation of supported browsers
Added new category for not supported browsers but allowed to login. This category will be removed in future versions of Openbravo

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/ob-login.js
M web/org.openbravo.mobile.core/source/utils/ob-browserrequirements.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0076135)
Orekaria   
2015-03-30 13:01   
We use camel case
(0076368)
hgbot   
2015-04-07 15:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8326d00e1bc40f434070e98b3e71d0b2080219bc
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Apr 07 15:57:49 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8326d00e1bc40f434070e98b3e71d0b2080219bc [^]

Fixes issue 0029024: Improve the detection and documentation of supported browsers
Renaming variables to follow camel case policy

---
M web/org.openbravo.mobile.core/source/component/ob-login.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0076546)
Orekaria   
2015-04-15 10:22   
1)
Please move 'OB.UTIL.SupportedBrowsers' to openbravo/modules/org.openbravo.mobile.core/web/org.openbravo.mobile.core/source/main.js

That is the place where we can gather all versions for easier maintenance

2)
Please add exact instructions on how the version number must be retrieved. If it is a command line or a console instruction, much better

3)
This changes must be included in final Q2
(0076563)
Orekaria   
2015-04-15 18:11   
Further topics to be addressed at issue 29604