Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029018Retail ModulesWeb POSpublic2015-02-22 18:402015-03-30 13:34
Reporterjecharri 
Assigned Toaaroncalero 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR14Q3.5 
Target VersionFixed in VersionRR15Q2 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customerOBPS
Support ticket34279
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029018: Paymentmethodcashup table is not properly updated
DescriptionPaymentmethodcashup table is not properly updated. If the user press F5 or refresh the window in incorrect moment the paymentmetodcashup is not updated

We have a client with one example, log lines:
"21-02-2015 13:17:12","Warn","XXX","""SetPaymentMethod:Cash. totalSales: 548000. totalReturns: 0"""
"21-02-2015 13:17:12","Warn","XXX","""Cash up info transactions saved correctly"""
"21-02-2015 13:17:08","Warn","XXX","""getNextDocumentNo: 16537"""
"21-02-2015 13:17:07","Warn","XXX","""Executing of post order save hook."""
"21-02-2015 13:17:07","Warn","XXX","""SetTotalTransactions: 568000"""
"21-02-2015 13:17:07","Warn","XXX","""SetGrossSales: 568000"""
"21-02-2015 13:17:07","Warn","XXX","""SetNetSales: 516363.63636358"""
"21-02-2015 13:17:07","Warn","XXX","""SetNetSales: 498181.81818176"""
"21-02-2015 13:17:07","Warn","XXX","""SetGrossSales: 548000"""
"21-02-2015 13:17:07","Warn","XXX","""SetGrossSales: 500500"""
"21-02-2015 13:17:07","Warn","XXX","""SetNetSales: 454999.99999996"""
"21-02-2015 13:17:07","Warn","XXX","""Updating cashup"""
"21-02-2015 13:17:07","Warn","XXX","""Setting document sequence: {\""documentSequence\"":16536,\""quotationDocumentSequence\"":0,\""id\"":\""88DAE6D41457AE20CEBA9DD762191AF9\"",\""posSearchKey\"":\""XXX\""}"""
"21-02-2015 13:17:07","Warn","XXX","""Saving receipt."""
"21-02-2015 13:17:07","Warn","XXX","""Ticket closed. Id: 0ACFADF2FCDAE0B6E086337C63837619. Docno: DSK/0016536. Total gross: 77500. Lines: [{Product: RTL-Stick Pastry, Quantity: 1 Gross: 10000},{Product: RTL-Rotiboy, Quantity: 5 Gross: 47500},{Product: RTL-Butter Milk, Quantity: 2 Gross: 20000}] Payments: [{PaymentMethod: OBPOS_payment.cash, Amount: 77500 OrigAmount: 77500"""
"21-02-2015 13:12:46","Warn","XXX","""Login online"""
"21-02-2015 13:12:46","Warn","XXX","""triggerOnline"""
"21-02-2015 13:12:36","Warn","XXX","""getNextDocumentNo: 16536"""
"21-02-2015 13:12:15","Warn","XXX","""Setting document sequence: {\""documentSequence\"":16535,\""quotationDocumentSequence\"":0,\""id\"":\""88DAE6D41457AE20CEBA9DD762191AF9\"",\""posSearchKey\"":\""XXX\""}"""
"21-02-2015 13:12:11","Warn","XXX","""Login using cache"""
"21-02-2015 13:12:11","Debug","XXX","""next process:"" "
"21-02-2015 13:11:42","Warn","XXX","""SetTotalTransactions: 490500"""
"21-02-2015 13:11:42","Warn","XXX","""SetGrossSales: 490500"""
"21-02-2015 13:11:42","Warn","XXX","""SetGrossSales: 480500"""
"21-02-2015 13:11:42","Warn","XXX","""SetNetSales: 445909.09090905"""
"21-02-2015 13:11:42","Warn","XXX","""SetNetSales: 436818.18181814"""
"21-02-2015 13:11:42","Warn","XXX","""Updating cashup"""
"21-02-2015 13:11:42","Warn","XXX","""Setting document sequence: {\""documentSequence\"":16535,\""quotationDocumentSequence\"":0,\""id\"":\""88DAE6D41457AE20CEBA9DD762191AF9\"",\""posSearchKey\"":\""XXX\""}"""
"21-02-2015 13:11:42","Warn","XXX","""Saving receipt."""
"21-02-2015 13:11:41","Warn","XXX","""Ticket closed. Id: AC9F407EDEC0CB03CE22CB2BC74821C7. Docno: DSK/0016535. Total gross: 20000. Lines: [{Product: RTL-Choco Boy, Quantity: 1 Gross: 10000},{Product: RTL-Stick Pastry, Quantity: 1 Gross: 10000}] Payments: [{PaymentMethod: OBPOS_payment.cash, Amount: 20000 OrigAmount: 20000 """
"21-02-2015 13:10:08","Warn","XXX","""getNextDocumentNo: 16535"""
"21-02-2015 13:08:05","Warn","XXX","""Login online"""
"21-02-2015 13:08:05","Debug","XXX","""keypressHandler - keyCode: 13 - keyIdentifier: Enter - charCode: 0 - which: 13"""
"21-02-2015 13:08:05","Warn","XXX","""triggerOnline"""
"21-02-2015 13:07:50","Warn","XXX","""getNextDocumentNo: 16535"""
"21-02-2015 13:07:31","Warn","XXX","""Setting document sequence: {\""documentSequence\"":16534,\""quotationDocumentSequence\"":0,\""id\"":\""88DAE6D41457AE20CEBA9DD762191AF9\"",\""posSearchKey\"":\""XXX\""}"""
"21-02-2015 13:07:27","Warn","XXX","""Login using cache"""
"21-02-2015 13:07:27","Debug","XXX","""next process:"" "
"21-02-2015 13:07:12","Warn","XXX","""Logout"""
"21-02-2015 13:07:12","Warn","XXX","""logout button pushed"""
"21-02-2015 13:07:05","Warn","XXX","""triggerOffline"""
"21-02-2015 13:06:50","Warn","XXX","""session not valid popup shown"""
"21-02-2015 13:06:50","Warn","XXX","""triggerOnline"""
"21-02-2015 13:05:50","Warn","XXX","""triggerOffline"""
"21-02-2015 13:05:35","Warn","XXX","""session not valid popup shown"""
"21-02-2015 13:05:35","Warn","XXX","""triggerOnline"""
"21-02-2015 13:05:33","Warn","XXX","""triggerOffline"""
"21-02-2015 13:05:27","Warn","XXX","""triggerOffline"""
"21-02-2015 13:05:27","Warn","XXX","""Updating cashup"""
"21-02-2015 13:05:24","Warn","XXX","""SetPaymentMethod:Cash. totalSales: 470500. totalReturns: 0"""
"21-02-2015 13:05:24","Warn","XXX","""Cash up info transactions saved correctly"""

We can see that after last ticket is closed the total is "SetPaymentMethod:Cash. totalSales: 470500. totalReturns: 0" however we can see that after that 2 new tickets are created:
-DSK/0016535 = 20000
-DSK/0016536 = 77500
Total should be 470500 + 20000 + 77500 = 568000 however the total is set to "SetPaymentMethod:Cash. totalSales: 548000. totalReturns: 0" losing 20000.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029017RR15Q3 closed aaroncalero Paymentmethodcashup table is not properly updated 
related to defect 0029019RR15Q2 closed marvintm Sales order documentno's can be repeated in Web POS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-22 18:40jecharriNew Issue
2015-02-22 18:40jecharriAssigned To => marvintm
2015-02-22 18:40jecharriOBNetwork customer => Yes
2015-02-22 18:40jecharriSupport ticket => 34279
2015-02-22 18:40jecharriResolution time => 1424818800
2015-02-22 18:40jecharriTriggers an Emergency Pack => No
2015-02-22 18:40jecharriIssue generated from0029017
2015-02-22 18:58jecharriRelationship addedrelated to 0029017
2015-03-06 08:57hgbotCheckin
2015-03-06 08:57hgbotNote Added: 0075223
2015-03-06 08:57hgbotStatusnew => resolved
2015-03-06 08:57hgbotResolutionopen => fixed
2015-03-06 08:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9bc1b0fcb8a86812e92e75545fb7d4a42a9500c [^]
2015-03-06 14:12hgbotCheckin
2015-03-06 14:12hgbotNote Added: 0075249
2015-03-06 14:13aaroncaleroAssigned Tomarvintm => aaroncalero
2015-03-06 14:13aaroncaleroStatusresolved => new
2015-03-06 14:13aaroncaleroResolutionfixed => open
2015-03-13 13:39hgbotCheckin
2015-03-13 13:39hgbotNote Added: 0075556
2015-03-13 13:39hgbotStatusnew => resolved
2015-03-13 13:39hgbotResolutionopen => fixed
2015-03-13 13:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9bc1b0fcb8a86812e92e75545fb7d4a42a9500c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96f4affa86ce6bab5a24b719758c5c30149dd87a [^]
2015-03-13 14:40hgbotCheckin
2015-03-13 14:40hgbotNote Added: 0075567
2015-03-13 23:43OrekariaNote Added: 0075586
2015-03-13 23:43OrekariaStatusresolved => new
2015-03-13 23:43OrekariaResolutionfixed => open
2015-03-13 23:49OrekariaNote Edited: 0075586bug_revision_view_page.php?bugnote_id=0075586#r7963
2015-03-13 23:53hgbotCheckin
2015-03-13 23:53hgbotNote Added: 0075587
2015-03-14 06:12OrekariaNote Deleted: 0075586
2015-03-23 15:56marvintmStatusnew => scheduled
2015-03-23 15:57marvintmStatusscheduled => resolved
2015-03-23 15:57marvintmResolutionopen => fixed
2015-03-27 10:49aaroncaleroRelationship addedrelated to 0029019
2015-03-27 11:05OrekariaNote Added: 0076064
2015-03-30 13:34malsasuaReview Assigned To => malsasua
2015-03-30 13:34malsasuaNote Added: 0076138
2015-03-30 13:34malsasuaStatusresolved => closed
2015-03-30 13:34malsasuaFixed in Version => RR15Q2

Notes
(0075223)
hgbot   
2015-03-06 08:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d9bc1b0fcb8a86812e92e75545fb7d4a42a9500c
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 06 08:47:36 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d9bc1b0fcb8a86812e92e75545fb7d4a42a9500c [^]

Fixed issue 29018: Paymentmethodcashup table is not properly updated.

Changed the order of actions to ensure that the receipt is saved and (if online) sent to the server only after updating the paymentmethodcashup table

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0075249)
hgbot   
2015-03-06 14:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 10348391772930af559ad03cddaa2c1e9dcd1d3b
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 06 14:09:46 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/10348391772930af559ad03cddaa2c1e9dcd1d3b [^]

Related to issue 29018: Temporarily backout changeset d9bc1b0fcb8a as it's breaking 2 tests

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0075556)
hgbot   
2015-03-13 13:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 96f4affa86ce6bab5a24b719758c5c30149dd87a
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 13 13:22:42 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96f4affa86ce6bab5a24b719758c5c30149dd87a [^]

Fixed issue 29018: Paymentmethodcashup table is not properly updated

Changed the order of actions to ensure that the receipt is saved and (if online) sent to the server only after updating the paymentmethodcashup table
Also refactored the way the current order's docNo is handled, to ensure that it is correctly updated after closing a receipt

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0075567)
hgbot   
2015-03-13 14:40   
Repository: tools/automation/pi-mobile
Changeset: 3ac65d9cdf313bee00c94fa62aa75b797b5e5452
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 13 13:34:24 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3ac65d9cdf313bee00c94fa62aa75b797b5e5452 [^]

Related to issue 29018: Changed BackboneHelper to use the new callback when updating the docNo

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/BackboneHelper.java
---
(0075587)
hgbot   
2015-03-13 23:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7c9c2f44822bbf01bfde24657483994a34550352
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Mar 13 23:47:38 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7c9c2f44822bbf01bfde24657483994a34550352 [^]

Related to issue 29018: Backed out multiorders related changeset

As multiorders follow a diferent flow, the callback may not be required. This should be properly verified.

< Preemptive action >

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0076064)
Orekaria   
2015-03-27 11:05   
When closing, please close also the related 29019
(0076138)
malsasua   
2015-03-30 13:34   
verified