Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028973Openbravo ERP09. Financial managementpublic2015-02-17 19:052017-03-30 17:27
Reporterngarcia 
Assigned Toreinaldoguerra 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028973: G/L Journal can be posted in a closed period. It cannot be unposted then
DescriptionG/L Journal can be posted in a closed period. It cannot be unposted then
Steps To ReproduceAs group admin role:
   Unschedule the Acct Server Process
   Create a G/L Journal for F&B US, Inc. and accounting date in an open period
   Create a Header
   Create two lines and complete it
   Go to Open/Close Period Control window and close the period the accounting date belongs to
   Check you can post the G/L Journal and you should not
   Try to unpost it and check the following error message is shown:
      Period Closed. It is not possible to unpost a document in a closed period
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00289523.0PR15Q3 closed fsoto82 Period Not Updated in G/L Journal if the Accounting Date belongs to a closed period. It is not possible to unpost it 
causes defect 0035560 closed markmm82 "Adjustment Period" not used when posting a GL Journal 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-17 19:05ngarciaNew Issue
2015-02-17 19:05ngarciaAssigned To => Sandrahuguet
2015-02-17 19:05ngarciaModules => Core
2015-02-17 19:05ngarciaResolution time => 1427065200
2015-02-17 19:05ngarciaTriggers an Emergency Pack => No
2015-02-17 19:05ngarciaRelationship addedrelated to 0028952
2015-03-02 21:18reinaldoguerraAssigned ToSandrahuguet => reinaldoguerra
2015-03-02 21:18reinaldoguerraStatusnew => scheduled
2015-03-03 17:00reinaldoguerraNote Added: 0075131
2015-04-24 15:03hgbotCheckin
2015-04-24 15:03hgbotNote Added: 0076758
2015-04-24 15:03hgbotStatusscheduled => resolved
2015-04-24 15:03hgbotResolutionopen => fixed
2015-04-24 15:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1881cfa4bb9cfee7916d7c730a3955a050366ae7 [^]
2015-04-24 15:04vmromanosReview Assigned To => vmromanos
2015-04-24 15:04vmromanosNote Added: 0076759
2015-04-24 15:04vmromanosStatusresolved => closed
2015-05-04 17:55aferrazRelationship deletedrelated to 0028952
2015-05-04 17:59aferrazRelationship addedblocks 0028952
2015-05-07 22:16hudsonbotCheckin
2015-05-07 22:16hudsonbotNote Added: 0077157
2017-03-17 14:06maiteRelationship addedcauses 0035560
2017-03-30 10:27hgbotCheckin
2017-03-30 10:27hgbotNote Added: 0095692
2017-03-30 11:35hgbotCheckin
2017-03-30 11:35hgbotNote Added: 0095696
2017-03-30 11:36hgbotCheckin
2017-03-30 11:36hgbotNote Added: 0095701
2017-03-30 17:27hudsonbotCheckin
2017-03-30 17:27hudsonbotNote Added: 0095730

Notes
(0075131)
reinaldoguerra   
2015-03-03 17:00   
Test plan used:
1- Login into Openbravo ERP
2- Go to Process Request window and select Acct Server Process
3- Click on Unschedule button
4- Go to G/L Journal window and create a new record
5- Select organization = F&B US, Inc. and enter a description. Enter 28/05/2014 as Document and Accounting dates (May-14 will be selected as period)
6- Create a new Header. Enter 28/05/2014 as Document and Accounting dates again and select "F&B International Group US/A/US Dollar" as General Ledger
7- Go to Lines tab and create two of them, one with a Credit value and the other with Debit. Both same values.
8- Complete the header
9- Go to Open/Close Period Control window and select the period the accounting date belongs to. In this case "May-14" for F&B US, Inc. organization.
10- Click Close Period button.
11- Go back to G/L Journal header and try to post it
12- Realize that now an error message in shown indicating the period is closed.
(0076758)
hgbot   
2015-04-24 15:03   
Repository: erp/devel/pi
Changeset: 1881cfa4bb9cfee7916d7c730a3955a050366ae7
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Tue Mar 03 10:56:59 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/1881cfa4bb9cfee7916d7c730a3955a050366ae7 [^]

Fixed bug 28973: G/L Journal can be posted in a closed period.

Just like happens in other accounting document clases, the method "loadDocumentDetails" in "DocGLJournal" class was changed to exclude the C_Period_ID field value assignment, which is obtained correctly later in the AcctServer superclass, launching an error when trying to post a G/L Journal in a closes period.
Also the value for period passed as parameter in the method "loadDocumentDetails" is wrong calculated due to the period's organization is not taken into account.
With the changed proposed, the correct journal's period is checked, so if it is closed, an error is shown when posting the document.

---
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
---
(0076759)
vmromanos   
2015-04-24 15:04   
Code review + testing OK
(0077157)
hudsonbot   
2015-05-07 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0095692)
hgbot   
2017-03-30 10:27   
Repository: erp/devel/pi
Changeset: a998052fc4257f6f143fff8ebb8ffec68dea1302
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Mar 30 10:25:21 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a998052fc4257f6f143fff8ebb8ffec68dea1302 [^]

Related to issue 35560: Code review improvements

Backout fixes of issues 35560 & 28973 and fix issue 28973 properly:
DocGLJournal.isperiodOpen method was not correctly checking if DocGLJournalData.periodOpen retrieves no period.

---
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal_data.xsql
---
(0095696)
hgbot   
2017-03-30 11:35   
Repository: erp/backports/3.0PR17Q1.1
Changeset: 83fdc86f6bff3eae801dc18043631689896d980f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Mar 30 10:25:21 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/83fdc86f6bff3eae801dc18043631689896d980f [^]

Related to issue 35575: Code review improvements

Backout fixes of issues 35575 & 28973 and fix issue 28973 properly:
DocGLJournal.isperiodOpen method was not correctly checking if DocGLJournalData.periodOpen retrieves no period.

---
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal_data.xsql
---
(0095701)
hgbot   
2017-03-30 11:36   
Repository: erp/backports/3.0PR16Q4.4
Changeset: 8260e60d91d1d6260253eb697ea72898e256f837
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Mar 30 10:25:21 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q4.4/rev/8260e60d91d1d6260253eb697ea72898e256f837 [^]

Related to issue 35576: Code review improvements

Backout fixes of issues 35576 & 28973 and fix issue 28973 properly:
DocGLJournal.isperiodOpen method was not correctly checking if DocGLJournalData.periodOpen retrieves no period.

---
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
M src/org/openbravo/erpCommon/ad_forms/DocGLJournal_data.xsql
---
(0095730)
hudsonbot   
2017-03-30 17:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fbf76c4a22c1 [^]
Maturity status: Test