Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028952Openbravo ERP09. Financial managementpublic2015-02-16 13:362015-05-07 22:17
Reporterngarcia 
Assigned Tofsoto82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028952: Period Not Updated in G/L Journal if the Accounting Date belongs to a closed period. It is not possible to unpost it
DescriptionPeriod Not Updated in G/L Journal if the Accounting Date belongs to a closed period. It allows to save a record with an accounting date that does not belong to the period.
Steps To ReproduceAs group admin role:
   Create a G/L Journal for F&B US, Inc.
   Set the Currency to USD
   Leave Accounting Date and Document Date with today's date and check the Period is filled correctly
   Create a Header with the same values, add two lines to it (in order to be balanced) and complete it
   Change the Accounting Date of the Header to a date which belongs to a Closed period
   Check the Period is not updated
   Post it and check it is posted with the accounting date (although the period it belongs to is closed)
   Try to unpost it and check you get the following error message:
      Period Closed. It is not possible to unpost a document in a closed period
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028943 closed aferraz It should be possible to enter different accounting and document date in GL Journal and Header 
depends on defect 0028973 closed reinaldoguerra G/L Journal can be posted in a closed period. It cannot be unposted then 
causes defect 0031860 closed AtulOpenbravo Cannot save a G/L Journal header with the date of the adjustment period if both periods are opened 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-16 13:36ngarciaNew Issue
2015-02-16 13:36ngarciaAssigned To => Sandrahuguet
2015-02-16 13:36ngarciaModules => Core
2015-02-16 13:36ngarciaResolution time => 1426546800
2015-02-16 13:36ngarciaTriggers an Emergency Pack => No
2015-02-16 13:39ngarciaRelationship addeddepends on 0028943
2015-02-16 13:39ngarciaIssue Monitored: networkb
2015-02-16 14:16ngarciaNote Added: 0074511
2015-02-17 19:05ngarciaRelationship addedrelated to 0028973
2015-02-23 13:30jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-03-02 15:51fsoto82Statusnew => scheduled
2015-03-02 15:51fsoto82Assigned ToSandrahuguet => fsoto82
2015-03-02 15:51fsoto82fix_in_branch => pi
2015-03-24 15:00fsoto82Note Added: 0075934
2015-05-04 17:55aferrazRelationship deleteddepends on 0028943
2015-05-04 17:55aferrazRelationship deletedrelated to 0028973
2015-05-04 17:55aferrazRelationship addedrelated to 0028943
2015-05-04 17:59aferrazRelationship addeddepends on 0028973
2015-05-06 10:17hgbotCheckin
2015-05-06 10:17hgbotNote Added: 0077043
2015-05-06 10:17hgbotStatusscheduled => resolved
2015-05-06 10:17hgbotResolutionopen => fixed
2015-05-06 10:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/908de92996757265cce434502b36adf8860d6450 [^]
2015-05-06 10:17hgbotCheckin
2015-05-06 10:17hgbotNote Added: 0077044
2015-05-06 10:18aferrazReview Assigned To => aferraz
2015-05-06 10:18aferrazNote Added: 0077045
2015-05-06 10:18aferrazStatusresolved => closed
2015-05-06 10:18aferrazFixed in Version => 3.0PR15Q3
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077217
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077218
2016-01-11 14:15ngarciaRelationship addedcauses 0031860

Notes
(0074511)
ngarcia   
2015-02-16 14:16   
Inconsistent data should be corrected. The processed records in G/L Journal window can have an accounting date which does not belong to the defined period. For posted records, the inconsistency is both in the GL_JOURNAL and FACT_ACCT tables
(0075934)
fsoto82   
2015-03-24 15:00   
As group admin role:
   Create a G/L Journal for F&B US, Inc.
   Set the Currency to USD
   Leave Accounting Date and Document Date with today's date and check the Period is filled correctly
   Create a Header with the same values, add two lines to it (in order to be balanced) and complete it
   Change the Accounting Date of the Header to a date which belongs to a Closed period
   An Error messsge is displayed and is not allowed to save the record if the date belongs to a closed period
(0077043)
hgbot   
2015-05-06 10:17   
Repository: erp/devel/pi
Changeset: 908de92996757265cce434502b36adf8860d6450
Author: Fernando Soto <fernando.soto <at> peoplewalking.com>
Date: Mon Mar 23 14:11:56 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/908de92996757265cce434502b36adf8860d6450 [^]

Fixed bug 28952: Period Not Updated in G/L Journal if Acct Date belongs to a closed period.

Modified SL_Journal_Period class (callout) to display a error message if the Acct. Date belongs to a closed period.
Modified GL_JOURNAL_CHK_RESTRICT_TRG trigger to not allow to save if the Acct. Date belongs to a closed period.
Created UpdateGLJournalDateAcct to fix the data.

---
M src-db/database/model/triggers/GL_JOURNAL_CHK_RESTRICT_TRG.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period.java
---
(0077044)
hgbot   
2015-05-06 10:17   
Repository: erp/devel/pi
Changeset: 17cd117fb31b7007346b3a3c14a87b25f297bcd8
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 05 18:10:20 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/17cd117fb31b7007346b3a3c14a87b25f297bcd8 [^]

Related to issue 28952: Code review

Remove unused lines of code

---
M src-db/database/model/triggers/GL_JOURNAL_CHK_RESTRICT_TRG.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period.java
---
(0077045)
aferraz   
2015-05-06 10:18   
Code review + Testing OK
(0077217)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077218)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test