Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028927Openbravo ERPZ. Otherspublic2015-02-12 16:582015-05-07 22:17
Reportermaite 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket34297
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028927: Filtering criteria is removed when cancel "add transaction" from Match statement process
DescriptionAfter run "Match Statement" process user is able to set required filtering criteria, in order to filter required data. Then it press "+" (add) process in order to create related transaction. If, in that moment, user closes or cancel this pop-up to, for example, perform some verification or choose another bank statement line, he will lost filtering criteria previously set so it will need to start from the beginning.

Steps To Reproduce1. Access Financial Account "cuenta de banco" and create new Bank Statement record with one bank statement line. Process bank statement
2. Access last Reconciliation and Reactivate it
3. Run "Match Transaction" process. Realize that one pending bank statement line is shown (as data is filtered by default as matched=no)
4. Press "+" (add) button
5. Close pop-up or Cancel it
6. Realize that "match statement" filtering criteria has been removed, so grid is not only showing line pending of matching but also lines included in draft reconciliation
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-12 16:58maiteNew Issue
2015-02-12 16:58maiteAssigned To => dmiguelez
2015-02-12 16:58maiteOBNetwork customer => Yes
2015-02-12 16:58maiteModules => Core
2015-02-12 16:58maiteSupport ticket => 34297
2015-02-12 16:58maiteResolution time => 1426806000
2015-02-12 16:58maiteTriggers an Emergency Pack => No
2015-02-12 17:02maiteIssue Monitored: networkb
2015-02-12 17:04maiteModulesCore => Advanced Payables and Receivables Mngmt
2015-02-23 13:30jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-03-04 17:58SandrahuguetAssigned Todmiguelez => Sandrahuguet
2015-03-12 15:38reinaldoguerraAssigned ToSandrahuguet => reinaldoguerra
2015-03-12 15:38reinaldoguerraStatusnew => scheduled
2015-03-14 01:26reinaldoguerraNote Added: 0075589
2015-03-14 01:27reinaldoguerraNote Edited: 0075589bug_revision_view_page.php?bugnote_id=0075589#r7965
2015-04-28 10:20hgbotCheckin
2015-04-28 10:20hgbotNote Added: 0076811
2015-04-28 10:20hgbotStatusscheduled => resolved
2015-04-28 10:20hgbotResolutionopen => fixed
2015-04-28 10:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/75f919295b5f313a1a468560c717aff40dbd8b14 [^]
2015-04-28 10:20vmromanosReview Assigned To => vmromanos
2015-04-28 10:20vmromanosNote Added: 0076812
2015-04-28 10:20vmromanosStatusresolved => closed
2015-04-29 17:35vmromanosAssigned Toreinaldoguerra => umartirena
2015-04-29 17:35vmromanosNote Added: 0076879
2015-04-29 17:35vmromanosStatusclosed => new
2015-04-29 17:35vmromanosResolutionfixed => open
2015-04-29 17:55hgbotCheckin
2015-04-29 17:55hgbotNote Added: 0076882
2015-04-29 17:55vmromanosStatusnew => scheduled
2015-04-29 17:56vmromanosStatusscheduled => resolved
2015-04-29 17:56vmromanosResolutionopen => fixed
2015-04-29 17:56vmromanosNote Added: 0076883
2015-04-29 17:56vmromanosStatusresolved => closed
2015-05-07 22:16hudsonbotCheckin
2015-05-07 22:16hudsonbotNote Added: 0077168
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077186

Notes
(0075589)
reinaldoguerra   
2015-03-14 01:26   
(edited on: 2015-03-14 01:27)
Test plan used:
1- Login into Openbravo ERP
2- Access Financial Account window and select "Cuenta de Banco"
3- Create a new Bank Statement record (Imported Bank Statements tab) with one bank statement line. Process bank statement
4- Access last Reconciliation (Reconciliations tab) and Reactivate it
5- From header tab run "Match Transaction" process. Realize that one pending bank statement line is shown (as data is filtered by default as matched=no)
6- Press "+" (add) button
7- Close pop-up or Cancel it
8- Realize that "match statement" filtering criteria it is now conserved.
(0076811)
hgbot   
2015-04-28 10:20   
Repository: erp/devel/pi
Changeset: 75f919295b5f313a1a468560c717aff40dbd8b14
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Apr 27 18:58:05 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/75f919295b5f313a1a468560c717aff40dbd8b14 [^]

Fixed bug 28927: Filter is removed when cancel transactions from Match process

Changed OB.APRM.MatchStatement.onRefresh function in a similar way to OB.APRM.AddPayment.currencyOnChange function.
The previous criteria is kept (including the selected record) and used again to refresh the grid records and redraw the form.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
---
(0076812)
vmromanos   
2015-04-28 10:20   
Code review + testing OK
(0076879)
vmromanos   
2015-04-29 17:35   
Reopen: Unmatch process throws a javascript error:
Uncaught TypeError: Cannot read property 'push' of undefined
(0076882)
hgbot   
2015-04-29 17:55   
Repository: erp/devel/pi
Changeset: b98ca2c1def1174118ba14236ef9bea656f2c5c5
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Apr 29 09:31:14 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b98ca2c1def1174118ba14236ef9bea656f2c5c5 [^]

Related to bug 28927: Fix unmatching error

An error was being raised while doing unmatch when using 'addSelectedIDsToCriteria' method. The call to this method has been removed because it is not necessary as the criteria already has the selected ids.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
---
(0076883)
vmromanos   
2015-04-29 17:56   
Working fine: JS exception is not raised anymore
(0077168)
hudsonbot   
2015-05-07 22:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077186)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test