Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0028911 | Openbravo ERP | A. Platform | public | 2015-02-10 18:33 | 2015-06-18 09:16 |
|
| Reporter | caristu | |
| Assigned To | NaroaIriarte | |
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | 3.0PR15Q3 | Fixed in Version | 3.0PR15Q3 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0028911: It is possible to create new records in edit only tabs after editing the last record in grid view |
| Description | It is possible to create new records in edit only tabs after editing the last record in grid view and press tab key |
| Steps To Reproduce | As system administrator
1) Go to the [Windows, Tabs and Fields] window and set the header of the "Unit of Measure" window as "Edit Only"
As group admin
2) Go to the [Unit of Measure] window, filter using "Liter" in the Name. Only one record will be displayed, this way we are going to edit the last record in the grid
3) Edit the record in grid view, press tab to go through all the fields. Notice that a new record is created and also it is possible to save it |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-02-10 18:33 | caristu | New Issue | |
| 2015-02-10 18:33 | caristu | Assigned To | => AugustoMauch |
| 2015-02-10 18:33 | caristu | Modules | => Core |
| 2015-02-10 18:33 | caristu | Resolution time | => 1429826400 |
| 2015-02-10 18:33 | caristu | Triggers an Emergency Pack | => No |
| 2015-02-10 18:33 | caristu | Issue Monitored: networkb | |
| 2015-02-23 08:48 | alostale | Status | new => acknowledged |
| 2015-02-23 13:30 | jonalegriaesarte | Target Version | 3.0PR15Q2 => 3.0PR15Q3 |
| 2015-03-09 17:33 | jonalegriaesarte | Resolution time | 1429826400 => |
| 2015-03-11 09:53 | alostale | Priority | high => urgent |
| 2015-03-17 14:37 | alostale | Assigned To | AugustoMauch => platform |
| 2015-06-09 09:24 | alostale | Status | acknowledged => scheduled |
| 2015-06-09 09:24 | alostale | Assigned To | platform => NaroaIriarte |
| 2015-06-12 13:26 | NaroaIriarte | Issue Monitored: alostale | |
| 2015-06-12 13:27 | NaroaIriarte | Review Assigned To | => alostale |
| 2015-06-15 18:13 | hgbot | Checkin | |
| 2015-06-15 18:13 | hgbot | Note Added: 0078300 | |
| 2015-06-15 18:13 | hgbot | Status | scheduled => resolved |
| 2015-06-15 18:13 | hgbot | Resolution | open => fixed |
| 2015-06-15 18:13 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/0df4adc6623d6a928260f2f75ef4ffbb817d5bfe [^] |
| 2015-06-16 00:37 | hudsonbot | Checkin | |
| 2015-06-16 00:37 | hudsonbot | Note Added: 0078312 | |
| 2015-06-18 09:16 | alostale | Note Added: 0078364 | |
| 2015-06-18 09:16 | alostale | Status | resolved => closed |
| 2015-06-18 09:16 | alostale | Fixed in Version | => 3.0PR15Q3 |
|
Notes |
|
|
(0078300)
|
|
hgbot
|
|
2015-06-15 18:13
|
|
Repository: erp/devel/pi
Changeset: 0df4adc6623d6a928260f2f75ef4ffbb817d5bfe
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Jun 12 13:22:31 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0df4adc6623d6a928260f2f75ef4ffbb817d5bfe [^]
fixed issue 28911: Possible to create new rows in edit only tabs in grid view
The problem was that when the UI pattern of the tab was set as "edit only", it was
possible to create new records in grid view, after editing the last record in grid view
and pressing the tab key and also by pressing the down arrow key.
The problem was in the ob-standard-view.js. There were two functions, one called
"setEditOrDeleteOnly" and another one called "setSingleRecord".
The first one, was calling another function called "setListEndEditAction" that changed
the value of "listEndEditAction" from "next" to "done" and that is the correct behaviour,
because if it is next, it allows to create a new row and in these cases we don't want it.
So, in the second function, "setSingleRecord", it was necessary to call the same function
for changing value of "listEndEditAction" from "next" to "done" for avoiding the bad behavior
of being able to create new rows.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
|
|
|
|
|
code reviewed
tested with edit only tabs as well as read only and editable |
|