Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028911Openbravo ERPA. Platformpublic2015-02-10 18:332015-06-18 09:16
Reportercaristu 
Assigned ToNaroaIriarte 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket34203
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028911: It is possible to create new records in edit only tabs after editing the last record in grid view
DescriptionIt is possible to create new records in edit only tabs after editing the last record in grid view and press tab key
Steps To ReproduceAs system administrator
1) Go to the [Windows, Tabs and Fields] window and set the header of the "Unit of Measure" window as "Edit Only"
As group admin
2) Go to the [Unit of Measure] window, filter using "Liter" in the Name. Only one record will be displayed, this way we are going to edit the last record in the grid
3) Edit the record in grid view, press tab to go through all the fields. Notice that a new record is created and also it is possible to save it
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-10 18:33caristuNew Issue
2015-02-10 18:33caristuAssigned To => AugustoMauch
2015-02-10 18:33caristuOBNetwork customer => Yes
2015-02-10 18:33caristuModules => Core
2015-02-10 18:33caristuSupport ticket => 34203
2015-02-10 18:33caristuResolution time => 1429826400
2015-02-10 18:33caristuTriggers an Emergency Pack => No
2015-02-10 18:33caristuIssue Monitored: networkb
2015-02-23 08:48alostaleStatusnew => acknowledged
2015-02-23 13:30jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-03-09 17:33jonalegriaesarteResolution time1429826400 =>
2015-03-11 09:53alostalePriorityhigh => urgent
2015-03-17 14:37alostaleAssigned ToAugustoMauch => platform
2015-06-09 09:24alostaleStatusacknowledged => scheduled
2015-06-09 09:24alostaleAssigned Toplatform => NaroaIriarte
2015-06-12 13:26NaroaIriarteIssue Monitored: alostale
2015-06-12 13:27NaroaIriarteReview Assigned To => alostale
2015-06-15 18:13hgbotCheckin
2015-06-15 18:13hgbotNote Added: 0078300
2015-06-15 18:13hgbotStatusscheduled => resolved
2015-06-15 18:13hgbotResolutionopen => fixed
2015-06-15 18:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0df4adc6623d6a928260f2f75ef4ffbb817d5bfe [^]
2015-06-16 00:37hudsonbotCheckin
2015-06-16 00:37hudsonbotNote Added: 0078312
2015-06-18 09:16alostaleNote Added: 0078364
2015-06-18 09:16alostaleStatusresolved => closed
2015-06-18 09:16alostaleFixed in Version => 3.0PR15Q3

Notes
(0078300)
hgbot   
2015-06-15 18:13   
Repository: erp/devel/pi
Changeset: 0df4adc6623d6a928260f2f75ef4ffbb817d5bfe
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Jun 12 13:22:31 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0df4adc6623d6a928260f2f75ef4ffbb817d5bfe [^]

fixed issue 28911: Possible to create new rows in edit only tabs in grid view

The problem was that when the UI pattern of the tab was set as "edit only", it was
possible to create new records in grid view, after editing the last record in grid view
and pressing the tab key and also by pressing the down arrow key.

The problem was in the ob-standard-view.js. There were two functions, one called
"setEditOrDeleteOnly" and another one called "setSingleRecord".
The first one, was calling another function called "setListEndEditAction" that changed
the value of "listEndEditAction" from "next" to "done" and that is the correct behaviour,
because if it is next, it allows to create a new row and in these cases we don't want it.
So, in the second function, "setSingleRecord", it was necessary to call the same function
for changing value of "listEndEditAction" from "next" to "done" for avoiding the bad behavior
of being able to create new rows.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0078312)
hudsonbot   
2015-06-16 00:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fa5bbdf39822 [^]
Maturity status: Test
(0078364)
alostale   
2015-06-18 09:16   
code reviewed

tested with edit only tabs as well as read only and editable