Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0028907Openbravo ERP07. Sales managementpublic2015-02-10 12:422016-04-08 11:00
ngarcia 
reinaldoguerra 
urgentmajoralways
closedfixed 
5
 
3.0PR15Q3 
aferraz
Core
Production - Confirmed Stable
2014-02-20
3.0PR14Q2
https://code.openbravo.com/erp/devel/pi/rev/0b033ca5bd1b08e81a30cfdbab2b459549d8c17c [^]
No
0028907: Cannot filter the Manage Reservation Stock pop-up of Sales Order window
Cannot filter the Manage Reservation Stock pop-up of Sales Order window
As group admin role:
   Set the Enable Stock Reservation preference to 'Y'
   Create a Sales Order with a product that has stock and book it
   Go to the line and open the Manage Reservation pop-up
   Filter by warehouse and check no records are shown
   Clean the filter and check the records are not shown
   The logs shows:
ERROR org.openbravo.client.kernel.KernelUtils - id to load is required for loading
java.lang.IllegalArgumentException: id to load is required for loading
    at org.hibernate.event.LoadEvent.<init>(LoadEvent.java:89)
    at org.hibernate.event.LoadEvent.<init>(LoadEvent.java:61)
    at org.hibernate.impl.SessionImpl.get(SessionImpl.java:1002)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:219)
    at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:202)
    at org.openbravo.dal.service.OBDal.get(OBDal.java:298)
    at org.openbravo.common.datasource.StockReservationPickAndEditDataSource.getFilteredWarehouse(StockReservationPickAndEditDataSource.java:235)
...
No tags attached.
related to defect 0027848 closed reinaldoguerra Not possible to select more than one value in fk filter drop down on Manage Stock 
depends on backport 00294483.0PR15Q1.3 closed reinaldoguerra Cannot filter the Manage Reservation Stock pop-up of Sales Order window 
caused by design defect 0023412 closed Sandrahuguet Manage Stock Pick and Execute Window does not work with large amount of data 
blocks defect 00290033.0PR15Q2 closed reinaldoguerra Error in log when typing a wrong filter in Manage Reservation Stock pop-up 
causes defect 0029458 closed aferraz More than available stock can be reserved from Sales Order screen 
Issue History
2015-02-10 12:42ngarciaNew Issue
2015-02-10 12:42ngarciaAssigned To => Sandrahuguet
2015-02-10 12:42ngarciaModules => Core
2015-02-10 12:42ngarciaResolution time => 1426114800
2015-02-10 12:42ngarciaTriggers an Emergency Pack => No
2015-02-10 12:42ngarciaRelationship addedrelated to 0027848
2015-02-10 12:43ngarciaIssue Monitored: networkb
2015-02-19 00:33reinaldoguerraAssigned ToSandrahuguet => reinaldoguerra
2015-02-19 00:33reinaldoguerraStatusnew => scheduled
2015-02-19 23:27reinaldoguerraRelationship addedblocks 0029003
2015-02-20 14:25reinaldoguerraNote Added: 0074731
2015-02-23 13:30jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-03-24 18:26aferrazRegression level => Production - Confirmed Stable
2015-03-24 18:26aferrazRegression date => 2014-02-20
2015-03-24 18:26aferrazRegression introduced in release => 3.0PR14Q2
2015-03-24 18:26aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/0b033ca5bd1b08e81a30cfdbab2b459549d8c17c [^]
2015-03-24 18:27aferrazRelationship addedcaused by 0023412
2015-03-27 08:33hgbotCheckin
2015-03-27 08:33hgbotNote Added: 0076050
2015-03-27 08:33hgbotStatusscheduled => resolved
2015-03-27 08:33hgbotResolutionopen => fixed
2015-03-27 08:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4f00f31f65e1024bf0a9e985297f8bef5746b68f [^]
2015-03-27 08:33hgbotCheckin
2015-03-27 08:33hgbotNote Added: 0076053
2015-03-27 08:35aferrazReview Assigned To => aferraz
2015-03-27 08:35aferrazNote Added: 0076055
2015-03-27 08:35aferrazStatusresolved => closed
2015-03-27 14:48aferrazStatusclosed => new
2015-03-27 14:48aferrazResolutionfixed => open
2015-03-27 14:49aferrazStatusnew => scheduled
2015-03-27 14:51aferrazStatusscheduled => resolved
2015-03-27 14:51aferrazResolutionopen => fixed
2015-03-27 14:51aferrazStatusresolved => closed
2015-03-27 15:58hudsonbotCheckin
2015-03-27 15:58hudsonbotNote Added: 0076096
2015-03-27 15:58hudsonbotCheckin
2015-03-27 15:58hudsonbotNote Added: 0076099
2015-03-31 13:28aferrazRelationship addedcauses 0029458
2015-04-22 09:46SandrahuguetNote Added: 0076674
2016-04-08 11:00hgbotCheckin
2016-04-08 11:00hgbotNote Added: 0085523

Notes
(0074731)
reinaldoguerra   
2015-02-20 14:25   
Test plan used:
1- Login into Openbravo ERP
2- As group admin role, set the Enable Stock Reservation preference to 'Y'
3- Logout and login again
4- Go to Sales Oerder window and create a header.
5- Go to lines and create a new one, select a product that has stock (for example Vino Blanco)
6- Book it
7- Go to the lines tab and open the Manage Reservation pop-up
8- Filter by warehouse and check that now the records are shown
9- Clean the filter and check the records are still shown and there are not errors in the log
(0076050)
hgbot   
2015-03-27 08:33   
Repository: erp/devel/pi
Changeset: 4f00f31f65e1024bf0a9e985297f8bef5746b68f
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Wed Mar 25 12:25:21 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/4f00f31f65e1024bf0a9e985297f8bef5746b68f [^]

Fixed bug 28907, fixed bug 27848, fixed bug 29003

The following changes was made in Stock Reservation pick and edit:
When filters are executed, a Reservation entity is created from the json parameter "@MaterialMgmtReservation.id@". This works fine when the pop-up is called from Stock Reservation window, but from Sales Order, this parameter does not exists, and the filter process fails. Now is included a code line that puts a "@MaterialMgmtReservation.id@" into the json parameters before the filters are applied.
Array critera filtering was bad created when getting grid's data, so was changed, to allow filter's multiple selection.
An hibernate exception is launched when typing wrong filters and the expression "in ()" is included in the query to be executed. So this expression was replaced by one which returns a false value: "1 = 2".
Were included also, changes to allow filtering quantity's column. Other changes were included to avoid exceptions comparing to null values.

---
M src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
---
(0076053)
hgbot   
2015-03-27 08:33   
Repository: erp/devel/pi
Changeset: 6216187116083b6bbbf99bed557231e8025de873
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Thu Mar 26 12:49:23 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/6216187116083b6bbbf99bed557231e8025de873 [^]

Related to issue 28907: Empty filter when there is no attribute set value.

When records are created in Stock Reservation pick and edit, the 0 value retrieved from default attribute set instance, defined in reservation's tables, is now set to null, when creating filter criteria.
Now if there is no attribute set defined for reservation's products, the attribute set value filter is empty.

---
M src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
---
(0076055)
aferraz   
2015-03-27 08:35   
Code review + Testing OK
(0076096)
hudsonbot   
2015-03-27 15:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e2f5d600634 [^]
Maturity status: Test
(0076099)
hudsonbot   
2015-03-27 15:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e2f5d600634 [^]
Maturity status: Test
(0076674)
Sandrahuguet   
2015-04-22 09:46   
Test added in testlink
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8203 [^]
(0085523)
hgbot   
2016-04-08 11:00   
Repository: tools/automation/int
Changeset: 777758126bdbe2cf3cc1a64d0f98ffc75330734c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Feb 26 08:46:30 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/777758126bdbe2cf3cc1a64d0f98ffc75330734c [^]

Related to issue 28907 & Related to issue 27848 & Related to issue 29003: Add an automated test

---
M src-test/com/openbravo/test/integration/erp/data/sales/transactions/salesorder/ManageReservationData.java
M src-test/com/openbravo/test/integration/erp/gui/sales/transactions/salesorder/LinesTab.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/pickandexecute/PickAndExecuteWindow.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RES_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/testscripts/sales/transactions/SalesOrder.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RESRegression28907R27848R29003.java
---