Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028900Retail ModulesWeb POSpublic2015-02-09 19:452015-03-27 14:33
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028900: 'calculategross()' functions do not reset unnecessary 'net' and 'gross' fields
Description'calculategross()' functions do not reset unnecessary 'net' and 'gross' values
Steps To ReproduceIn 'order.js' verify that there are 2 'calculategross()' methods
Verify that the methods do not reset unnecessary 'net' or/and 'gross' fields
Also verify that the 'calculatetaxes()' method is modifying the receipt 'net' value which never should
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028594 closed marvintm Using price lists not including taxes, the line net amount of lines with discounts shows the net amount without the discount 
blocks feature request 0028901 closed Orekaria Log: add error log entries when the receipt values are inconsistent 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-09 19:45OrekariaNew Issue
2015-02-09 19:45OrekariaAssigned To => Orekaria
2015-02-09 19:45OrekariaTriggers an Emergency Pack => No
2015-02-09 19:47OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7645#r7645
2015-02-10 09:28OrekariaRelationship addedblocks 0028901
2015-02-10 14:53OrekariaRelationship addedrelated to 0028594
2015-02-11 22:01hgbotCheckin
2015-02-11 22:01hgbotNote Added: 0074360
2015-02-11 22:01hgbotStatusnew => resolved
2015-02-11 22:01hgbotResolutionopen => fixed
2015-02-11 22:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bd0fa2e4e84813d06b201ac63f0fcfd242615a5e [^]
2015-02-19 16:47OrekariaNote Added: 0074675
2015-02-19 16:47OrekariaStatusresolved => new
2015-02-19 16:47OrekariaResolutionfixed => open
2015-03-25 10:10hgbotCheckin
2015-03-25 10:10hgbotNote Added: 0075962
2015-03-25 10:10hgbotStatusnew => resolved
2015-03-25 10:10hgbotResolutionopen => fixed
2015-03-25 10:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bd0fa2e4e84813d06b201ac63f0fcfd242615a5e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9a8fe95e45f7339a6a6506f935c671154d58fa28 [^]
2015-03-27 14:33marvintmReview Assigned To => marvintm
2015-03-27 14:33marvintmStatusresolved => closed
2015-03-27 14:33marvintmFixed in Version => RR15Q2

Notes
(0074360)
hgbot   
2015-02-11 22:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bd0fa2e4e84813d06b201ac63f0fcfd242615a5e
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Feb 11 22:00:32 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bd0fa2e4e84813d06b201ac63f0fcfd242615a5e [^]

Fixes issue 28900: 'calculategross' methods reset 'net', 'gross' and 'taxes' fields when required
- 'net' is no longer modified by the 'calculatetaxes()' method
- 'qty' is set when 'calculateTaxes' has finished

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0074675)
Orekaria   
2015-02-19 16:47   
'silent' could not be working as expected. recheck
(0075962)
hgbot   
2015-03-25 10:10   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9a8fe95e45f7339a6a6506f935c671154d58fa28
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Mar 25 10:09:17 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9a8fe95e45f7339a6a6506f935c671154d58fa28 [^]

Fixes issue 28900: Refactor to set in batch, the 'calculateGross' involved attributes

- the 'qty' is also reset at the start of the calculations

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---