Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028876Openbravo ERPA. Platformpublic2015-02-05 17:242015-02-09 12:27
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toinigosanchez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028876: OBBaseTest rolls back all test executions
DescriptionAfter executing any OBBaseTest junit test case, rollback is performed on DAL session.

The expected behavior is to commit in case of success and rollback only in case of failure. In this way it is possible to make tests dependent on other ones.
Steps To ReproduceSee attached test cases, it fails because 2nd test case expects objects created in 1st one are still present.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0027290 closed inigosanchez Upgrade all test cases of JUnit (Version 4.11) 
Attached Files? TestInfrastructure.java (3,096) 2015-02-05 17:25
https://issues.openbravo.com/file_download.php?file_id=7773&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-02-05 17:24alostaleNew Issue
2015-02-05 17:24alostaleAssigned To => alostale
2015-02-05 17:24alostaleModules => Core
2015-02-05 17:24alostaleTriggers an Emergency Pack => No
2015-02-05 17:25alostaleFile Added: TestInfrastructure.java
2015-02-05 17:26alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7633#r7633
2015-02-06 08:22alostaleRelationship addedrelated to 0027290
2015-02-06 08:23alostaleReview Assigned To => inigosanchez
2015-02-06 08:55hgbotCheckin
2015-02-06 08:55hgbotNote Added: 0074236
2015-02-06 08:55hgbotStatusnew => resolved
2015-02-06 08:55hgbotResolutionopen => fixed
2015-02-06 08:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bdf1796ee0120d1796e48d13cdcc78be894c790c [^]
2015-02-06 08:55hgbotCheckin
2015-02-06 08:55hgbotNote Added: 0074237
2015-02-06 08:55hgbotCheckin
2015-02-06 08:55hgbotNote Added: 0074239
2015-02-06 15:42hudsonbotCheckin
2015-02-06 15:42hudsonbotNote Added: 0074260
2015-02-06 15:42hudsonbotCheckin
2015-02-06 15:42hudsonbotNote Added: 0074261
2015-02-09 12:27inigosanchezNote Added: 0074280
2015-02-09 12:27inigosanchezStatusresolved => closed

Notes
(0074236)
hgbot   
2015-02-06 08:55   
Repository: erp/devel/pi
Changeset: bdf1796ee0120d1796e48d13cdcc78be894c790c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 05 17:30:09 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bdf1796ee0120d1796e48d13cdcc78be894c790c [^]

fixed bug 28876: OBBaseTest rolls back all test executions

  Added a test watcher to determine wether the test failed or succeeded and do
  the commit/rollback based on that.

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
---
(0074237)
hgbot   
2015-02-06 08:55   
Repository: erp/devel/pi
Changeset: 0c0527b41e73d687595d89be4e2e08afbb165b5b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 05 17:30:40 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c0527b41e73d687595d89be4e2e08afbb165b5b [^]

related to bug 28876: added test case

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src-test/src/org/openbravo/test/AllQuickAntTaskTests.java
M src-test/src/org/openbravo/test/AntTaskTests.java
A src-test/src/org/openbravo/test/system/TestInfrastructure.java
---
(0074239)
hgbot   
2015-02-06 08:55   
Repository: erp/devel/api-checks
Changeset: 8dbaaba6e596729afabf26660026f81e335126c9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 06 08:54:24 2015 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/8dbaaba6e596729afabf26660026f81e335126c9 [^]

related to bug 28876: fixed false api change positive

  Changes in ClassicSelectorTest were detected, this is a false positive because
  test package is excluded from api checks, though this class contains test cases,
  it is not excluded because it is not in org.openbravo.test package.

---
M java/reference/java.japi.gz
---
(0074260)
hudsonbot   
2015-02-06 15:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/354f8004acc8 [^]
Maturity status: Test
(0074261)
hudsonbot   
2015-02-06 15:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/354f8004acc8 [^]
Maturity status: Test
(0074280)
inigosanchez   
2015-02-09 12:27   
Code reviewed and verified in pi@5461e9cb19dd