Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028873Retail ModulesWeb POSpublic2015-02-05 13:202015-04-13 13:07
Reporterjecharri 
Assigned Tomigueldejuana 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q2Fixed in VersionRR15Q2 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028873: Cash up is not working properly and success message can take minutes
DescriptionCash up is not working properly and success message can take minutes. The problem is that we are not showing success message until the process finished executing in the ERP.

The solution should be to work online as we do in offline:
-do the cash up
-show the success message
-in parallel execute the runSyncProcess
Steps To Reproduce-Go to Web POS
-Do a cash up

Verify that the cash up will take more time if you are online than offline
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028215RR15Q1 closed migueldejuana Logout when data is not synchronized shows javascript errors 
depends on backport 0029569RR15Q1.3 closed migueldejuana Cash up is not working properly and success message can take minutes 
Attached Filesdiff issue28873posterminal.diff (1,562) 2015-02-12 09:03
https://issues.openbravo.com/file_download.php?file_id=7785&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-02-05 13:20jecharriNew Issue
2015-02-05 13:20jecharriAssigned To => marvintm
2015-02-05 13:20jecharriResolution time => 1423350000
2015-02-05 13:20jecharriTriggers an Emergency Pack => No
2015-02-05 13:23jecharriDescription Updatedbug_revision_view_page.php?rev_id=7629#r7629
2015-02-12 08:43migueldejuanaRelationship addedrelated to 0028215
2015-02-12 08:45migueldejuanaNote Added: 0074363
2015-02-12 09:03migueldejuanaFile Added: issue28873posterminal.diff
2015-02-12 09:04migueldejuanaNote Added: 0074366
2015-02-12 09:07hgbotCheckin
2015-02-12 09:07hgbotNote Added: 0074367
2015-02-12 09:07hgbotStatusnew => resolved
2015-02-12 09:07hgbotResolutionopen => fixed
2015-02-12 09:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3f936397a692ea269e2be88ec651f25ef43a9c0b [^]
2015-02-12 09:08hgbotCheckin
2015-02-12 09:08hgbotNote Added: 0074368
2015-02-12 09:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3f936397a692ea269e2be88ec651f25ef43a9c0b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3407752f5c66a6af3d30316d8939b652f9a81ffd [^]
2015-02-12 12:40migueldejuanaAssigned Tomarvintm => migueldejuana
2015-02-13 11:43OrekariaReview Assigned To => Orekaria
2015-02-13 11:43OrekariaNote Added: 0074448
2015-02-13 11:43OrekariaStatusresolved => closed
2015-02-13 11:43OrekariaFixed in Version => RR15Q2
2015-04-13 12:05marvintmStatusclosed => new
2015-04-13 12:05marvintmResolutionfixed => open
2015-04-13 12:05marvintmFixed in VersionRR15Q2 =>
2015-04-13 12:05marvintmStatusnew => scheduled
2015-04-13 12:05marvintmStatusscheduled => resolved
2015-04-13 12:05marvintmResolutionopen => fixed
2015-04-13 12:06marvintmStatusresolved => new
2015-04-13 12:06marvintmResolutionfixed => open
2015-04-13 12:06marvintmStatusnew => scheduled
2015-04-13 12:06marvintmStatusscheduled => resolved
2015-04-13 12:06marvintmFixed in Version => RR15Q2
2015-04-13 12:06marvintmResolutionopen => fixed
2015-04-13 12:06marvintmStatusresolved => closed
2015-04-13 12:35hgbotCheckin
2015-04-13 12:35hgbotNote Added: 0076474
2015-04-13 12:35hgbotStatusclosed => resolved
2015-04-13 12:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3407752f5c66a6af3d30316d8939b652f9a81ffd [^] => http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.mobile.core/rev/daf76cf73c8f2af7f944f7b41dae012dc4e47e6c [^]
2015-04-13 12:35hgbotCheckin
2015-04-13 12:35hgbotNote Added: 0076476
2015-04-13 12:35hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.mobile.core/rev/daf76cf73c8f2af7f944f7b41dae012dc4e47e6c [^] => http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.retail.posterminal/rev/de1acb7a164df1941cd9fbd7ef5261cb45562d5e [^]
2015-04-13 13:07OrekariaStatusresolved => closed

Notes
(0074363)
migueldejuana   
2015-02-12 08:45   
If we have sessions module installed, after doing the cashup we logout and it could give an error because ProcessCashClose is running but it doesn't affect to the flow. We should avoid showing this message avoiding doing logout while data is synchronizing (https://issues.openbravo.com/view.php?id=28215 [^])
(0074366)
migueldejuana   
2015-02-12 09:04   
I have attached a patch for Q3.5 --> issue28873posterminal.diff
(0074367)
hgbot   
2015-02-12 09:07   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3f936397a692ea269e2be88ec651f25ef43a9c0b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Feb 12 09:06:38 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3f936397a692ea269e2be88ec651f25ef43a9c0b [^]

Fixed issue 0028873: Cash up is not working properly and success message can take minutes

If objToSend is null, we must not send it to backend

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0074368)
hgbot   
2015-02-12 09:08   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3407752f5c66a6af3d30316d8939b652f9a81ffd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Feb 12 09:05:44 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3407752f5c66a6af3d30316d8939b652f9a81ffd [^]

Fixed issue 0028873: Cash up is not working properly and success message can take minutes

We need to skip retrieving cashup from backend because we are processing the cashup and it is not processed yet.

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0074448)
Orekaria   
2015-02-13 11:43   
Working on Retail
(0076474)
hgbot   
2015-04-13 12:35   
Repository: retail/backports/3.0RR15Q1.3/org.openbravo.mobile.core
Changeset: daf76cf73c8f2af7f944f7b41dae012dc4e47e6c
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Feb 12 09:06:38 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.mobile.core/rev/daf76cf73c8f2af7f944f7b41dae012dc4e47e6c [^]

Fixed issue 0028873, fixes issue 29569: Cash up is not working properly and success message can take minutes

If objToSend is null, we must not send it to backend

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0076476)
hgbot   
2015-04-13 12:35   
Repository: retail/backports/3.0RR15Q1.3/org.openbravo.retail.posterminal
Changeset: de1acb7a164df1941cd9fbd7ef5261cb45562d5e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Feb 12 09:05:44 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.retail.posterminal/rev/de1acb7a164df1941cd9fbd7ef5261cb45562d5e [^]

Fixed issue 0028873, fixes issue 29569: Cash up is not working properly and success message can take minutes

We need to skip retrieving cashup from backend because we are processing the cashup and it is not processed yet.

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---