Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028850Openbravo ERP04. Warehouse managementpublic2015-02-03 16:322015-05-08 15:39
ReporterVictorVillar 
Assigned Tovmromanos 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket33929
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028850: It should not be possible to add non stocked products to a physical inventory
DescriptionIt should not be possible to add non stocked products to a physical inventory
Steps To ReproduceAs group admin role,
 Go to Product window,
   Create a new one.
       Item
       Stocked: No
       Purchase: Yes
       Sales: Yes
Go to Physical inventory window,
  Create a new register
  Add the Product created before (removing the filter)
  Realise that a non stocked product should not appear in that selector at all.
 
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0029992 closed vmromanos Cannot add stocked products with no stock in physical inventory lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-03 16:32VictorVillarNew Issue
2015-02-03 16:32VictorVillarAssigned To => Sandrahuguet
2015-02-03 16:32VictorVillarOBNetwork customer => Yes
2015-02-03 16:32VictorVillarModules => Core
2015-02-03 16:32VictorVillarSupport ticket => 33929
2015-02-03 16:32VictorVillarResolution time => 1428962400
2015-02-03 16:32VictorVillarTriggers an Emergency Pack => No
2015-02-03 16:32VictorVillarIssue Monitored: networkb
2015-03-06 11:22jorge-garciaStatusnew => scheduled
2015-03-06 11:22jorge-garciaAssigned ToSandrahuguet => jorge-garcia
2015-05-06 13:50vmromanosAssigned Tojorge-garcia => vmromanos
2015-05-06 18:18vmromanosNote Added: 0077064
2015-05-07 17:46hgbotCheckin
2015-05-07 17:46hgbotNote Added: 0077102
2015-05-07 17:46hgbotStatusscheduled => resolved
2015-05-07 17:46hgbotResolutionopen => fixed
2015-05-07 17:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5772533f5768eba602eabec0bcc87e86c513f25d [^]
2015-05-07 17:48SandrahuguetReview Assigned To => Sandrahuguet
2015-05-07 17:48SandrahuguetNote Added: 0077103
2015-05-07 17:48SandrahuguetStatusresolved => closed
2015-05-07 17:48SandrahuguetFixed in Version => 3.0PR15Q3
2015-05-08 08:58hgbotCheckin
2015-05-08 08:58hgbotNote Added: 0077221
2015-05-08 15:39hudsonbotCheckin
2015-05-08 15:39hudsonbotNote Added: 0077250
2015-05-08 15:39hudsonbotCheckin
2015-05-08 15:39hudsonbotNote Added: 0077251
2015-05-25 10:45ngarciaRelationship addedcauses 0029992

Notes
(0077064)
vmromanos   
2015-05-06 18:18   
Test plan I:
1. Go to Physical Inventory window. Create a new record
2. Go to lines tab. Create a new record
3. Open the product selector. Verify only products with stocked = Y are shown
4. Verify you can neither filter nor sort by the Stocked column
(0077102)
hgbot   
2015-05-07 17:46   
Repository: erp/devel/pi
Changeset: 5772533f5768eba602eabec0bcc87e86c513f25d
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed May 06 18:13:21 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5772533f5768eba602eabec0bcc87e86c513f25d [^]

Fixed bug 28850: Stocked products in Physical Inventory

The product selector at Physical Inventory | Lines tab displayed by default stocked products. However you could also remove the filter and select non stocked products too, which has no sense.

A new reference called "Product Complete (Stocked only)" has been created from the original "Product Complete" reference inside this window. The filter clause has been removed and the where clause includes only active stocked products.
Finally the Stock column in the selector has been set as not filterable/sortable to avoid confusions while displaying the grid view.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_SEARCH.xml
M src-db/database/sourcedata/AD_REF_SEARCH_COLUMN.xml
M src-db/database/sourcedata/OBCLKER_UIDEFINITION.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
---
(0077103)
Sandrahuguet   
2015-05-07 17:48   
Code review + testing OK
(0077221)
hgbot   
2015-05-08 08:58   
Repository: erp/devel/pi
Changeset: b43663f4c0aeec20a88cf3a8b3573af04c37a6df
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri May 08 08:57:44 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b43663f4c0aeec20a88cf3a8b3573af04c37a6df [^]

Related to issue 28850: fixed ad_model_object classname

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0077250)
hudsonbot   
2015-05-08 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d5cb256a6a8a [^]
Maturity status: Test
(0077251)
hudsonbot   
2015-05-08 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d5cb256a6a8a [^]
Maturity status: Test