Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002883Openbravo ERPB. User interfacepublic2008-04-16 16:432008-07-02 10:31
Reporterplujan 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.40Fixed in Version2.40beta 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0002883: QA-KBS "Browse..." button do not respond to Enter key
DescriptionSummary:
If the window has a default OK button, but also a <FILE> tag, when the <FILE> tag get focus, on R2.35 I could press Enter key to open dialog popup. Now, even focused, the OK button is pressed.
This only applies to Firefox 2. Tested on WindowsXP.

Steps:
1. Login as Openbravo
2. Go General Setup > Client > Initial Client Setup
3. Use Tab key to navigate to "Accounting file" field. The "Browse..." button gets focus. The OK button remains with default focus.
4. Press Enter key. The application reacts as if OK button was clicked.
5. Repeat steps on 2.35. The application reacts opening File selector popup
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-06-13 19:01cromeroStatusnew => scheduled
2008-06-13 19:58cromeroTarget Version => 2.40
2008-06-15 23:31dbazNote Added: 0007721
2008-06-15 23:41svnbotCheckin
2008-06-15 23:41svnbotNote Added: 0007722
2008-06-15 23:41svnbotStatusscheduled => resolved
2008-06-15 23:41svnbotResolutionopen => fixed
2008-06-15 23:41svnbotsvn_revision => 5056
2008-07-02 10:31plujanStatusresolved => closed
2008-07-02 10:31plujanNote Added: 0008122
2008-07-02 10:31plujanFixed in Version2.40 => 2.40beta

Notes
(0006472)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1944042 [^]
(0007721)
dbaz   
2008-06-15 23:31   
There is no good solution since the "Browse" key is implemented by the browser, and the user can't have control of it because security reasons.

The solution implementation will be to create a dummy input file before and after the input type file, and when this input is selected, the openbravo keyboard shortcuts will be disabled and the browser will take control of the shortcuts. Then when the input type file gets the focus, the openbravo keyboard shortcuts will be enabled again.

So when you press tab to go to the input type file, just one tab before "Browse" key gets focus, the focus will dissapear and one tab after "Browse" key lost focus, the focus will dissapear again (until you press tab key one more time)

This is the better solution and there is not any workaround.
(0007722)
svnbot   
2008-06-15 23:41   
Repository: openbravo
Revision: 5056
Author: dbaz
Date: 2008-06-15 23:41:51 +0200 (Sun, 15 Jun 2008)

Fixed bug 0002883 Partial fix of focus in browse key

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/Test_In.html
U trunk/src/org/openbravo/erpCommon/ad_forms/EdiFileImport.html
U trunk/src/org/openbravo/erpCommon/ad_forms/FileImport.html
U trunk/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.html
U trunk/src/org/openbravo/erpCommon/businessUtility/TabAttachments_Edition.html
U trunk/web/js/utils.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=5056&sc=1 [^]
(0008122)
plujan   
2008-07-02 10:31   
Collateral bugs will be reported on separated defects