0028822: update.database.script is not reliable - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0028822

Openbravo ERP

Y. DBSourceManager

public

2015-01-30 12:59

2022-02-01 08:09

Reporter

alostale

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

AugustoMauch

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0028822: update.database.script is not reliable

Description

update.database.script task logs a file with the sql statements that actual update.database would execute.

The problem is that it logs some commands that actual update.database will not execute. Example: actual update.database drops FKs only for those tables to be recreated and for the ones defined in the AD dataset whereas update.database.script logs statements to drop *all* FKs.

Though the script is still useful to understand the main actions done by update.database it is not reliable.

Steps To Reproduce

-execute ant update.datbase to syn DB with xml
-execute ant update.databse.script -Dbbdd.outputscript=/tmp/update.sql
--> check all FK constrains are dropped and recreated
-set pg log to log all the statements in DB
-execute ant update.datbase
--> check not all the FKs appearing in the script are actually dropped and recreated

Proposed Solution

Currently update.database.script duplicates actual update.database methods reimplementing them, this makes more difficult to maintain code because any change in update.database should be also ported to update.datbase.

These methods should be refactored to be maintained in a single place.

Additional Information