Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028790ModulesSEPA Credit Transfer Customer-to-Bankpublic2015-01-27 18:542015-03-13 15:15
Reportermaite 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket26533
OBNetwork customerOBPS
Regression introduced in release
Summary0028790: Character º is not properly exported to XML file
DescriptionCharacter º is not properly exported to XML file
Steps To Reproduce1. Register SEPA Credit Transfer remittance document. Add any line and process
2. Access Bank Instructions tab and edit "Description" field to set "aaaaaaaaaaaaaºaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
3. Run "Create Remittance" file process and realize that character º has been exported as ??, which is not correct

Moreover, this is causing that <Ustrd> tag is not 140 characters length but 141

NOTE: same problem for Direct Debit format
Proposed SolutionCharacter º must be exported to XML file as a .
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-27 18:54maiteNew Issue
2015-01-27 18:54maiteAssigned To => vmromanos
2015-01-27 18:54maiteSupport ticket => 26533
2015-01-27 18:54maiteOBNetwork customer => Yes
2015-01-27 18:56maiteResolution time => 1424386800
2015-01-27 18:56maiteIssue Monitored: networkb
2015-02-11 22:15reinaldoguerraAssigned Tovmromanos => reinaldoguerra
2015-02-11 22:15reinaldoguerraStatusnew => scheduled
2015-02-12 00:14reinaldoguerraNote Added: 0074362
2015-03-05 13:50hgbotCheckin
2015-03-05 13:50hgbotNote Added: 0075192
2015-03-05 13:52hgbotCheckin
2015-03-05 13:52hgbotNote Added: 0075193
2015-03-05 13:52hgbotStatusscheduled => resolved
2015-03-05 13:52hgbotResolutionopen => fixed
2015-03-05 13:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022/rev/113c942bee43e7ee1de6c39f9755fae183afe763 [^]
2015-03-05 13:54hgbotCheckin
2015-03-05 13:54hgbotNote Added: 0075194
2015-03-05 13:54umartirenaAssigned Toreinaldoguerra => umartirena
2015-03-13 13:01psanjuanNote Added: 0075549
2015-03-13 13:01psanjuanStatusresolved => closed
2015-03-13 13:01psanjuanProposed Solution updated
2015-03-13 15:15umartirenaNote Added: 0075570
2015-03-13 15:16umartirenaNote Edited: 0075570bug_revision_view_page.php?bugnote_id=0075570#r7959

Notes
(0074362)
reinaldoguerra   
2015-02-12 00:14   
Test plan used:
1- Login into Openbravo ERP
2- As system administrator go to module management window and install SEPA Credit Transfer Customer-to-Bank module.
3- Rebuild the system
4- Login into Openbravo ERP again
5- Go to Enterprise Module Management window and install Remittance and SEPA Credit Transfer Customer-to-Bank reference data
6- Go to Financial Account window and select record "Cuenta de Banco" for organization España S.A
7- Select Country: Spain, set ES9121000418450200051332 as IBAN code and DSGLESBB as SWIFT Code
8- Go to Payment Method tab and create a new record selecting "SEPA Credit Transfer Customer-to-Bank" as payment method
9- Go to Remittance window and create a new record, select "SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)" as Remittance Type. Check that "Cuenta de Banco - EUR" is selected as Financial Account. Introduce a name
10- Click on "Select Orders or Invoices" button.
11- Mark "Show payments for alternative payment methods" ckeckbox if its necesary.
12- Select one record from the grid and complete the process, check that a line is created in lines tab.
13- Process the remittance
14- Go to Bank Instructions tab, a new record should be created. Go to its business partner window, and then to the Bank Account tab
15- Select Country: Spain, set ES9121000418450200051332 as IBAN code and DSGLESBB as SWIFT Code
16- Go back to created remittance
17- Access Bank Instructions tab and edit "Description" field to set aaaaaaaaaaaaaºaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
18- Run "Create Remittance" file process and realize that character º is now exported successfuly.
(0075192)
hgbot   
2015-03-05 13:50   
Repository: erp/pmods/org.openbravo.sepa.iso20022.coredirectdebit.customertobank
Changeset: 1b9d28cfc37462931f8426ed5b80faae77144fa2
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Mar 05 13:44:16 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.coredirectdebit.customertobank/rev/1b9d28cfc37462931f8426ed5b80faae77144fa2 [^]

Related to bug 28790: Character º is now properly exported to XML file.

Description of Bank Instruction now is properly parsed before exporting to XML file, using method parseText fixed in the same issue in 'org.openbravo.sepa.iso20022' module.

---
M src/org/openbravo/sepa/iso20022/coredirectdebit/customertobank/pain/x008/x001/x02/report/CoreDirectDebit.java
M src/org/openbravo/sepa/iso20022/coredirectdebit/customertobank/pain/x008/x001/x03/report/CoreDirectDebit.java
---
(0075193)
hgbot   
2015-03-05 13:52   
Repository: erp/pmods/org.openbravo.sepa.iso20022
Changeset: 113c942bee43e7ee1de6c39f9755fae183afe763
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Mar 05 13:29:04 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022/rev/113c942bee43e7ee1de6c39f9755fae183afe763 [^]

Fixes bug 28790: Character º is now properly exported to XML file.

There are currently two methods that are used to parse the strings that are exported to the sepa XML, 'parseText' and 'replaceStrangeCharacters', that there were using in different places. All the functionality has been added in 'replaceStrangeCharacters' and this is called from 'parseText', in order to have everything centralized on a single method.

Regarding to º and ª symbols, there have been replaced by . character, looking at what is specified in 'SEPA Requirements for an Extended Character Set (UNICODE Subset) - Best Practices'. Please see the following link: http://www.europeanpaymentscouncil.eu/index.cfm/knowledge-bank/epc-documents/sepa-requirements-for-an-extended-character-set-unicode-subset-best-practices/ [^]

---
M src/org/openbravo/sepa/iso20022/util/SEPAUtil.java
M src/org/openbravo/sepa/iso20022/util/SEPA_RemittanceCreateFile.java
---
(0075194)
hgbot   
2015-03-05 13:54   
Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: a1fd1d5240c0a5d202d6b73277c0d70f6739dbc3
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Thu Mar 05 13:41:06 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/a1fd1d5240c0a5d202d6b73277c0d70f6739dbc3 [^]

Related to bug 28790: Character º is now properly exported to XML file.

Description of Bank Instruction now is properly parsed before exporting to XML file, using method parseText fixed in the same issue in 'org.openbravo.sepa.iso20022' module.

---
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x03/report/CreditTransfer.java
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x04/report/CreditTransfer.java
---
(0075549)
psanjuan   
2015-03-13 13:01   
Verified.

Characters º and ª are now exported to the XML file as a .
(0075570)
umartirena   
2015-03-13 15:15   
(edited on: 2015-03-13 15:16)
Repository: erp/pmods/org.openbravo.sepa.iso20022
Changeset: b4244783b03616e99047bfb0c4b4a8be5f57048d
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Mar 10 08:50:31 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022/rev/b4244783b03616e99047bfb0c4b4a8be5f57048d [^] [^]

Related to bug 28970: Fixes on replaceStrangeCharacters method.

Remove unnecessary replacements & change replaceAll to replace to leave as it was in parseText function.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/sepa/iso20022/util/SEPAUtil.java