Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028714Retail ModulesWeb POSpublic2015-01-21 12:552015-01-29 10:33
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression levelAutomated tests
Regression date
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fb8958661e2e4d21c9cee79de5c601a710f12ecb [^]
Triggers an Emergency PackNo
Summary0028714: Verified returns incorrectly update the cash balance
DescriptionVerified returns incorrectly update the cash balance
Steps To Reproduce1) complete a cash up process, without keeping any cash.
2) create and pay with cash a receipt with a Baby Carrier (110.50€)
3) using verified returns, return the created receipt paying with cash (-110.50€)
4) create a return receipt with "return this receipt" option. add a product that is less than 221€ (110.50€ * 2) and try to pay through cash payment method. do not finish it

INCORRECT: payment is allowed

5) add products to the receipt so the amount is more than 221€

CORRECT: payment is not allowed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028448 closed malsasua [RR14Q3.3] Check enough cash does not work when cash in the counter is zero 
caused by defect 0028491RR15Q1 closed marvintm Cash up report is not showing the correct numbers in withdrawal section 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-21 12:55OrekariaNew Issue
2015-01-21 12:55OrekariaAssigned To => marvintm
2015-01-21 12:55OrekariaTriggers an Emergency Pack => No
2015-01-21 12:57OrekariaRelationship addedrelated to 0028448
2015-01-21 15:21OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7507#r7507
2015-01-21 23:56hgbotCheckin
2015-01-21 23:56hgbotNote Added: 0073705
2015-01-22 12:23OrekariaRegression level => Automated tests
2015-01-22 12:29OrekariaRegression introduced in release => pi
2015-01-22 16:22OrekariaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fb8958661e2e4d21c9cee79de5c601a710f12ecb [^]
2015-01-22 16:22OrekariaRelationship addedcaused by 0028491
2015-01-22 18:34hgbotCheckin
2015-01-22 18:34hgbotNote Added: 0073735
2015-01-22 18:34hgbotStatusnew => resolved
2015-01-22 18:34hgbotResolutionopen => fixed
2015-01-22 18:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcc4856b6e9902dcabe3396aad449580a32b878a [^]
2015-01-22 18:46OrekariaAssigned Tomarvintm => Orekaria
2015-01-22 19:25hgbotCheckin
2015-01-22 19:25hgbotNote Added: 0073742
2015-01-23 10:05hgbotCheckin
2015-01-23 10:05hgbotNote Added: 0073744
2015-01-23 10:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcc4856b6e9902dcabe3396aad449580a32b878a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/59a54e50a2a7eb55d6d0847260131d78fd3bc951 [^]
2015-01-23 12:32hgbotCheckin
2015-01-23 12:32hgbotNote Added: 0073750
2015-01-23 12:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/59a54e50a2a7eb55d6d0847260131d78fd3bc951 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef31aa0d46ce01108120b6ab62f2a57d4251758c [^]
2015-01-29 10:33migueldejuanaReview Assigned To => migueldejuana
2015-01-29 10:33migueldejuanaNote Added: 0073884
2015-01-29 10:33migueldejuanaStatusresolved => closed

Notes
(0073705)
hgbot   
2015-01-21 23:56   
Repository: tools/automation/pi-mobile
Changeset: 12bdcc45d9ac4fb3e5f1564e3ede33706d32acf5
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Jan 21 14:33:15 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/12bdcc45d9ac4fb3e5f1564e3ede33706d32acf5 [^]

Related to issue 28448 and issue 28714: Added 2 tests to verify that the 'No cash available' warning

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/ReceiptSuite.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I28448_NoCashAvailable.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I28714_NoCashAvailableII.java
---
(0073735)
hgbot   
2015-01-22 18:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bcc4856b6e9902dcabe3396aad449580a32b878a
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Jan 22 17:09:16 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcc4856b6e9902dcabe3396aad449580a32b878a [^]

Fixes issue 28714: The amount to be returned is substracted instead of added

The problem was that the fix for the issue 28491 inverted the sign of the return variable

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0073742)
hgbot   
2015-01-22 19:25   
Repository: tools/automation/pi-mobile
Changeset: 044ddd83025165a7ccc6f30356034863ac6b02cb
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Jan 22 18:35:47 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/044ddd83025165a7ccc6f30356034863ac6b02cb [^]

Related to issue 28448 and issue 28714: Activated related tests and added 2 tests more

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/CashupSuite.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/SalesSuite.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/deactivated/TestsAwaitingFixesSuite.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28714_VerifyTotalReturns.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28714_VerifyTotalReturnsII.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I28714_NoCashAvailableWithCashupCheck.java
---
(0073744)
hgbot   
2015-01-23 10:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 59a54e50a2a7eb55d6d0847260131d78fd3bc951
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Jan 23 10:04:51 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/59a54e50a2a7eb55d6d0847260131d78fd3bc951 [^]

Fixes issue 28714: The amount to be returned is substracted instead of added (II)

An abs conversion has been removed to prevent unexpected and hidden errors

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---
(0073750)
hgbot   
2015-01-23 12:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ef31aa0d46ce01108120b6ab62f2a57d4251758c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Jan 23 12:31:54 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef31aa0d46ce01108120b6ab62f2a57d4251758c [^]

Fixes issue 28714: The add minus operation has been replaced with a sub operation

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0073884)
migueldejuana   
2015-01-29 10:33   
Tested and reviewed in d01540894fad