Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0028703 | Openbravo ERP | Z. Others | public | 2015-01-20 19:02 | 2021-06-11 10:18 |
|
Reporter | shuehner | |
Assigned To | shuehner | |
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | PR21Q3 | Fixed in Version | PR21Q3 | |
Merge Request Status | |
Review Assigned To | |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0028703: dbmanager.jar & src-db/src removal |
Description | The src-db/src folder does contain 4 java files which are generally not used for a very long time.
In the past they have been used to define dataset & excludeFilters (now covered via excludefilter.xml).
Additionally that folder src-db does contain its own eclipse project which is not needed to be imported ever, but when letting eclipse search for .project files in a pi clone it will detect it always and one needs to manually exclude it from the import.
However at least 1 openbravo module (ezattributes) does reference one of those 4 java files.
A quick grep of all modules published in butler (status qaa) shows no other reference to those 4 classes.
Options:
a.) Just delete + check and deal properly with that ezattributes module
b.) Create once a dbmanager.jar file containing both the 4 java files + the 4 .class files + mark the java files as deprecated) and add that to pi in src-db/database/lib
c.) as b.) but not as dbmanager.jar in pi but just as 4 more files in dbsm-main repo and added via dbsourcemanager.jar to pi |
Steps To Reproduce | - |
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | depends on | feature request | 0047036 | PR21Q3 | closed | shuehner | Remove lots of obsolete support code for obsolete (update.database.mod, ezattributes module, dbmanager.jar references) | has duplicate | design defect | 0014555 | | closed | marvintm | Cleanup: remove src-db/src classes, as they are no longer useful | related to | feature request | 0030426 | | closed | shuehner | Strip down deprecated database.lib aka dbmanager.jar to bare minimum needed | blocks | design defect | 0032688 | | acknowledged | Triage Platform Base | remove unused resources | blocks | design defect | 0038296 | | acknowledged | Triage Platform Base | Review & cleanup build.xml |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2015-01-20 19:02 | shuehner | New Issue | |
2015-01-20 19:02 | shuehner | Assigned To | => shuehner |
2015-01-20 19:02 | shuehner | Modules | => Core |
2015-01-20 19:02 | shuehner | Triggers an Emergency Pack | => No |
2015-08-06 08:06 | alostale | Relationship added | related to 0030426 |
2016-04-19 13:38 | shuehner | Relationship added | blocks 0032688 |
2018-04-08 17:00 | shuehner | Relationship added | blocks 0038296 |
2021-06-09 11:38 | shuehner | Relationship added | depends on 0047036 |
2021-06-09 14:28 | hgbot | Note Added: 0129266 | |
2021-06-09 15:10 | hgbot | Note Added: 0129268 | |
2021-06-09 20:02 | shuehner | Target Version | => PR21Q3 |
2021-06-10 13:33 | hgbot | Note Added: 0129339 | |
2021-06-10 13:33 | hgbot | Note Added: 0129340 | |
2021-06-10 13:33 | hgbot | Note Added: 0129341 | |
2021-06-10 13:33 | hgbot | Note Added: 0129342 | |
2021-06-11 10:18 | hgbot | Note Added: 0129388 | |
2021-06-11 10:18 | hgbot | Note Added: 0129389 | |
2021-06-11 10:18 | hgbot | Note Added: 0129390 | |
2021-06-11 10:18 | hgbot | Note Added: 0129391 | |
2021-06-11 10:18 | hgbot | Resolution | open => fixed |
2021-06-11 10:18 | hgbot | Status | new => closed |
2021-06-11 10:18 | hgbot | Fixed in Version | => PR21Q3 |
2021-06-11 10:18 | hgbot | Note Added: 0129396 | |
2021-09-01 13:26 | shuehner | Relationship added | has duplicate 0014555 |
Notes |
|
(0129266)
|
hgbot
|
2021-06-09 14:28
|
|
|
|
(0129268)
|
hgbot
|
2021-06-09 15:10
|
|
|
|
(0129339)
|
hgbot
|
2021-06-10 13:33
|
|
Repository: https://gitlab.com/openbravo/product/dbsm [^]
Changeset: 090c58eb6a680af1033c01e9b932835ee1d6cbb7
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-06-10T13:32:31+02:00
URL: https://gitlab.com/openbravo/product/dbsm/-/commit/090c58eb6a680af1033c01e9b932835ee1d6cbb7 [^]
ISSUE-28703: Remove obsolete setters related to dbmanager.jar
build*.xml file from backoffice repo did still pass/set a few attributes
related to obsolete dbmanager.jar when calling dbsm ant tasks.
Internally those were long unusued.
Remove the obsolete setters/getter.
Note: This change in dbsm only works together with commit 914cb5f04a in
backoffice repo which stops setting the remove filter & excludeobjects
values.
---
M src/org/openbravo/ddlutils/task/AlterDatabaseDataAll.java
M src/org/openbravo/ddlutils/task/AlterDatabaseJava.java
M src/org/openbravo/ddlutils/task/CreateDatabase.java
M src/org/openbravo/ddlutils/task/ExportConfigScript.java
---
|
|
|
(0129340)
|
hgbot
|
2021-06-10 13:33
|
|
|
|
(0129341)
|
hgbot
|
2021-06-10 13:33
|
|
|
|
(0129342)
|
hgbot
|
2021-06-10 13:33
|
|
|
|
(0129388)
|
hgbot
|
2021-06-11 10:18
|
|
|
|
(0129389)
|
hgbot
|
2021-06-11 10:18
|
|
|
|
(0129390)
|
hgbot
|
2021-06-11 10:18
|
|
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d59b07b9cd9b202d3f6abf134d061149599b56d8
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-06-11T10:17:06+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d59b07b9cd9b202d3f6abf134d061149599b56d8 [^]
ISSUE-28703: Remove obsolete dbmanager.jar & ant database.lib
Those were not really used anymore by dbsourcemanager for a while
already. However they were still compiled by various ant tasks.
Remove all of that as obsolete
- Stop calling database.lib target whereever done before
- Remove database.lib target from main build.xml file
- Remove src-db/build.xml + src used to build dbmanager.jar itself
- Remove src-db/database/lib/dbmanager.jar from .gitinore
- Above is enough to have it clean for any fresh checkout
- To cleanup older workspaces also add following to compile.complete*
- rm src-db/build
- rm src-db/database/lib/dbmanager.jar
Note that was copied also to WebContent/WEB-INF/lib
---
M .gitignore
M build.xml
M src/build.xml
R src-db/build.xml
R src-db/src/com/openbravo/db/OpenbravoDataFilter.java
R src-db/src/com/openbravo/db/OpenbravoExcludeFilter.java
R src-db/src/com/openbravo/db/OpenbravoMasterdataFilter.java
R src-db/src/com/openbravo/db/OpenbravoMetadataFilter.java
---
|
|
|
(0129391)
|
hgbot
|
2021-06-11 10:18
|
|
|
|
(0129396)
|
hgbot
|
2021-06-11 10:18
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5c9721a21dc89e884c13b3bfb31df376e727ffdb
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-06-11T10:17:06+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5c9721a21dc89e884c13b3bfb31df376e727ffdb [^]
fixes ISSUE-47036; fixes ISSUE-45729; fixes ISSUE-47047; fixes ISSUE-28703
dbsm including the fixes for:
ISSUE-47036: Remove lots of obsolete support code for obsolete
(update.database.mod, ezattributes module, dbmanager.jar references)
ISSUE-45729: export.database fails with some views on oracle with:
An invalid XML character (Unicode: 0x0) was found in the CDATA section.
ISSUE-47047: Reading tables part of PostgreSQL modelloader could be simplified and speed up
ISSUE-28703: dbmanager.jar & src-db/src removal
---
M src-db/database/lib/dbsourcemanager.jar
---
|
|