0028701: Various small build.xml cleanup - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0028701	Openbravo ERP	Z. Others	public	2015-01-20 17:47	2017-09-22 10:25

Reporter	shuehner
Assigned To	shuehner
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version	3.0PR17Q4
Merge Request Status
Review Assigned To	alostale
OBNetwork customer	No
Web browser
Modules	Core
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0028701: Various small build.xml cleanup
Description	Collection of various small changes to simplify build.xml files and to reduce clutter during execution Changes planned are: - remove ant targets core.docs, wad.docs, trl.docs + matching *.launch files Not useful as ant generate.java.doc covers all - remove internal unused sqlcmod & compileSqlcmod targets - remove ant copy.core.lib target (inlined into core.lib) - remove not needed mkdir calls - simplify + slightly speed up file-copying - remove another internal + unused postsrccmod target Feature removal: - Remove eclipse specific build target using eclipse compile from inside IDE as those have not been maintained for a long time - remove possibility to call update.database.mod as that target was abandoned long long time ago and should never be used
Steps To Reproduce	-
Proposed Solution
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2015-01-20 17:47	shuehner	New Issue
2015-01-20 17:47	shuehner	Assigned To	=> shuehner
2015-01-20 17:47	shuehner	OBNetwork customer	=> No
2015-01-20 17:47	shuehner	Modules	=> Core
2015-01-20 17:47	shuehner	Triggers an Emergency Pack	=> No
2017-09-21 16:18	shuehner	Description Updated	bug_revision_view_page.php?rev_id=15965#r15965
2017-09-21 16:20	shuehner	Note Added: 0099220
2017-09-21 16:21	shuehner	Status	new => scheduled
2017-09-21 16:21	shuehner	Note Added: 0099221
2017-09-21 16:21	shuehner	Status	scheduled => resolved
2017-09-21 16:21	shuehner	Fixed in Version	=> 3.0PR17Q4
2017-09-21 16:21	shuehner	Fixed in SCM revision	=> https://code.openbravo.com/erp/devel/pi/rev/4c996fb3dcf3 [^]
2017-09-21 16:21	shuehner	Resolution	open => fixed
2017-09-21 16:22	shuehner	Review Assigned To	=> alostale
2017-09-22 10:25	alostale	Note Added: 0099473
2017-09-22 10:25	alostale	Status	resolved => closed

Notes

Issue has been fixed by the following commits (which did not directly reference the issue):
changeset: 32774:4c996fb3dcf3
tag: tip
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sat Sep 02 13:12:43 2017 +0200
files: src/build.xml
description:
[build-cleanup] remove unused posrcsrcmod target from internal build.xml

changeset: 32773:5ec02ced52e4
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sat Jul 15 17:30:54 2017 +0200
files: build.xml src-db/database/build.xml
description:
[build-cleanup] Remove target to call obsolete update.database.mod

The update.database.mod effort was abandoned years ago and instead the normal
update.database has been made a lot faster.

This commit removes the ant target to be able to call update.database.mod.

Apart from the main build file also 2 internal related targets are removed,
one of which was not directly callable.

changeset: 32772:03ee9b0ac0fe
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sat Jul 15 17:25:34 2017 +0200
files: build.xml create.database.launch eclipse.compile.complete.launch eclipse.compile.launch eclipse.install.source.launch export.database.launch src-trl/eclipse.trl.lib.launch src-wad/eclipse.wad.lib.launch src/build.xml update.database.launch
description:
[build-cleanup] feature removal: eclipse specific ant targets

Code has a few eclipse specific ant targets which can be used directly from
inside eclipse and are slightly nicer to use (doing refresh + eclipse build)

However those have never been maintained for many years, duplicate quite some
logic of the build files.
So remove that hidden feature as part of getting build* xml files smaller and
maintainable.

changeset: 32771:4a0991bbc795
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sun Jul 09 15:12:25 2017 +0200
files: src/build.xml
description:
[build-cleanup] Simplify file copying

src/build.xml file has few places with several <copy> calls where source
and destination folder as identical and just the includes part differs.

Merge all those into single copy call with nested includes.

Both shorter & easier to read as well as reduces I/O and syscalls to not
need to iterate over the source folders several times.
Speedup is only noticable on slow disk systems though (i.e. sources on NFS)

changeset: 32770:5f147a9c2478
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sun Jul 09 14:34:48 2017 +0200
files: src/build.xml
description:
[build-cleanup] Remove some not needed mkdir calls

ant mkdir target does create any missing parent folders when creating a fodler.
That allows to remove some mkdir calls for such parent folders when we create
subfolder directly afterwards anyway.

changeset: 32769:392bba693482
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sun Jul 09 14:27:29 2017 +0200
files: build.xml
description:
[build-cleanup] Remove extra copy.core.lib target (inlined into core.lib)

The main build.xml target core.lib after calling out to src-core/build.xml
does an antcall to another separate copy.core.lib target in the same main
build.xml file. That extra target is never used anywhere else.

Inline it into the main core.lib target to simplify the build file.

Note: getAllModules did not show any reference to it any module.
Note: As secondary effect this removes one occurance of the annoying:
'Trying to override old definition of ...' messages because of the antcall
removal.

changeset: 32768:76ea5b1d9df4
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sun Jul 09 14:15:12 2017 +0200
files: src/build.xml
description:
[build-cleanup] Remove internal unused debugging targets

internal src/build.xml has 2 targets sqlcmod and compileSqlcmod which re never
called anywhere. Apart they were already marked with FIXME -> only for
development should be removed.

This changes removes.

Note:
Checking in getAllModules did not find any reference in modules either.

changeset: 32767:8a37ee35c54f
user: Stefan Hühner <stefan.huehner@openbravo.com>
date: Sun Jul 09 14:12:15 2017 +0200
files: build.xml src-core/build.xml src-core/core.docs.launch src-trl/build.xml src-trl/trl.docs.launch src-wad/build.xml src-wad/wad.docs.launch
description:
[build-cleanup] Remove ant javadoc targets from src-core,src-trl,src-wad

This removes the following ant calls from main build.xml file:
- core.docs, wad.docs, trl.docs

Javadoc for all three items is included in main ant generate.java.doc target
already. src-wad + src-trl as very tied to Openbravo so not useful outside
of Openbravo project. src-core in theory could be used outside, but that will
be very hard, was never an official feature, and no known user is known.

Also each of the 3 target had matching eclipse .launch files which are also
removed as not useful with the ant targets.

Note:
The rm call to remove the docs subfolder where javadoc would be generated is
left in the files to cleanup any earlier created folder or javadoc.