Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028667Openbravo ERP09. Financial managementpublic2015-01-18 23:132015-04-29 20:34
Reporterrjapoova 
Assigned ToTriage Omni OMS 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR14Q4 
Target VersionFixed in Version3.0PR15Q1.4 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028667: Cancelling a Match Statement flow does not fully return system to previous state
DescriptionThe Match Statement process presents two buttons: Done and Cancel.

Done completes the process, Cancel should stop it and take the user back to the previous state (as if the window had never been open).

Using the Advanced Matching Algorithm, however, the process creates transactions in the background. These transactions must be deleted if Cancel is pressed.

Please notice that this is a functional regression: in the previous version of this window (manual window, pre PR14Q4), cancelling a match was deleting the automated transactions.

Please also notice that the current behavior is very confusing for end users and a source of many mistakes.
Steps To ReproduceSee video:
https://drive.google.com/file/d/0B2uCUQlrOPvINlU3VUxNNnJpYVU/view?usp=sharing [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028668 closed eduardo_Argal Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-18 23:13rjapoovaNew Issue
2015-01-18 23:13rjapoovaAssigned To => dmiguelez
2015-01-18 23:13rjapoovaWeb browser => Google Chrome
2015-01-18 23:13rjapoovaModules => Core
2015-01-18 23:13rjapoovaTriggers an Emergency Pack => No
2015-04-24 20:21dmitry_mezentsevNote Added: 0076765
2015-04-24 20:22dmitry_mezentsevWeb browserGoogle Chrome => Google Chrome
2015-04-24 20:22dmitry_mezentsevAssigned Todmiguelez => Triage Finance
2015-04-24 20:22dmitry_mezentsevPrioritynormal => urgent
2015-04-24 20:22dmitry_mezentsevSeveritycritical => major
2015-04-24 20:22dmitry_mezentsevStatusnew => acknowledged
2015-04-29 20:32dmitry_mezentsevRelationship addedrelated to 0026668
2015-04-29 20:32dmitry_mezentsevRelationship deletedrelated to 0026668
2015-04-29 20:32dmitry_mezentsevRelationship addedrelated to 0028668
2015-04-29 20:33dmitry_mezentsevStatusacknowledged => scheduled
2015-04-29 20:34dmitry_mezentsevNote Added: 0076897
2015-04-29 20:34dmitry_mezentsevStatusscheduled => resolved
2015-04-29 20:34dmitry_mezentsevFixed in Version => 3.0PR15Q1.4
2015-04-29 20:34dmitry_mezentsevFixed in SCM revision => PR15Q1.4
2015-04-29 20:34dmitry_mezentsevResolutionopen => fixed
2015-04-29 20:34dmitry_mezentsevReview Assigned To => eduardo_Argal
2015-04-29 20:34dmitry_mezentsevStatusresolved => closed

Notes
(0076765)
dmitry_mezentsev   
2015-04-24 20:21   
>Please notice that this is a functional regression: in the previous version of >this window (manual window, pre PR14Q4), cancelling a match was deleting the >automated transactions.

It is done by intention as a reaction to the feedback we received from multi-user concurrent environments. When people were working in parallel previous behavior of not persisting transactions were creating different inconsistent states if two users were doing it at the same time and one was saving and another one was cancelling. Based on this the decision was made to persist all transactions after algorithm execution. This makes this process also consistent with the rest of the application: massive processes like creating invoices from orders, etc., that persist data and do not have massive cancelling operations.

Together with this I agree that it is a behavior change and I propose to keep this issue to think on the way to make it clear and not confusing for the user.
(0076897)
dmitry_mezentsev   
2015-04-29 20:34   
Fixes issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Cancel button has been removed as it was considered confusing. Now there are two buttons, one for closing the window called 'OK', as it was before, and another one called 'Reconcile'.

Both triggers refresh. Messages have been added to improve user understanding on how the window works. New message to inform the user any change will be persisted. This message can be disabled once clear and will not popup again. Message to run algorithm as well improved.