Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0028645Openbravo ERP04. Warehouse managementpublic2015-01-16 11:232015-08-20 23:15
VictorVillar 
vmromanos 
urgentmajoralways
closedfixed 
5
pi 
 
dmiguelez
Core
No
0028645: It would be nice to be able to reserve more qty than the qty of the order if you have defined the 'is qty variable'
It would be nice to be able to reserve more qty than the qty of the order if you have defined the 'is qty variable'
The steps to reproduce could be the same explained in the issue: https://issues.openbravo.com/view.php?id=28175 [^]

As System adminitrator,
  Go to Windows, tabs and fields.
    window: Product
    tab: Product
      field: Is quantity variable
         Displayed = Yes
As group admin role,
 Go to Product window:
    select Vino Tinto
      Is qty variable = Yes

Go to Sales Order window,
   create a new one, selecting Vino Tinto
   qty = 1
Click on Generate Picking List-For instance: Direct Picking

Go to Warehouse Picking List window
  select the warehouse picking list created before.
  Edit Lines: try to change the qty =2

An error message appears: "Total movement quantity exceeds the pending ordered quantity. The sum of all movement quantities must be equal or lower than 1."

But regarding the Is quantity variable: If checked, goods shipment lines and sales invoice lines with quantity greater than quantity ordered are permitted for this product.
No tags attached.
related to defect 0028618 closed Sandrahuguet Openbravo ERP It is possible to reserve more qty than the qty of the order 
related to defect 0028175 closed vmromanos Modules Warehouse picking list is not taking into account the Product definition: Is quantity variable 
related to defect 0035270 closed collazoandy4 Openbravo ERP Wrong reservation when closing a sales order with a voided partial shipment 
blocks defect 0038093 closed AtulOpenbravo QA After the fix of 28645 should not be possible to enter a reservation greater than the sales order. However it is possible  
causes defect 00317993.0PR16Q2 closed aferraz Openbravo ERP Cannot void a goods shipment if it has more than one closed reservation associated 
causes defect 00319023.0PR16Q2 closed aferraz Openbravo ERP Cannot void a goods shipment if it has related reservation and there is less stock than double of shipment quantity 
causes defect 00318763.0PR16Q2 closed aferraz Openbravo ERP Cannot void a goods shipment if two lines are related with the same sales order line which is reserved and released 
causes defect 00319563.0PR16Q2 closed aferraz Openbravo ERP Cannot void a goods shipment if it has related reservation under some circumstances 
Issue History
2015-01-16 11:23VictorVillarNew Issue
2015-01-16 11:23VictorVillarAssigned To => dmiguelez
2015-01-16 11:23VictorVillarModules => Core
2015-01-16 11:23VictorVillarTriggers an Emergency Pack => No
2015-01-16 11:23VictorVillarRelationship addedrelated to 0028618
2015-01-16 11:24VictorVillarIssue Monitored: networkb
2015-01-16 11:37VictorVillarSummaryIt would be nice to be able to reverve more qty than the qty of the order => It would be nice to be able to reverve more qty than the qty of the order if you have defined the 'is qty variable'
2015-01-16 11:37VictorVillarDescription Updatedbug_revision_view_page.php?rev_id=7470#r7470
2015-01-16 11:37VictorVillarSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7472#r7472
2015-01-16 13:57ngarciaSummaryIt would be nice to be able to reverve more qty than the qty of the order if you have defined the 'is qty variable' => It would be nice to be able to reserve more qty than the qty of the order if you have defined the 'is qty variable'
2015-01-16 13:57ngarciaDescription Updatedbug_revision_view_page.php?rev_id=7475#r7475
2015-01-16 13:57ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7476#r7476
2015-01-16 14:20ngarciaIssue Monitored: ngarcia
2015-02-17 13:47VictorVillarRelationship addedrelated to 0028175
2015-03-13 14:35VictorVillarResolution time => 1397340000
2015-03-13 14:35VictorVillarTypefeature request => defect
2015-03-17 16:36VictorVillarResolution time1397340000 => 1428876000
2015-04-30 10:01dmitry_mezentsevAssigned Todmiguelez => Triage Finance
2015-05-04 18:26vmromanosNote Added: 0076967
2015-05-04 18:26vmromanosAssigned ToTriage Finance => VictorVillar
2015-05-04 18:26vmromanosStatusnew => feedback
2015-05-05 10:46VictorVillarSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8430#r8430
2015-05-05 10:52VictorVillarAssigned ToVictorVillar => vmromanos
2015-05-05 10:52VictorVillarNote Added: 0076985
2015-05-05 10:52VictorVillarStatusfeedback => new
2015-05-12 13:09vmromanosStatusnew => scheduled
2015-05-15 08:57vmromanosNote Added: 0077475
2015-06-22 20:08aferrazNote Added: 0078418
2015-07-02 10:17hgbotCheckin
2015-07-02 10:17hgbotNote Added: 0078612
2015-07-02 10:17hgbotStatusscheduled => resolved
2015-07-02 10:17hgbotResolutionopen => fixed
2015-07-02 10:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d759928f72710d59ea6e1605e746f14950b577d6 [^]
2015-07-02 10:17hgbotCheckin
2015-07-02 10:17hgbotNote Added: 0078613
2015-07-02 10:17hgbotCheckin
2015-07-02 10:17hgbotNote Added: 0078614
2015-07-02 10:24dmiguelezReview Assigned To => dmiguelez
2015-07-02 10:24dmiguelezNote Added: 0078615
2015-07-02 10:24dmiguelezStatusresolved => closed
2015-08-20 23:15hudsonbotCheckin
2015-08-20 23:15hudsonbotNote Added: 0079447
2015-08-20 23:15hudsonbotCheckin
2015-08-20 23:15hudsonbotNote Added: 0079448
2015-08-20 23:15hudsonbotCheckin
2015-08-20 23:15hudsonbotNote Added: 0079449
2015-12-30 13:29ngarciaRelationship addedcauses 0031799
2016-01-15 11:10aferrazRelationship addedcauses 0031902
2016-01-15 14:50aferrazRelationship addedcauses 0031876
2016-01-19 18:16aferrazRelationship addedcauses 0031956
2017-02-15 11:32ngarciaRelationship addedrelated to 0035270
2018-03-15 17:49AtulOpenbravoNote Edited: 0078418bug_revision_view_page.php?bugnote_id=0078418#r16860
2018-03-15 18:06AtulOpenbravoRelationship addedblocks 0038093

Notes
(0076967)
vmromanos   
2015-05-04 18:26   
Hi Victor,

Can you please write the steps to reproduce this issue?
The information provided is not enough to understand & fix the issue.
(0076985)
VictorVillar   
2015-05-05 10:52   
Hi Víctor,

the problem described by the partner was reported in the issue: 0028175

After that, we realised that the real problem is that Reservations is not supporting this 'is qty variable' functionality and we reported it as a feature request.
At the beginning this was considered as a feature request, after some conversations with Isma, this Feature Request was redefined to Defect and I did not 'copy' or define the steps to reproduce again. Sorry for that. I have already updated it.
(0077475)
vmromanos   
2015-05-15 08:57   
Test plan I:
Create a Sales Order
Add any product which has quantity variable = N, Qty=1
Book the sales order.

Select the previously created line and press Manage Reservation
Edit the quantity from 1 to 5. Verify an error is raised
Open the Product window in a new tab. Find the product used in the sales order and set quantity variable = Y
Go back to the Manage Reservation P&E and set qty=5.
Try to save. Verify you can save the change.

Go to Goods Shipments window. Create a new record from the previous sales order.
Process it.

Go back to the sales order | line | stock reservation tab and navigate to the reservation. Verify quantities at header and line level are equal to 1.
Verify reservation status is closed


Test plan II:
Go to Stock Reservation window.
Verify a default filter hides the closed reservations
(0078418)
aferraz   
2015-06-22 20:08   
(edited on: 2018-03-15 17:49)
Test plan III:

Create a Sales Order
Add any product which has quantity variable = Y, Qty=1
Book the sales order.

Select the previously created line and press Manage Reservation
Edit the quantity from 1 to 5.

Go to Goods Shipments window. Create a new record from the previous sales order.
Change the quantity to 5.
Process it.

Go back to the sales order | line | stock reservation tab and navigate to the reservation. Verify quantities at header and line level are equal to 5.
Verify reservation status is closed.

Go back to previous created shipment and void it.

Go again to the sales order | line | stock reservation tab and realize a new reservation has been created with Completed status, with the same data as previous one (check it also in Stock Reservation window), with reserved quantity = 1 but released = 0.

Previous reservation with reserved quantity = 5, released = 5, quantity = 1 with Closed status still exists as user can make use of Is Quantity Variable property of while reserving quantities more than ordered quantity. In this case Order Quantity = 1, Reserved Qty = 5.

(0078612)
hgbot   
2015-07-02 10:17   
Repository: erp/devel/pi
Changeset: d759928f72710d59ea6e1605e746f14950b577d6
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri May 22 13:13:16 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d759928f72710d59ea6e1605e746f14950b577d6 [^]

Fixed bug 28645: reservations and product quantity variable

Improved javascript validation in stock reservation P&E to work with product quantity variable
Activated the reservation close status as a way to control and properly close the cycle for reservations related to quantity variable products
Modified M_RESERVATION_POST to set the line's quantity = releasedQty when closing the reservation
Modified C_ORDERLINE2_TRG trigger (on update event) to close reservations where QtyDelivered >= qtyordered
Button close is hidden when reservation status is closed
Added default filter to Stock Reservations window to hide closed records

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/materialmgmt/ob-reservation.js
M src-db/database/model/functions/M_RESERVATION_POST.xml
M src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TAB.xml
---
(0078613)
hgbot   
2015-07-02 10:17   
Repository: erp/devel/pi
Changeset: e03c1808e1952c20ef838c8a8b976cff802d5156
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jun 22 19:38:05 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e03c1808e1952c20ef838c8a8b976cff802d5156 [^]

Related to issue 28645: Create new reservation when voiding shipment

When voiding a goods shipment with a line related to a order line which has a related closed reservation, a new reservation will be created in Completed status with the quantity of the order line.

---
M src-db/database/model/functions/M_INOUT_POST.xml
M src-db/database/model/functions/M_RESERVATION_POST.xml
M src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
---
(0078614)
hgbot   
2015-07-02 10:17   
Repository: erp/devel/pi
Changeset: 924e60dcbad59d6c40ed5c7466e31e5d04d7ed9c
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jul 01 13:42:51 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/924e60dcbad59d6c40ed5c7466e31e5d04d7ed9c [^]

Related to issue 28645: Applied Code Review changes.

---
M src-db/database/model/functions/M_INOUT_POST.xml
---
(0078615)
dmiguelez   
2015-07-02 10:24   
Code Review + Testing Ok
(0079447)
hudsonbot   
2015-08-20 23:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test
(0079448)
hudsonbot   
2015-08-20 23:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test
(0079449)
hudsonbot   
2015-08-20 23:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test