0028633: Better log of SqlGrammarException - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0028633

Openbravo ERP

A. Platform

public

2015-01-15 18:31

Reporter

gorkaion

Assigned To

AugustoMauch

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Gentoo

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

JSON Datasource

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0028633: Better log of SqlGrammarException

Description

When the HQL of a HQLDataSourceService fails with an SqlGrammarException the log of the error is not meaningful.

It would be nice if this type of exceptions are caught so the sql causing them is also included in the log using the SqlGrammarException.getSql() method.

Steps To Reproduce

On an HQL based table modify it so it throws an SQLGrammarException

Proposed Solution

This kind of exception is thrown at least by the list() method executed in the getData() method of the HQLDataSourceService class. The exception is managed by the handleException() method of the DataSourceServlet class.

There are 2 possibilities:
1. Add a cast in the DataSourceServlet.class so any datasource implementation throwing this exception is covered.
2. Add a try/catch in the HQLDataSourceService class for SQLGrammarExceptions to log the wrong SQL and throw it again so it is managed by the DataSourceServlet as usual.

Additional Information