0028631: HQLDataSourceService setAdminMode without try & finally

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0028631

Openbravo ERP

A. Platform

public

2015-01-15 17:39

2022-02-01 08:05

Reporter

gorkaion

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

always

Status

acknowledged

Resolution

open

Platform

OS Version

Gentoo

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

JSON Datasource

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0028631: HQLDataSourceService setAdminMode without try & finally

Description

The getData method of HQLDataSourceService does a OBContext.setAdminMode(true); but there is not a try & finally block to ensure that the restorePreviousMode is always executed.

It is common during development to raise exceptions on this method when the HQL query is wrong. In this cases the log shows the unbalanced calls to admin mode warning as the restore is not executed.

Steps To Reproduce

On an HQL Query based table modify the HQL so it is not a valid one.
Open the process that uses that table and check the log.

1. As System Administrator:
2. Modify the aprm_orderinvoice table so the HQL is wrong.
3. As Openbravo Admin:
4. Open the Sales Invoice window and search one that is not paid.
5. Open the Add Payment pick and execute, the invoices grid is empty.
6. Check the log and see the unbalanced calls warning.

Proposed Solution

Additional Information