Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028627Retail ModulesWeb POSpublic2015-01-15 14:502015-02-19 09:05
Reportermarvintm 
Assigned Toaaroncalero 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028627: The clearModelWith function of some models is not generic
DescriptionThe clearModelWith function of the Bplocation model is not generic, because it clears only the the attributes it knows about instead of all of the attributes of the object. It should be changed to take into account that the model can be extended and can have more attributes than in the standard POS installation.

The same thing should be done with the BusinessPartner model.
Steps To Reproduce- Extend the bplocation or business partner model.
- Verify that new properties are not properly cleared.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-15 14:50marvintmNew Issue
2015-01-15 14:50marvintmAssigned To => marvintm
2015-01-15 14:50marvintmOBNetwork customer => No
2015-01-15 14:50marvintmTriggers an Emergency Pack => No
2015-01-16 03:09Guillaume_JumpIssue Monitored: Guillaume_Jump
2015-02-09 09:25hgbotCheckin
2015-02-09 09:25hgbotNote Added: 0074269
2015-02-09 09:25hgbotStatusnew => resolved
2015-02-09 09:25hgbotResolutionopen => fixed
2015-02-09 09:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea761fbc7259d1dfc6241529f208e0852ee4605c [^]
2015-02-19 09:05migueldejuanaReview Assigned To => migueldejuana
2015-02-19 09:05migueldejuanaNote Added: 0074635
2015-02-19 09:05migueldejuanaStatusresolved => closed
2015-02-19 09:05migueldejuanaAssigned Tomarvintm => aaroncalero

Notes
(0074269)
hgbot   
2015-02-09 09:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ea761fbc7259d1dfc6241529f208e0852ee4605c
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon Feb 09 09:15:10 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea761fbc7259d1dfc6241529f208e0852ee4605c [^]

Fixed issue 28627: The clearModelWith function of some models is not generic

Changed manual assignment of properties to use OB.UTIL.clone instead, to ensure that properties added to the models are properly copied (when cloning an existing object) or removed (when cloning an empty or null object).

---
M web/org.openbravo.retail.posterminal/js/model/bplocation.js
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
---
(0074635)
migueldejuana   
2015-02-19 09:05   
Tested and reviewed in 260e72a513b6