Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0028623 | Openbravo ERP | A. Platform | public | 2015-01-15 12:58 | 2015-02-04 20:34 |
|
| Reporter | AugustoMauch | |
| Assigned To | NaroaIriarte | |
| Priority | immediate | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR15Q1 | Fixed in Version | 3.0PR15Q2 | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | Coding ( Testing ) |
| Regression date | 2014-11-27 |
| Regression introduced in release | main |
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/d60c4bb642ea8203e7744cf4f58f9851b004b869 [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0028623: When a user opens a window using the Create New widget, the entry in the Recent Views list will not allow to create a new record |
| Description | In the recent views list the list of the last five opened window is shown. If the user can add records in header tab of those windows, there will be a green icon beside the window name in the recent views list. Clicking that icon will create a new record in the header tab of that window.
The problem is that if the user opens a window using the Create New widget, when the window is added to the recent views list the green icon will not be shown. |
| Steps To Reproduce | - Using the create new widget open any window that allows creating records and that is not currently shown in the recent views list. The window will be opened in form view so that the user can create a new record.
- Go back to the workspace and check that the window has been added to the recent views list, but that the green icon is not shown. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | caused by | defect | 0027787 | 3.0PR15Q1 | closed | NaroaIriarte | Create new in workspace allows the user to create new entries in tabs defined as Edit Only | | related to | defect | 0028679 | | acknowledged | Triage Platform Base | After opening a record/view from the direct link, the window is not shown in recent views layout. |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-01-15 12:58 | AugustoMauch | New Issue | |
| 2015-01-15 12:58 | AugustoMauch | Assigned To | => NaroaIriarte |
| 2015-01-15 12:58 | AugustoMauch | Modules | => Core |
| 2015-01-15 12:58 | AugustoMauch | Regression level | => Coding ( Testing ) |
| 2015-01-15 12:58 | AugustoMauch | Regression date | => 2014-11-27 |
| 2015-01-15 12:58 | AugustoMauch | Regression introduced in release | => main |
| 2015-01-15 12:58 | AugustoMauch | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/d60c4bb642ea8203e7744cf4f58f9851b004b869 [^] |
| 2015-01-15 12:58 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2015-01-15 13:05 | AugustoMauch | Relationship added | caused by 0027787 |
| 2015-01-19 14:10 | NaroaIriarte | Note Added: 0073605 | |
| 2015-01-19 14:16 | NaroaIriarte | Note Added: 0073606 | |
| 2015-01-19 14:17 | NaroaIriarte | Note Edited: 0073606 | bug_revision_view_page.php?bugnote_id=0073606#r7485 |
| 2015-01-19 16:07 | NaroaIriarte | Relationship added | related to 0028679 |
| 2015-01-20 19:01 | hgbot | Checkin | |
| 2015-01-20 19:01 | hgbot | Note Added: 0073659 | |
| 2015-01-20 19:01 | hgbot | Status | new => resolved |
| 2015-01-20 19:01 | hgbot | Resolution | open => fixed |
| 2015-01-20 19:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e3b446f2e3b0077f4fb33ae61e9fb5f61b2d5eb5 [^] |
| 2015-01-20 19:02 | AugustoMauch | Review Assigned To | => AugustoMauch |
| 2015-01-20 19:02 | AugustoMauch | Note Added: 0073660 | |
| 2015-01-20 19:02 | AugustoMauch | Status | resolved => closed |
| 2015-01-20 19:02 | AugustoMauch | Fixed in Version | => 3.0PR15Q2 |
| 2015-02-04 20:34 | hudsonbot | Checkin | |
| 2015-02-04 20:34 | hudsonbot | Note Added: 0074167 | |
|
Notes |
|
|
|
If at first a window was editable and it was possible to create a new record and if one creates a new record from the quick create new menu, that window is cached in the quick create new menu. So, if the role access changes to "read only" or if the UI Pattern for that window changes from "Standard" to "read only", "edit only" or "edit and delete only", it is possible to create a new record clicking in the name which is cached in the quick create new menu.
For avoiding this, we only have to open other windows from the quick create new menu, and at last our window will disappear from there. |
|
|
|
(0073606)
|
|
NaroaIriarte
|
2015-01-19 14:16
(edited on: 2015-01-19 14:17) |
|
Some tests have been performed:
The same tests that were performed for the issue 27787 and other:
- When tab/window access for role is editable, clicking the quick create new icon
and making sure that the green small "create new" icon by the name of the window, in the
recent views layout, is still there.
- Changing the role's accesses in every combination, and checking if the small "create new" icon by the name of the window in the recent views layout appears or not. This works well too.
|
|
|
|
(0073659)
|
|
hgbot
|
|
2015-01-20 19:01
|
|
Repository: erp/devel/pi
Changeset: e3b446f2e3b0077f4fb33ae61e9fb5f61b2d5eb5
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Jan 19 14:42:57 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e3b446f2e3b0077f4fb33ae61e9fb5f61b2d5eb5 [^]
Fixed issue 28623: Window's behaviour changes when creating a new record.
When a window is opened using the "quick create new" widget, the same window in the recent views layout
does not allow to create a new record (the green small button for creating a new record, which should be
by the window name, disappears).
The problem was in the "ob-utilities.js", inside the "{OB.Utilities.openView}" function, the logic for
setting the "singleRecord" value (this is the Edit Only attribute) was wrong. If the value of the
variable singleRecord of that function was undefined or null, as it was in the case of clicking the "quick create new"
widget, that value was set to true and the window became an "edit only" window.That was why the small
green "create new" icon disappeared from the recent views layout.
For fixing this the condition has been removed, so we know that the value of the variable "singleRecord" is not
going to be modified and it will be set correctly.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
---
|
|
|
|
|
|
Code reviewed and verified in pi@e3b446f2e3b0 |
|
|
|
|
|