Openbravo Issue Tracking System - Retail Modules
View Issue Details
0028616Retail ModulesWeb POSpublic2015-01-14 15:452015-03-30 11:18
jecharri 
migueldejuana 
urgentmajoralways
closedfixed 
5
 
RR15Q2RR15Q2 
marvintm
No
0028616: Ticket scroll is losing the focus in some cases
Ticket scroll is losing the focus in some cases
Configure four product with different tax categories

Case 1:
-add previously configured products to the ticket until you can see the the scroll in ticket lines and also in left panel
-add 2 times a product that it is checked as "show stock screen"
-the scroll is lost [image1.png]

Case2:
-add some product with same tax
-verify that the scroll in ticket lines is added
-add product previously configured with different taxes [image2.png]
No tags attached.
causes defect 0029183 closed marvintm Running combo unit test fails on js error 
png image1.png (348,726) 2015-01-14 15:45
https://issues.openbravo.com/file_download.php?file_id=7683&type=bug
png image2.png (354,751) 2015-01-14 15:45
https://issues.openbravo.com/file_download.php?file_id=7684&type=bug
png Captura de pantalla de 2015-02-27 11:19:33.png (517,838) 2015-02-27 11:21
https://issues.openbravo.com/file_download.php?file_id=7841&type=bug
Issue History
2015-01-14 15:45jecharriNew Issue
2015-01-14 15:45jecharriAssigned To => marvintm
2015-01-14 15:45jecharriFile Added: image1.png
2015-01-14 15:45jecharriResolution time => 1422140400
2015-01-14 15:45jecharriTriggers an Emergency Pack => No
2015-01-14 15:45jecharriFile Added: image2.png
2015-01-26 13:35hgbotCheckin
2015-01-26 13:35hgbotNote Added: 0073775
2015-01-26 13:35hgbotStatusnew => resolved
2015-01-26 13:35hgbotResolutionopen => fixed
2015-01-26 13:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b5bf2144fafa713c1dfe5cd7caf2168929286dc3 [^]
2015-01-26 13:36migueldejuanaNote Added: 0073776
2015-01-30 15:48mtaalNote Added: 0073954
2015-01-30 15:54mtaalAssigned Tomarvintm => migueldejuana
2015-01-30 15:54mtaalNote Added: 0073955
2015-01-30 15:54mtaalStatusresolved => new
2015-01-30 15:54mtaalResolutionfixed => open
2015-02-13 11:28hgbotCheckin
2015-02-13 11:28hgbotNote Added: 0074447
2015-02-13 11:28hgbotStatusnew => resolved
2015-02-13 11:28hgbotResolutionopen => fixed
2015-02-13 11:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b5bf2144fafa713c1dfe5cd7caf2168929286dc3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a60c91b96139d09359a4bb1d29a15ae0a5956e48 [^]
2015-02-27 11:21adrianromeroFile Added: Captura de pantalla de 2015-02-27 11:19:33.png
2015-02-27 11:23adrianromeroNote Added: 0075023
2015-02-27 11:23adrianromeroStatusresolved => new
2015-02-27 11:23adrianromeroResolutionfixed => open
2015-03-08 06:42mtaalRelationship addedcauses 0029183
2015-03-26 12:38hgbotCheckin
2015-03-26 12:38hgbotNote Added: 0075996
2015-03-26 12:38hgbotStatusnew => resolved
2015-03-26 12:38hgbotResolutionopen => fixed
2015-03-26 12:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a60c91b96139d09359a4bb1d29a15ae0a5956e48 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44d8374fac839f22ea91616f5616f8ed23424f52 [^]
2015-03-26 12:40hgbotCheckin
2015-03-26 12:40hgbotNote Added: 0075997
2015-03-26 12:40hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44d8374fac839f22ea91616f5616f8ed23424f52 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4f305fa8b52b9de97da02601453d96ae7f78c484 [^]
2015-03-30 11:18marvintmReview Assigned To => marvintm
2015-03-30 11:18marvintmStatusresolved => closed
2015-03-30 11:18marvintmFixed in Version => RR15Q2

Notes
(0073775)
hgbot   
2015-01-26 13:35   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b5bf2144fafa713c1dfe5cd7caf2168929286dc3
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Jan 26 13:35:02 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b5bf2144fafa713c1dfe5cd7caf2168929286dc3 [^]

Fixed issue 0028616: Ticket scroll is losing the focus in some cases

Scroll to bottom order lines scroller after rendering taxes (rendering could create an scroll on the left panel)

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
---
(0073776)
migueldejuana   
2015-01-26 13:36   
author Miguel de Juana <miguel.dejuana@openbravo.com>
Mon Jan 26 13:31:33 2015 +0100 (2 minutes ago)
changeset 4417 aa0e7a016a7d
parent 4416 0c108dbf2f00
0028616: Ticket scroll is losing the focus in some cases
URL: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa0e7a016a7d [^]

Scroll to bottom order lines scroller after rendering taxes (rendering could create an scroll on the left panel)
(0073954)
mtaal   
2015-01-30 15:48   
The consequence of this change is that the line list will always scroll back to the bottom when returning to the ticket view from cash management or cashup window.

I think this is a minor thing, it makes sense anyway to show the last added line as a default.
(0073955)
mtaal   
2015-01-30 15:54   
In hinsight, it seems a bit too 'rough' to always scroll to the last line.

In the following scenario this is not desirable:
- add many products so that a scroll bar shows
- scroll up to the first line
- change the quantity of this first/top line
- the ticket list scrolls down, hiding the first line which got edited

The same happens when adding a new product in the top.

Therefore I think it is best to only actively scroll to the affected line and not only to the bottom.
(0074447)
hgbot   
2015-02-13 11:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a60c91b96139d09359a4bb1d29a15ae0a5956e48
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 13 11:23:45 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a60c91b96139d09359a4bb1d29a15ae0a5956e48 [^]

Fixed issue 0028616: Ticket scroll is losing the focus in some cases

Scroll to bottom only when we addind a line or changing qty of the last line

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0075023)
adrianromero   
2015-02-27 11:23   
There is still one case where the scroll does not go to the right product:

* Add products until the scroll appears in the ticket
* Move the scroll to the top
* Add the quantity of the last product added tapping again on the product selector

See Captura de pantalla de 2015-02-27 11:19:33.png
(0075996)
hgbot   
2015-03-26 12:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 44d8374fac839f22ea91616f5616f8ed23424f52
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 26 12:37:48 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/44d8374fac839f22ea91616f5616f8ed23424f52 [^]

Fixed issue 0028616: Ticket scroll is losing the focus in some cases

After some changes in how taxes are rendered, we need to move when to scrollToBottom

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
---
(0075997)
hgbot   
2015-03-26 12:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4f305fa8b52b9de97da02601453d96ae7f78c484
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 26 12:39:40 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4f305fa8b52b9de97da02601453d96ae7f78c484 [^]

Fixed issue 0028616: Ticket scroll is losing the focus in some cases

After some changes rendering taxes we have to reset when to scroll to bottom variable in more places

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---