Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0028610 | Retail Modules | Discounts and Promotions | public | 2015-01-14 13:21 | 2015-08-24 12:15 |
|
| Reporter | lorenzofidalgo | |
| Assigned To | migueldejuana | |
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | RR15Q1 | |
| Merge Request Status | |
| Review Assigned To | adrianromero |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0028610: Taxes are not well applied in "Tax breakdown" area when using a certain discount in "Canarias, Ceuta y Melilla" context |
| Description | When using "Canarias, Ceuta y Melilla" tax context, after applying some discounts, "Tax breakdown" label is not properly calculated. This alse affects to tickets. Total amount and the other computations are properly calculated.
[This is working wrong in: livebuilds pi oracle, RR15Q1 & livebuilds Q4.
This is working properly in: livebuilds pi psql, livebuilds Q3.4, livebuilds Q2.5.]* [See notes]* |
| Steps To Reproduce | Login POS in CMS terminal as centralmountains/openbravo.
Add "Bottle 1L" product.
Increase amount until 3 units (when the default 3x2 discount is applied).
Check in Tax breakdown that result is not correct. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | causes | defect | 0028868 | | closed | marvintm | Cascade taxes are not properly applied |
|
| Attached Files |  Taxes error.png (245,494) 2015-01-14 13:21
https://issues.openbravo.com/file_download.php?file_id=7681&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-01-14 13:21 | lorenzofidalgo | New Issue | |
| 2015-01-14 13:21 | lorenzofidalgo | Assigned To | => marvintm |
| 2015-01-14 13:21 | lorenzofidalgo | File Added: Taxes error.png | |
| 2015-01-14 13:21 | lorenzofidalgo | Triggers an Emergency Pack | => No |
| 2015-01-14 13:26 | lorenzofidalgo | Regression level | => Production - QA Approved |
| 2015-01-14 13:26 | lorenzofidalgo | Regression introduced in release | => RR14Q4 |
| 2015-01-14 13:45 | lorenzofidalgo | Summary | Taxes are not well applied when using a certain discount in "Canarias, Ceuta y Melilla" context => Taxes are not well applied in "Tax breakdown" area when using a certain discount in "Canarias, Ceuta y Melilla" context |
| 2015-01-14 13:45 | lorenzofidalgo | Description Updated | bug_revision_view_page.php?rev_id=7443#r7443 |
| 2015-01-29 17:30 | adrianromero | Issue Monitored: adrianromero | |
| 2015-01-29 18:22 | hgbot | Checkin | |
| 2015-01-29 18:23 | hgbot | Note Added: 0073918 | |
| 2015-01-29 18:23 | hgbot | Status | new => resolved |
| 2015-01-29 18:23 | hgbot | Resolution | open => fixed |
| 2015-01-29 18:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4777b071712d987046f35ceca7390bf568deebe4 [^] |
| 2015-01-29 18:23 | migueldejuana | Assigned To | marvintm => migueldejuana |
| 2015-01-29 18:24 | migueldejuana | Note Added: 0073919 | |
| 2015-01-29 19:04 | marvintm | Review Assigned To | => marvintm |
| 2015-01-29 19:04 | marvintm | Status | resolved => closed |
| 2015-01-29 19:04 | marvintm | Fixed in Version | => RR15Q1 |
| 2015-01-30 08:34 | lorenzofidalgo | Regression level | Production - QA Approved => |
| 2015-01-30 08:34 | lorenzofidalgo | Regression introduced in release | RR14Q4 => |
| 2015-01-30 08:34 | lorenzofidalgo | Note Added: 0073924 | |
| 2015-01-30 08:34 | lorenzofidalgo | Description Updated | bug_revision_view_page.php?rev_id=7560#r7560 |
| 2015-02-04 14:02 | adrianromero | Note Added: 0074087 | |
| 2015-02-04 14:02 | adrianromero | Status | closed => new |
| 2015-02-04 14:02 | adrianromero | Resolution | fixed => open |
| 2015-02-04 14:02 | adrianromero | Fixed in Version | RR15Q1 => |
| 2015-02-04 18:01 | adrianromero | Status | new => scheduled |
| 2015-02-04 18:01 | adrianromero | Status | scheduled => resolved |
| 2015-02-04 18:02 | adrianromero | Status | resolved => closed |
| 2015-02-04 18:02 | adrianromero | Fixed in Version | => RR15Q1 |
| 2015-02-04 18:22 | adrianromero | Relationship added | causes 0028868 |
| 2015-02-06 11:25 | hgbot | Checkin | |
| 2015-02-06 11:25 | hgbot | Note Added: 0074244 | |
| 2015-02-12 12:41 | plujan | Note Added: 0074372 | |
| 2015-03-23 16:04 | hgbot | Checkin | |
| 2015-03-23 16:04 | hgbot | Note Added: 0075882 | |
| 2015-07-08 09:48 | hgbot | Checkin | |
| 2015-07-08 09:48 | hgbot | Note Added: 0078738 | |
| 2015-07-08 09:48 | hgbot | Status | closed => resolved |
| 2015-07-08 09:48 | hgbot | Resolution | open => fixed |
| 2015-07-08 09:48 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4777b071712d987046f35ceca7390bf568deebe4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6593e1218e610e6079560640c3a698850397d171 [^] |
| 2015-08-24 12:15 | marvintm | Review Assigned To | marvintm => adrianromero |
| 2015-08-24 12:15 | marvintm | Status | resolved => closed |
|
Notes |
|
|
(0073918)
|
|
hgbot
|
|
2015-01-29 18:22
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4777b071712d987046f35ceca7390bf568deebe4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jan 29 18:22:28 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4777b071712d987046f35ceca7390bf568deebe4 [^]
Fixed issue 0028610: Taxes are not well applied in "Tax breakdown" area when using a certain discount in "Canarias, Ceuta y Melilla" context
When taxRate is 0 we do not need to do some operations which could add precision error.
---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
|
|
|
|
|
|
It has been reported as a Regression but I'm able to reproduce it in Q2.5 |
|
|
|
|
|
After testing some days after, it was reproducible in all livebuilds contexts, so it is discarded as regression. Perhaps this issue was not reproducible in some contexs due to livebuilds configuration. |
|
|
|
|
The fix does not work properly. It checks for the rate of the first tax rate in the tax tree. It may happen that the first tax is a summary tax with rate 0 and in this case net is wrongly calculated.
The changeset must be reverted. |
|
|
|
(0074244)
|
|
hgbot
|
|
2015-02-06 11:25
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dafeeccc8ab7f41693186dff35b6b864c7e005f1
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Feb 06 10:50:47 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dafeeccc8ab7f41693186dff35b6b864c7e005f1 [^]
Backed out changeset 4777b071712d
Reverting issue 0028610: Taxes are not well applied in "Tax breakdown" area when using a certain discount in "Canarias, Ceuta y Melilla" context
---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
|
|
|
|
(0074372)
|
|
plujan
|
|
2015-02-12 12:41
|
|
|
This issue is still in Closed status while the last commit is a backout. Please correct the information to leave the data consistent. Either it is closed (resolution should change from Open) or it is not (status should be changed) |
|
|
|
(0075882)
|
|
hgbot
|
|
2015-03-23 16:04
|
|
|
|
|
(0078738)
|
|
hgbot
|
|
2015-07-08 09:48
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6593e1218e610e6079560640c3a698850397d171
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jan 29 18:22:28 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6593e1218e610e6079560640c3a698850397d171 [^]
Fixed issue 0028610: Taxes are not well applied in "Tax breakdown" area when using a certain discount in "Canarias, Ceuta y Melilla" context
When taxRate is 0 we do not need to do some operations which could add precision error.
---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
|
|