Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028593Localization Pack: SpainAEAT 349public2015-01-13 17:092015-03-03 14:12
Reportermaite 
Assigned Tovmromanos 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket33489
OBNetwork customerOBPS
Regression introduced in release
Summary0028593: getBusinessPartnerInfo method should firstly consider locations defined as "tax locations"
DescriptiongetBusinessPartnerInfo method should firstly consider locations defined as "tax locations"
Steps To Reproduce1. Define following locations for same Business Partner:
  - Location1 as "tax location"= yes and "ship location"= yes
  - Location2 as "tax location"= no and "ship location"= no
2. Run 349 report and realize that Location2 is considered when locations defined as "tax location" should be considered
Proposed SolutionAdd code similar to 340 code in "getBusinessPartnerInfo" method of "AEAT3492010ReportDao" java:

for (Location loc : bp.getBusinessPartnerLocationList()) {
        if (loc.isTaxLocation())
          return loc.getLocationAddress();
      }
      return bp.getBusinessPartnerLocationList().get(0).getLocationAddress();
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-13 17:09maiteNew Issue
2015-01-13 17:09maiteAssigned To => jonalegriaesarte
2015-01-13 17:09maiteSupport ticket => 33489
2015-01-13 17:09maiteOBNetwork customer => Yes
2015-01-13 17:09maiteAssigned Tojonalegriaesarte => vmromanos
2015-01-13 17:10maiteResolution time => 1427238000
2015-01-13 17:10maiteIssue Monitored: networkb
2015-02-26 17:53vmromanosStatusnew => scheduled
2015-02-26 17:53vmromanosfix_in_branch => pi
2015-02-27 14:14vmromanosNote Added: 0075042
2015-02-27 14:19hgbotCheckin
2015-02-27 14:19hgbotNote Added: 0075043
2015-02-27 14:19hgbotStatusscheduled => resolved
2015-02-27 14:19hgbotResolutionopen => fixed
2015-02-27 14:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/139829d2b3752ab5a526a605562363e4a9490e82 [^]
2015-03-03 14:12psanjuanNote Added: 0075118
2015-03-03 14:12psanjuanStatusresolved => closed
2015-03-03 14:12psanjuanfix_in_branchpi =>

Notes
(0075042)
vmromanos   
2015-02-27 14:14   
Test plan:
1. Create a business partner (customer). Create 3 bp locations: Spain, Greece, France. Select only Greece as Tax Location = Y
2. Create a Sales Invoice for this bp.
Enter any product and select tax rate = Entregas intracomunitarias (%N=>0%)
3. Process and post the invoice
4. Launch the 349 report and verify the NOI code for this bp is "EL", which corresponds to Greece
(0075043)
hgbot   
2015-02-27 14:19   
Repository: erp/pmods/org.openbravo.module.aeat349.es
Changeset: 139829d2b3752ab5a526a605562363e4a9490e82
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Feb 27 14:16:19 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/139829d2b3752ab5a526a605562363e4a9490e82 [^]

Fixes issue 28593: Get Tax Location as Business Partner location when defined

If a BP has a Tax location defined, we use it as the default bp location. If no location is defined as tax location we apply the same criteria used before

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/aeat349/es/AEAT3492010ReportDao.java
M src/org/openbravo/module/aeat349/es/AEAT349ReportDao.java
---
(0075118)
psanjuan   
2015-03-03 14:12   
Verified.

Location taken is the one set as Tax Location.