Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028592Openbravo ERP02. Master data managementpublic2015-01-13 16:592015-05-07 22:17
Reportermaite 
Assigned Tovmromanos 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Versionpi 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket33489
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028592: Alert and Event Handler needed to ensure that business partner with addresses in different country has one set as "tax location"
DescriptionAlert and Event Handler needed to ensure that business partner with addresses in different country has one set as "tax location"
Steps To Reproduce1. Access Business Partner window and Location tab. Ensure that existent location has not "Tax Location" field checked
2. Add new location record for different country. Save and realize that no error is received. However, when defining locations for different countries at least one of them should be set as "tax location"
Proposed SolutionAlert is needed as a complement of Event Handler in order to let user know that some existent data needs to be fixed
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-13 16:59maiteNew Issue
2015-01-13 16:59maiteAssigned To => dmiguelez
2015-01-13 16:59maiteOBNetwork customer => Yes
2015-01-13 16:59maiteModules => Core
2015-01-13 16:59maiteSupport ticket => 33489
2015-01-13 16:59maiteResolution time => 1427238000
2015-01-13 16:59maiteTriggers an Emergency Pack => No
2015-01-13 16:59maiteAssigned Todmiguelez => vmromanos
2015-01-13 17:00maiteIssue Monitored: networkb
2015-02-23 13:30jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-02-27 15:03vmromanosStatusnew => scheduled
2015-02-27 15:03vmromanosfix_in_branch => pi
2015-03-04 16:25vmromanosNote Added: 0075161
2015-04-30 09:15hgbotCheckin
2015-04-30 09:15hgbotNote Added: 0076904
2015-04-30 09:15hgbotStatusscheduled => resolved
2015-04-30 09:15hgbotResolutionopen => fixed
2015-04-30 09:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/549146dc9be27982845b2c0277b09f9bcf5dfda8 [^]
2015-04-30 09:16umartirenaReview Assigned To => umartirena
2015-04-30 09:16umartirenaNote Added: 0076905
2015-04-30 09:16umartirenaStatusresolved => closed
2015-04-30 09:16umartirenaFixed in Version => pi
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077189

Notes
(0075161)
vmromanos   
2015-03-04 16:25   
Test plan alert "Business Partner with no Tax Location Address";
1. Create a new business partner
2. Enter a location for Spain. Set tax location = N
3. Enter a location for France. Set tax location = N
4. Launch the alert process. Verify the alert has been entered for this business partner
5. Set Spain as tax location = Y. Verify the alert is not raised anymore for this business partner

Test plan alert "Business Partner with several Tax Location Addresses"
1. In the previous business partner, set both Spain and France as tax location = Y. Verify the alert has been entered for this business partner
2. Set France as tax location = N. Verify the alert is not raised anymore for this business partner

Test plan for callout:
1. Create a new business partner
2. Enter an address in Spain. Set tax location = N. No warning is raised. Save
3. Enter a new address in Spain. Set tax location = N. No warning is raised. Save
4. Enter a new address in France. Set tax location = N. A warning is shown because you should define any of them as tax location = Y
5. Set tax location = Y for France. Warning is hidden. Save
6. Enter a new address in USA. Set tax location = Y. A warning is shown because you have several countries as tax location = Y. Save
7. Enter a new address in Greece. Set tax location = N. A warning is shown because the business partner has USA and France as tax location = Y. Save
8. Go to USA record and set tax location = N. No warning is shown because the problem is fixed (only France is set as tax location = Y)
(0076904)
hgbot   
2015-04-30 09:15   
Repository: erp/devel/pi
Changeset: 549146dc9be27982845b2c0277b09f9bcf5dfda8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Mar 04 16:09:45 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/549146dc9be27982845b2c0277b09f9bcf5dfda8 [^]

Fixed bug 28592: Added alerts and callout to manage Tax Location

Implemented 2 alerts:
+ Business Partner with no Tax Location Address
+ Business Partner with several Tax Location Addresses

Implemented callout over Location and Tax Location fields (Business Partner | Location/Address tab) that raises a warning if any of these conditions is fulfilled for the business partner:
+ More than 1 country set as Tax Location
+ Other country is declared as Tax Location and the user is trying to set a new country as Tax Location
+ The business partner has several countries and neither of them is declared as Tax Location

---
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_DATASET.xml
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
A referencedata/standard/Business_Partner_Tax_Location_Alert.xml
A src/org/openbravo/erpCommon/ad_callouts/SL_BPartnerLocation.java
---
(0076905)
umartirena   
2015-04-30 09:16   
Code Review + Testing OK
(0077189)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test