Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028554Openbravo ERP04. Warehouse managementpublic2015-01-09 14:342015-02-04 20:34
Reporteraferraz 
Assigned Toumartirena 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028554: Error is shown when creating a landed cost from a goods receipt in Oracle
DescriptionWhen landed cost is created from Goods Receipt window, an error is shown if Oracle database is being used.
Steps To ReproduceWith QA Testing Admin:

- Create a Purchase Invoice with "Transportation Cost" product
- Create a Goods Receipt
- Move to Landed Cost tab, create new with "Transportation Cost" landed cost type and select previous created invoice in invoice line field.
- Save the landed cost and an error message is shown:
Saving failed. ORA-01403: no data found ORA-06512: at "ERP_PI_ORACLE.M_LC_COST_CHK_TRG", line 32 ORA-04088: error during execution of trigger 'ERP_PI_ORACLE.M_LC_COST_CHK_TRG'
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng LandedCost.png (164,459) 2015-01-09 14:34
https://issues.openbravo.com/file_download.php?file_id=7660&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-01-09 14:34aferrazNew Issue
2015-01-09 14:34aferrazAssigned To => umartirena
2015-01-09 14:34aferrazFile Added: LandedCost.png
2015-01-09 14:34aferrazModules => Core
2015-01-09 14:34aferrazTriggers an Emergency Pack => No
2015-01-14 09:40hgbotCheckin
2015-01-14 09:40hgbotNote Added: 0073484
2015-01-14 09:40hgbotStatusnew => resolved
2015-01-14 09:40hgbotResolutionopen => fixed
2015-01-14 09:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/71010e80cfed9d824178ac9a7d75286cbcf933e9 [^]
2015-01-19 17:42SandrahuguetReview Assigned To => Sandrahuguet
2015-01-19 17:42SandrahuguetNote Added: 0073619
2015-01-19 17:42SandrahuguetStatusresolved => closed
2015-01-19 17:42SandrahuguetFixed in Version => 3.0PR15Q2
2015-02-04 20:34hudsonbotCheckin
2015-02-04 20:34hudsonbotNote Added: 0074145

Notes
(0073484)
hgbot   
2015-01-14 09:40   
Repository: erp/devel/pi
Changeset: 71010e80cfed9d824178ac9a7d75286cbcf933e9
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Jan 14 09:39:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/71010e80cfed9d824178ac9a7d75286cbcf933e9 [^]

Fixes bug 28554: No error is shown now in oracle creating LC from Goods receipt

The problem was in 'SELECT PROCESSED INTO v_Processed FROM M_LandedCost WHERE M_landedcost_ID=v_M_LandedCost_ID' statement. If no result is given in the select, in postgres no value is inserted in v_Processed but it works, but in oracle it fails. To fix this an check has been added to execute this statement only when v_M_LandedCost_ID is not null.
An if statement has been added in case v_M_LandedCost_ID is null and v_m_Inout_ID is not (Goods Receipt window), to prevent adding, updating or inserting Landed Cost Cost records when the Goods Receipt is processed.
Finally, in case of updating, the restriction of not being able to change landed cost header has been removed. This was causing problems when launching Cost Background for a Goods Receipt with Landed Cost Cost records, because this process creates the Landed Cost Header and assigns to Landed Cost Cost records.

---
M src-db/database/model/triggers/M_LC_COST_CHK_TRG.xml
---
(0073619)
Sandrahuguet   
2015-01-19 17:42   
Code review + testing OK
(0074145)
hudsonbot   
2015-02-04 20:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test