Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002854Openbravo ERP08. Project and service managementpublic2008-04-14 12:322009-03-09 08:21
Reporterrafaroda 
Assigned ToDowid 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.40Fixed in Version2.40 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0002854: Employee Expenses: Expense Date field and Business Partner field value
DescriptionEmployee Expenses lines tab should look like Invoiceable Expenses lines one.

Comparing the two screenshots attached, one can see that in Employee Expenses lines tab:
1) 'Expense Date' field is not shown.
2) 'Business Partner' field is filled with employee name instead of the business partner of the expense line (if any).

There is an issue with 'S_TIMEEXPENSELINE_V' view.
Steps To Reproduce1. Go to Project & Service Management || Transactions || Expense Sheet
2. Add a new one and save
3. Go to 'Lines' tab.
4. Select Reinvoincing option, a product and a business partner.
5. Go back to 'Header' tab and click on 'Process' button.
5. Go to Project & Service Management || Transactions || Employee Expenses
6. Select the previous employee and go to 'Lines' tab.

Notice that:
1) 'Expense Date' field is not shown.
2) 'Business Partner' field is filled with employee name instead of business partner one.
Proposed SolutionS_TIMEEXPENSELINE_V view, that is the base for Employee Expense line tab, looks like:

SELECT tel.s_timeexpenseline_id, tel.ad_client_id, tel.ad_org_id, tel.isactive, tel.created, tel.createdby, tel.updated, tel.updatedby, tel.s_timeexpense_id, tel.line, tel.istimereport, te.datereport, tel.m_product_id, tel.qty, tel.expenseamt, tel.c_currency_id, tel.convertedamt, tel.s_resourceassignment_id, tel.description, tel.note, tel.isinvoiced, tel.c_project_id, tel.c_activity_id, tel.c_campaign_id, tel.c_invoiceline_id, tel.invoiceprice, tel.c_uom_id, tel.c_orderline_id, tel.c_projectphase_id, tel.c_projecttask_id, tel.s_timetype_id, te.c_bpartner_id
   FROM s_timeexpenseline tel
   JOIN s_timeexpense te ON tel.s_timeexpense_id = te.s_timeexpense_id
  WHERE tel.qty <> 0 AND tel.c_invoiceline_id IS NULL AND te.processed = 'Y' AND tel.isactive = 'Y' AND te.isactive = 'Y' AND tel.istimereport <> 'Y'

1) In order to show Expense Date field, 'tel.dateexpense' should be added before FROM clause.

2) In order to show correct value of expense line business partner, 'tel.c_bpartner_id' should be added before FROM clause. But this seem to conflict with current 'te.c_bpartner_id'.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0004974 closed Dowid Employee Expenses: Expense Date field and Business Partner field value 
Attached Filespng Invoiceable-Expenses-line.png (53,823) 2008-07-17 10:16
https://issues.openbravo.com/file_download.php?file_id=172&type=bug
png

png Employee-Expenses-line.png (52,351) 2008-07-17 10:16
https://issues.openbravo.com/file_download.php?file_id=173&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2008-06-13 10:24rafarodaStatusnew => scheduled
2008-06-13 19:59cromeroTarget Version => 2.40
2008-06-14 10:52rafarodaNote Added: 0007712
2008-07-17 10:16rafarodaFile Added: Invoiceable-Expenses-line.png
2008-07-17 10:16rafarodaFile Added: Employee-Expenses-line.png
2008-07-17 10:19rafarodaNote Deleted: 0007712
2008-07-17 10:57rafarodaOBNetwork customer => No
2008-07-17 10:57rafarodaSummaryEmployee Expenses: Business Partner field value => Employee Expenses: Expense Date field and Business Partner field value
2008-07-17 10:57rafarodaDescription Updated
2008-07-17 10:57rafarodaProposed Solution updated
2008-07-17 10:57rafarodaSteps to Reproduce Updated
2008-07-17 17:47rafarodaAssigned Torafaroda => cromero
2008-10-29 13:09cromeroAssigned Tocromero => AinhoaPagola
2008-11-25 16:38rafarodaAssigned ToAinhoaPagola => Dowid
2008-12-16 15:06svnbotCheckin
2008-12-16 15:06svnbotNote Added: 0011416
2008-12-16 15:06svnbotStatusscheduled => resolved
2008-12-16 15:06svnbotResolutionopen => fixed
2008-12-16 15:06svnbotsvn_revision => 11242
2009-03-09 08:21sureshbabuRegression testing => No
2009-03-09 08:21sureshbabuStatusresolved => closed
2009-03-09 08:21sureshbabuNote Added: 0014502

Notes
(0006443)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1941921 [^]
(0011416)
svnbot   
2008-12-16 15:06   
Repository: openbravo
Revision: 11242
Author: dowid
Date: 2008-12-16 15:05:49 +0100 (Tue, 16 Dec 2008)

Bug fixed 0002854: Employee Expenses: Expense Date field and Business Partner field value

---
U trunk/src-db/database/model/views/S_TIMEEXPENSELINE_V.xml
U trunk/src-db/database/sourcedata/AD_COLUMN.xml
U trunk/src-db/database/sourcedata/AD_ELEMENT.xml
U trunk/src-db/database/sourcedata/AD_FIELD.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=11242&sc=1 [^]
(0014502)
sureshbabu   
2009-03-09 08:21   
Retested working fine(trunk)