0028539: If syncAllModels is called before a previous execution has finished, the same data is sent twice to the server

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0028539

Retail Modules

Web POS

public

2015-01-08 10:50

2015-03-27 12:33

Reporter

aaroncalero

Assigned To

aaroncalero

Priority

normal

Severity

minor

Reproducibility

sometimes

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR15Q2

Fixed in Version

RR15Q2

Merge Request Status

Review Assigned To

Orekaria

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0028539: If syncAllModels is called before a previous execution has finished, the same data is sent twice to the server

Description

If syncAllModels is called before a previous execution has finished and the data is not synchronized yet (OB.MobileApp.model.dataSynchronized is false), the same data is sent to the backend twice and the second time the data is being processed, several server errors are raised.

Steps To Reproduce

Create several tickets (30+) in webPOS while in offline mode.
Conect again to the server.
Before the synchronization process has finished, create a new ticket.
The following error will raise on the server:
*postgres database
2015-01-07 18:34:06,869 [TP-Processor5] ERROR org.hibernate.util.JDBCExceptionReporter - Batch entry 0 insert into C_Order (AD_Client_ID, AD_Org_ID, IsActive, CreatedBy, Updated, UpdatedBy, IsSOTrx, DocumentNo, DocStatus, DocAction, Processing, Processed, C_DocType_ID, C_DocTypeTarget_ID, Description, IsDelivered, IsInvoiced, IsPrinted, IsSelected, SalesRep_ID, DateOrdered, DatePromised, DateAcct, C_BPartner_ID, BillTo_ID, C_BPartner_Location_ID, IsDiscountPrinted, C_Currency_ID, PaymentRule, C_PaymentTerm_ID, InvoiceRule, DeliveryRule, FreightCostRule, DeliveryViaRule, ChargeAmt, PriorityRule, TotalLines, GrandTotal, M_Warehouse_ID, M_PriceList_ID, IsTaxIncluded, Posted, AD_User_ID, CopyFrom, IsSelfService, Generatetemplate, CopyFromPO, FIN_Paymentmethod_ID, RM_PickFromShipment, RM_ReceiveMaterials, RM_CreateInvoice, RM_AddOrphanLine, Calculate_Promotions, Convertquotation, Create_POLines, EM_Obdisc_Addpack, Iscashvat, RM_Pickfromreceipt, EM_APRM_AddPayment, EM_Obpos_Applications_ID, EM_Obpos_App_Cashup_ID, EM_Obpos_Sendemail, EM_Obpos_Createdabsolute, C_Order_ID) values ('39363B0921BB4293B48383844325E84C', 'D270A5AC50874F8BA67A88EE977F8E3B', 'Y', '3073EDF96A3C42CC86C7069E379522D2', '2015-01-07 18:34:06.129000 +00:00:00', '3073EDF96A3C42CC86C7069E379522D2', 'Y', 'VBS1/0000624', 'CO', '--', 'N', 'Y', '511A9371A0F74195AA3F6D66C722729D', '511A9371A0F74195AA3F6D66C722729D', '', 'N', 'N', 'Y', 'N', '3073EDF96A3C42CC86C7069E379522D2', '2015-01-07 00:00:00.000000 +00:00:00', '2015-01-07 00:00:00.000000 +00:00:00', '2015-01-07 00:00:00.000000 +00:00:00', 'ABD91C9D3BC94175B876FBBE9CACA008', '2AA7EADDF7EC405899262DDA3E572436', '2AA7EADDF7EC405899262DDA3E572436', 'N', '102', 'B', 'D8955F8808A54C63BBF478A6843D834D', 'I', 'A', 'I', 'P', '0', '5', '201.58', '243.90', 'CE7AB151695342FF879938F837F12E6E', '496CF965DF9744D2A41248392D1DE407', 'Y', 'N', '032576220FC44B0DA80145B3265E4D9A', 'N', 'N', 'N', 'N', '45A202BF44884F05B8A1BF741E2063B6', 'N', 'N', 'N', 'N', 'N', 'N', 'N', 'N', 'N', 'N', 'N', '9104513C2D0741D4850AE8493998A7C8', 'D2B699745521589F3A4F3ADAF0982E34', 'N', '2015-01-07 18:34:03.396000 +00:00:00', '18E7A199C39CB15BD5D1F8EA42DFCFD7') was aborted. Call getNextException to see the cause.
2015-01-07 18:34:06,877 [TP-Processor5] ERROR org.hibernate.util.JDBCExceptionReporter - ERROR: duplicate key value violates unique constraint "c_order_key"

*oracle database
2015-01-05 16:13:43,984 [TP-Processor1] ERROR org.hibernate.util.JDBCExceptionReporter - ORA-00001: unique constraint (RET_TEST_ORACLE.C_ORDER_KEY) violated

Proposed Solution

We need to ensure that the syncAllModels function is not executed in parallel.
If it is called while the synchronization is in progress (meaning that there is something else that should be sync'ed), we need to activate a flag to call syncAllModels again after the first execution has finished.

Additional Information

Tags

No tags attached.

Relationships

duplicate of	defect	0029290	closed	Orekaria	Stabilization: The 'OB.MobileApp.model.syncAllModels' process should be executed once
depends on	feature request	0028217	new	Retail	Stabilization: Create a basic API for the asynchronous calls
related to	defect	0028692	closed	migueldejuana	Message about Data Synchronization is shown before the actual synchronization happens
Not all the children of this issue are yet resolved or closed.