Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028511Retail ModulesWeb POSpublic2015-01-02 09:542015-02-20 13:12
Reporterjecharri 
Assigned ToOsmany 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q2Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028511: Ugly errors if the currency conversion rate is not defined
DescriptionUgly errors if the currency conversion rate is not defined
Steps To Reproduce-remove the conversion rates between USD and EUR for today
-login to Web POS (white valley sample data has one payment for USD)
-try to pay with this payment type
-verify a red ugly message in top of the window. Also after that error If I refresh the window Web POS keeps in loading and it is not possible to logout
Proposed Solution-Show a popup and don't allow to login if the problem exists
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0029852 closed adrianromero Define layaways only terminals 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-02 09:54jecharriNew Issue
2015-01-02 09:54jecharriAssigned To => marvintm
2015-01-02 09:54jecharriResolution time => 1423090800
2015-01-02 09:54jecharriTriggers an Emergency Pack => No
2015-01-02 09:55jecharriTarget Version => RR15Q2
2015-01-19 17:10OsmanyAssigned Tomarvintm => Osmany
2015-01-27 20:49hgbotCheckin
2015-01-27 20:49hgbotNote Added: 0073837
2015-01-27 20:49hgbotStatusnew => resolved
2015-01-27 20:49hgbotResolutionopen => fixed
2015-01-27 20:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c5e54b699b31973c93b3f5e97cb9dcc6b519cca1 [^]
2015-01-27 20:51hgbotCheckin
2015-01-27 20:51hgbotNote Added: 0073838
2015-01-27 20:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c5e54b699b31973c93b3f5e97cb9dcc6b519cca1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2276083d95c6eb29910121662a125b23fac93f26 [^]
2015-02-02 11:57OrekariaNote Added: 0073977
2015-02-02 11:57OrekariaStatusresolved => new
2015-02-02 11:57OrekariaResolutionfixed => open
2015-02-02 22:26hgbotCheckin
2015-02-02 22:26hgbotNote Added: 0074007
2015-02-02 22:26hgbotStatusnew => resolved
2015-02-02 22:26hgbotResolutionopen => fixed
2015-02-02 22:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2276083d95c6eb29910121662a125b23fac93f26 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b8b46c216fbb97017b92d0c6b06b0dfd69ea7dc0 [^]
2015-02-02 22:38hgbotCheckin
2015-02-02 22:38hgbotNote Added: 0074008
2015-02-02 22:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b8b46c216fbb97017b92d0c6b06b0dfd69ea7dc0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5468d1251b12459e9aae712550bae613bc3c1a3a [^]
2015-02-16 15:21migueldejuanaNote Added: 0074512
2015-02-16 15:21migueldejuanaStatusresolved => new
2015-02-16 15:21migueldejuanaResolutionfixed => open
2015-02-20 02:06hgbotCheckin
2015-02-20 02:06hgbotNote Added: 0074686
2015-02-20 02:06hgbotStatusnew => resolved
2015-02-20 02:06hgbotResolutionopen => fixed
2015-02-20 02:06hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5468d1251b12459e9aae712550bae613bc3c1a3a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f9ce77dda76e8b171f58552db6a20f7dce56da9 [^]
2015-02-20 13:12migueldejuanaReview Assigned To => migueldejuana
2015-02-20 13:12migueldejuanaNote Added: 0074707
2015-02-20 13:12migueldejuanaStatusresolved => closed
2015-05-12 15:56adrianromeroRelationship addedrelated to 0029852

Notes
(0073837)
hgbot   
2015-01-27 20:49   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c5e54b699b31973c93b3f5e97cb9dcc6b519cca1
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Tue Jan 27 13:48:47 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c5e54b699b31973c93b3f5e97cb9dcc6b519cca1 [^]

Fixed issue 28511: Ugly errors if the currency conversion rate is not defined.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0073838)
hgbot   
2015-01-27 20:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2276083d95c6eb29910121662a125b23fac93f26
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Tue Jan 27 13:51:02 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2276083d95c6eb29910121662a125b23fac93f26 [^]

Fixed issue 28511: Ugly errors if the currency conversion rate is not defined.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0073977)
Orekaria   
2015-02-02 11:57   
The fix for the issue have some non-desirable consecuences:
- the check to if the paymentMethod is not defined should always be avoided because the paymentMethods should always be correct
- the action performed if the paymentMethod is not defined should be customized for the issue

Suggested solution:
- verify if the conversion is set. If is not set, show a message in the WebPOS

Suggested howtos:
- backout the changes
- add, in the 'InitialValidations.java' class, a check that verifies if the paymentMethods are correctly set (in this case, if a currency conversion is present). If the verification fails, fire a JSONException
- in posterminal, add the definition of the message fired in the JSONException exception
(0074007)
hgbot   
2015-02-02 22:26   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b8b46c216fbb97017b92d0c6b06b0dfd69ea7dc0
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Mon Feb 02 15:26:00 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b8b46c216fbb97017b92d0c6b06b0dfd69ea7dc0 [^]

Fixed issue 28511: Ugly errors if the currency conversion rate is not defined.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/InitialValidations.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0074008)
hgbot   
2015-02-02 22:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5468d1251b12459e9aae712550bae613bc3c1a3a
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Mon Feb 02 15:38:00 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5468d1251b12459e9aae712550bae613bc3c1a3a [^]

Fixed issue 28511: Ugly errors if the currency conversion rate is not defined.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0074512)
migueldejuana   
2015-02-16 15:21   
It doesn't work when we do not have a conversion rate in the actual date, we should check conversion rate's from/to.
I didn't test but it seems that it doesn't work with more than one foreign currency, we just check if we have more than 0 payments, but if we have USD and another currency to convert we should check that payments = 2.
(0074686)
hgbot   
2015-02-20 02:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3f9ce77dda76e8b171f58552db6a20f7dce56da9
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Thu Feb 19 19:05:44 2015 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f9ce77dda76e8b171f58552db6a20f7dce56da9 [^]

Fixed issue 28511: Adding other function at query.

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0074707)
migueldejuana   
2015-02-20 13:12   
Tested and reviewed in c7a4bad4d3c1