Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028502Openbravo ERP04. Warehouse managementpublic2014-12-30 10:522015-02-04 20:33
Reporterpsanjuan 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028502: [Costing] Inventory Amount Update process is always taking a warehouse regardless warehouse is or not a costing dimension.
Description[Costing] Inventory Amount Update process is always taking a warehouse regardless warehouse is or not a costing dimension.
Steps To ReproduceAs QA Testing Admin (Set Spain as Organization and Spain warehouse as Warehouse as default session values):
* Create a Costing Rule for Spain org with Warehouse Dimension not selected with Starting Date 30/12/2014. Validate it.
* Create a warehouse named "Spain East warehouse" for Spain org.
* Create a new Product for Spain org and put a price for Purchase of 10.
* Create a Purchase Order dated on 31/12/2014 of 10 unit of the new product in Spain Warehouse. Receive that Purchase Order.
* Create another Purchase Order dated on 31/12/2014 of 20 unit of the new product in Spain East Warehouse. Receive that Purchase Order.
* Run Costing Background Process.
* Create an Inventory Amount update with Document Date 31/12/2014.
* Create a Line with Reference date 31/12/2014 and put as Unit Cost 15. Process the Inventory Amount Update.
* Check in Inventories that only an Inventory for Spain warehouse has been created. This is wrong. It should have been created two. One for Spain warehouse and another one for Spain East Warehouse.
Proposed SolutionIf the costing rule does NOT have Warehouse dimension selected, Inventory Amount Update should not shown warehouse value as it is useless.

If the costing rules does have Warehouse dimension selected, Inventory Amount Update should show as many lines as warehouse where product selected has stock.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-30 10:52psanjuanNew Issue
2014-12-30 10:52psanjuanAssigned To => dmiguelez
2014-12-30 10:52psanjuanOBNetwork customer => No
2014-12-30 10:52psanjuanModules => Core
2014-12-30 10:52psanjuanTriggers an Emergency Pack => No
2014-12-31 10:43umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7374#r7374
2014-12-31 10:44umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7375#r7375
2014-12-31 10:44umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7376#r7376
2014-12-31 11:04umartirenaAssigned Todmiguelez => umartirena
2015-01-02 15:46hgbotCheckin
2015-01-02 15:46hgbotNote Added: 0073295
2015-01-02 15:46hgbotStatusnew => resolved
2015-01-02 15:46hgbotResolutionopen => fixed
2015-01-02 15:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e087d572eed72f40c1fa9f995fa29a7b511de754 [^]
2015-01-08 12:17psanjuanNote Added: 0073358
2015-01-08 13:45SandrahuguetReview Assigned To => Sandrahuguet
2015-01-08 13:45SandrahuguetNote Added: 0073365
2015-01-08 13:45SandrahuguetStatusresolved => closed
2015-01-08 13:45SandrahuguetFixed in Version => 3.0PR15Q2
2015-02-04 20:33hudsonbotCheckin
2015-02-04 20:33hudsonbotNote Added: 0074097

Notes
(0073295)
hgbot   
2015-01-02 15:46   
Repository: erp/devel/pi
Changeset: e087d572eed72f40c1fa9f995fa29a7b511de754
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Dec 31 11:03:15 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e087d572eed72f40c1fa9f995fa29a7b511de754 [^]

Fixes bug 28502: Inv Amt Update takes into account Costing Rule warehouse dim

The problem was that the process was checking if the warehouse in Inventory Amount Update is null or not, and if not, it uses it. This is correct when the Costing Rule is set as Warehouse Dimension, but if is not, it should not use it, and even if the Costing Rule is not set as Warehouse Dimension and the warehouse field is hidden in Inventory Amount Lines, it is filled with the Warehouse set in session value.

---
M src/org/openbravo/costing/InventoryAmountUpdateProcess.java
---
(0073358)
psanjuan   
2015-01-08 12:17   
Verified it is working now in case:
(1) Warehouse is do not set as costing dimension
(2) Warehouse is set as costing dimension.
(0073365)
Sandrahuguet   
2015-01-08 13:45   
Code review done
(0074097)
hudsonbot   
2015-02-04 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test