Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028498Retail ModulesWeb POSpublic2014-12-29 15:582015-01-20 12:56
Reporterjecharri 
Assigned Toaaroncalero 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q2Fixed in Versionpi 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customerOBPS
Support ticket33209
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028498: Include a hook in method finishInvoice to add some action when an invoice is created using the cash up
DescriptionInclude a hook in method finishInvoice to add some action when an invoice is created using the cash up
Steps To Reproduce-Do a cash up
-Verify that you can not add a logic hook to process generated invoices

Proposed SolutionCurrently the solution will be to add a hook in the cash up and using the cash up, get all the orders and orderlines related to the cash up and finally take all the invoices with the orderlines.
That behavior can create performance issues so it is better to add the hook
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff Issue28498_Q3.4_backport.diff (5,652) 2015-01-20 12:55
https://issues.openbravo.com/file_download.php?file_id=7706&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-12-29 15:58jecharriNew Issue
2014-12-29 15:58jecharriAssigned To => marvintm
2014-12-29 15:58jecharriOBNetwork customer => Yes
2014-12-29 15:58jecharriSupport ticket => 33209
2014-12-29 15:58jecharriResolution time => 1390431600
2014-12-29 15:58jecharriTriggers an Emergency Pack => No
2014-12-30 10:05marvintmTarget VersionRR15Q1 => RR15Q2
2015-01-07 08:59mtaalResolution time1390431600 => 1421967600
2015-01-08 11:44mtaalAssigned Tomarvintm => aaroncalero
2015-01-08 11:45mtaalNote Added: 0073351
2015-01-09 14:39hgbotCheckin
2015-01-09 14:39hgbotNote Added: 0073402
2015-01-09 14:39hgbotStatusnew => resolved
2015-01-09 14:39hgbotResolutionopen => fixed
2015-01-09 14:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f07fdcc113c97812ec3a46f839352d9c698791ae [^]
2015-01-12 08:48hgbotCheckin
2015-01-12 08:48hgbotNote Added: 0073407
2015-01-12 13:58OrekariaReview Assigned To => Orekaria
2015-01-12 13:58OrekariaStatusresolved => closed
2015-01-12 13:58OrekariaFixed in Version => pi
2015-01-15 09:42hgbotCheckin
2015-01-15 09:42hgbotNote Added: 0073508
2015-01-20 12:55aaroncaleroFile Added: Issue28498_Q3.4_backport.diff
2015-01-20 12:56aaroncaleroNote Added: 0073641

Notes
(0073351)
mtaal   
2015-01-08 11:45   
The new hook needs to be documented here:
http://wiki.openbravo.com/wiki/List_of_Server_Side_Hooks_in_Web_POS [^]
(0073402)
hgbot   
2015-01-09 14:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f07fdcc113c97812ec3a46f839352d9c698791ae
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Jan 09 14:35:28 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f07fdcc113c97812ec3a46f839352d9c698791ae [^]

Fixed issue 28498: Include a hook in method finishInvoice to add some action when an invoice is created using the cash up

Added a hook to the OrderGroupingProcessor (executed during the cashup process to create invoices), allowing to execute code after invoices have been created and the correct document number has been set.
Changed the way OrderGroupingProcessor is instantiated to allow the use of hooks

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
A src/org/openbravo/retail/posterminal/FinishInvoiceHook.java
---
(0073407)
hgbot   
2015-01-12 08:48   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c3a7dfbb521c6897e190427a1b22503bdecca7d1
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon Jan 12 08:47:26 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3a7dfbb521c6897e190427a1b22503bdecca7d1 [^]

Related to issue 28498: Fixed copyright year

---
M src/org/openbravo/retail/posterminal/FinishInvoiceHook.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0073508)
hgbot   
2015-01-15 09:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 34ebafea47c203c06980bcd479bd17340ead30a8
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu Jan 15 09:32:14 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/34ebafea47c203c06980bcd479bd17340ead30a8 [^]

Related to issue 28498: Removed throw Exception declaration from the FinishInvoiceHook to avoid api changes

---
M src/org/openbravo/retail/posterminal/FinishInvoiceHook.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0073641)
aaroncalero   
2015-01-20 12:56   
Attached patch file with the backport to RR14Q3.4