Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028491Retail ModulesWeb POSpublic2014-12-26 12:302015-01-22 18:34
Reporterjecharri 
Assigned Tomarvintm 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q1Fixed in VersionRR15Q1 
Merge Request Status
Review Assigned Toaaroncalero
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-11-21
Regression introduced in releaseRR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0aa9ef48b337 [^]
Triggers an Emergency PackNo
Summary0028491: Cash up report is not showing the correct numbers in withdrawal section
DescriptionCash up report is not showing the correct numbers in withdrawal section
Steps To Reproduce-Go to Web POS
-Create a ticket with total is 1200 and pay with cash
-Do a cash management and withdrawal 1000
-Do a return which amount is 100 in another payment method (this is only to see the error more clear)
-Finally do the cash up and check section "Total Withdrawals"

You will see that the cash management is positive 1000 but the return is with negative value, so total withdrawals is 900 instead of 1100.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028181 closed marvintm In the Web POS cashup report, Withdrawals are added instead of subtracted to the expected amount 
causes defect 0028714 closed Orekaria Verified returns incorrectly update the cash balance 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-26 12:30jecharriNew Issue
2014-12-26 12:30jecharriAssigned To => marvintm
2014-12-26 12:30jecharriResolution time => 1420326000
2014-12-26 12:30jecharriTriggers an Emergency Pack => No
2014-12-26 12:34jecharriPriorityurgent => immediate
2014-12-26 14:41dmitry_mezentsevSeveritymajor => minor
2014-12-29 17:03marvintmRegression level => Production - Confirmed Stable
2014-12-29 17:03marvintmRegression date => 2013-11-21
2014-12-29 17:03marvintmRegression introduced in release => RR14Q2
2014-12-29 17:03marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0aa9ef48b337 [^]
2014-12-29 17:19hgbotCheckin
2014-12-29 17:19hgbotNote Added: 0072858
2014-12-29 17:19hgbotStatusnew => resolved
2014-12-29 17:19hgbotResolutionopen => fixed
2014-12-29 17:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fb8958661e2e4d21c9cee79de5c601a710f12ecb [^]
2014-12-30 10:11hgbotCheckin
2014-12-30 10:11hgbotNote Added: 0072871
2014-12-30 10:44hgbotCheckin
2014-12-30 10:44hgbotNote Added: 0072872
2014-12-30 18:16aaroncaleroReview Assigned To => aaroncalero
2014-12-30 18:17aaroncaleroNote Added: 0072885
2014-12-30 18:17aaroncaleroStatusresolved => closed
2014-12-30 18:17aaroncaleroFixed in Version => RR15Q1
2015-01-13 12:44hgbotCheckin
2015-01-13 12:44hgbotNote Added: 0073455
2015-01-21 15:58OrekariaRelationship addedrelated to 0028181
2015-01-21 23:57hgbotCheckin
2015-01-21 23:57hgbotNote Added: 0073709
2015-01-22 16:22OrekariaRelationship addedcauses 0028714
2015-01-22 18:34hgbotCheckin
2015-01-22 18:34hgbotNote Added: 0073734

Notes
(0072858)
hgbot   
2014-12-29 17:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fb8958661e2e4d21c9cee79de5c601a710f12ecb
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Dec 29 17:19:04 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fb8958661e2e4d21c9cee79de5c601a710f12ecb [^]

Fixed issue 28491. Now totalReturns will be a positive amount, and therefore can now be summed correctly with cash management withdrawal amounts.

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0072871)
hgbot   
2014-12-30 10:11   
Repository: tools/automation/pi-mobile
Changeset: cb332b6024af4da022c1119191212ef2efa54782
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Dec 30 10:11:15 2014 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/cb332b6024af4da022c1119191212ef2efa54782 [^]

Related to issue 28491. Fixed automated test.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I26806_CashupTotalNotShown.java
---
(0072872)
hgbot   
2014-12-30 10:44   
Repository: tools/automation/pi-mobile
Changeset: baa97e210dbf3ad1662be4324275137deecd1cb3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Dec 30 10:44:00 2014 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/baa97e210dbf3ad1662be4324275137deecd1cb3 [^]

Related to issue 28491. Fixed imports.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I26806_CashupTotalNotShown.java
---
(0072885)
aaroncalero   
2014-12-30 18:17   
Tested and reviewed
(0073455)
hgbot   
2015-01-13 12:44   
Repository: tools/automation/pi-mobile
Changeset: b25a080146a29e758c316e8ec7b8f9be486d7701
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Jan 13 11:51:40 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b25a080146a29e758c316e8ec7b8f9be486d7701 [^]

Related to issue 28491: Added new test 'I28491_WrongWithdrawalSection' to verify cashup withdrawals

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/CashupSuite.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28491_WrongWithdrawalSection.java
---
(0073709)
hgbot   
2015-01-21 23:57   
Repository: tools/automation/pi-mobile
Changeset: f7225b1285b2d821a5afbfb5050f5a916f178a14
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Jan 21 21:52:17 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f7225b1285b2d821a5afbfb5050f5a916f178a14 [^]

Related to issue 28181 and issue 28491: Added the 'I28181_CashupWrongWithdrawalSummary' test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/CashupSuite.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28181_CashupWrongWithdrawalSummary.java
---
(0073734)
hgbot   
2015-01-22 18:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bcc4856b6e9902dcabe3396aad449580a32b878a
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Jan 22 17:09:16 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcc4856b6e9902dcabe3396aad449580a32b878a [^]

Fixes issue 28714: The amount to be returned is substracted instead of added

The problem was that the fix for the issue 28491 inverted the sign of the return variable

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---