Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028457Retail ModulesCash uppublic2014-12-19 08:392015-05-04 18:39
Reportersureshbabu 
Assigned Tomalsasua 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2014-06-11
Regression introduced in releaseRR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b92e8075f11 [^]
Triggers an Emergency PackNo
Summary0028457: [RR14Q3.3] Receipt line item details are missing once the user selects the cashup process and cancels twice.
DescriptionReceipt line item details wrongly deleted once the user selects the cashup process and cancels the cash up process
Steps To ReproducePrecondition:
1) "Generate invoice for orders" option checked at POS Terminal Type window.
2) invalid url "http://localhst:8090/printer" [^] for field Hardware URL at POS Terminal window

1) create a open receipt, with a or more than one line(s)
2) Before completing the receipt, select "Cash up" process
3) Verify the created receipt id appears in the "step 1 of 5:Review pending receipts" screen
4) Then without deleting the receipt click "Cancel" button
5) Verify the above created receipt line details are rightly appear in the web POS screen
6) Then again click Cash up process

Defect: One can find at the "step 1 of 5:Review pending receipts" screen above created receipt details are not appearing and also when the user clicks "Cancel" button at web POS receipt details are missing.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028455 closed malsasua [RR14Q3.3] Created quotation details appear in cash up at Step 1 of 5: Review pending receipts 
Attached Filespng Selection_046.png (185,847) 2014-12-21 01:11
https://issues.openbravo.com/file_download.php?file_id=7624&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-12-19 08:39sureshbabuNew Issue
2014-12-19 08:39sureshbabuAssigned To => malsasua
2014-12-19 08:39sureshbabuRegression level => QA functional test
2014-12-19 08:39sureshbabuTriggers an Emergency Pack => No
2014-12-19 08:58sureshbabuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7306#r7306
2014-12-19 12:59hgbotCheckin
2014-12-19 12:59hgbotNote Added: 0072735
2014-12-19 12:59hgbotStatusnew => resolved
2014-12-19 12:59hgbotResolutionopen => fixed
2014-12-19 12:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/856bc3acf7cb39f542a266088c88ae0e31844d9f [^]
2014-12-21 01:11mtaalNote Added: 0072747
2014-12-21 01:11mtaalStatusresolved => new
2014-12-21 01:11mtaalResolutionfixed => open
2014-12-21 01:11mtaalFile Added: Selection_046.png
2014-12-22 10:42hgbotCheckin
2014-12-22 10:42hgbotNote Added: 0072758
2014-12-22 10:42hgbotStatusnew => resolved
2014-12-22 10:42hgbotResolutionopen => fixed
2014-12-22 10:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/856bc3acf7cb39f542a266088c88ae0e31844d9f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4d538f3c920baaf9e6e5336624f85fe44fd6aecd [^]
2014-12-22 14:12hgbotCheckin
2014-12-22 14:12hgbotNote Added: 0072771
2014-12-22 14:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4d538f3c920baaf9e6e5336624f85fe44fd6aecd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8025ce5cca0848c721d2680d1cbfe32e285b3c12 [^]
2014-12-22 14:24migueldejuanaReview Assigned To => migueldejuana
2014-12-22 14:24migueldejuanaNote Added: 0072772
2014-12-22 14:24migueldejuanaStatusresolved => closed
2014-12-22 17:33malsasuaStatusclosed => new
2014-12-22 17:33malsasuaResolutionfixed => open
2014-12-22 17:33malsasuaStatusnew => scheduled
2014-12-22 17:33malsasuafix_in_branch => pi
2014-12-22 17:33malsasuaStatusscheduled => resolved
2014-12-22 17:33malsasuaFixed in Version => RR15Q1
2014-12-22 17:33malsasuaResolutionopen => fixed
2014-12-22 17:34malsasuaRegression levelQA functional test => Production - QA Approved
2014-12-22 17:34malsasuaRegression date => 2014-06-11
2014-12-22 17:34malsasuaRegression introduced in release => RR14Q3
2014-12-22 17:34malsasuaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b92e8075f11 [^]
2014-12-22 17:34malsasuafix_in_branchpi =>
2014-12-22 17:34malsasuaNote Added: 0072775
2014-12-22 17:34malsasuaStatusresolved => closed
2014-12-22 23:12mtaalNote Added: 0072784
2014-12-22 23:13mtaalNote Edited: 0072784bug_revision_view_page.php?bugnote_id=0072784#r7319
2014-12-28 19:05malsasuaRelationship addedrelated to 0028455
2015-01-08 16:27hgbotCheckin
2015-01-08 16:27hgbotNote Added: 0073371
2015-01-13 12:44hgbotCheckin
2015-01-13 12:44hgbotNote Added: 0073456
2015-01-13 12:44hgbotStatusclosed => resolved
2015-01-13 12:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8025ce5cca0848c721d2680d1cbfe32e285b3c12 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/890ed18deca13af1ea6fc7a064acb854db1a84cd [^]
2015-01-13 12:45hgbotCheckin
2015-01-13 12:45hgbotNote Added: 0073457
2015-01-13 13:32OrekariaReview Assigned Tomigueldejuana => Orekaria
2015-01-13 13:32OrekariaStatusresolved => closed
2015-05-04 13:47hgbotCheckin
2015-05-04 13:47hgbotNote Added: 0076940
2015-05-04 18:39hgbotCheckin
2015-05-04 18:39hgbotNote Added: 0076968

Notes
(0072735)
hgbot   
2014-12-19 12:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 856bc3acf7cb39f542a266088c88ae0e31844d9f
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Fri Dec 19 12:59:13 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/856bc3acf7cb39f542a266088c88ae0e31844d9f [^]

fixed issue 28457: disabled promotions and function taxIdValidation when the receipt is cloning

---
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/components/modalcreateorderfromquotation.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0072747)
mtaal   
2014-12-21 01:11   
Total button show amount zero at step 5 of the reproducing steps.

See the screenshot.
(0072758)
hgbot   
2014-12-22 10:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4d538f3c920baaf9e6e5336624f85fe44fd6aecd
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon Dec 22 10:41:24 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4d538f3c920baaf9e6e5336624f85fe44fd6aecd [^]

fixed issue 28457: when clone receipt, disable promotions with cloningReceipt property, and calculateGross is done

---
M web/org.openbravo.retail.posterminal/js/components/modalcreateorderfromquotation.js
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0072771)
hgbot   
2014-12-22 14:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8025ce5cca0848c721d2680d1cbfe32e285b3c12
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon Dec 22 14:11:40 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8025ce5cca0848c721d2680d1cbfe32e285b3c12 [^]

fixed issue 28457: enabled applyPromotions when cloning and added idExecution property to enable/disable property cloningReceipt

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0072772)
migueldejuana   
2014-12-22 14:24   
Tested and reviewed in 4287:8025ce5cca08
(0072775)
malsasua   
2014-12-22 17:34   
reopened to update regression info
(0072784)
mtaal   
2014-12-22 23:12   
(edited on: 2014-12-22 23:13)
An automated testcase will be added which does the following steps:
1) create a ticket with a few lines
2) check that the pay button shows the correct amount
3) start a cashup, check that in step 1 it shows the open ticket with the delete option
4) press cancel in the cashup
5) check that the page returns to the open ticket and that the pay button shows the expected amount

The package/classname of the automated test:
org.openbravo.test.mobile.retail.pack.selenium.tests.cashup
I28457_OpenTicketShouldShowCorrectAfterCashupCancel

It should be added to this suite:
org.openbravo.test.mobile.retail.pack.selenium.suites.CashupSuite
(0073371)
hgbot   
2015-01-08 16:27   
Repository: tools/automation/pi-mobile
Changeset: d3bc359f075705bbaa0b106ed9eb20c92426d2cc
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Jan 08 15:51:36 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d3bc359f075705bbaa0b106ed9eb20c92426d2cc [^]

Related to issue 28455 and issue 28457. Added new test 'I28455_InvoicedReceiptsWronglyPending'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/CashupSuite.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28455_InvoicedReceiptsWronglyPending.java
---
(0073456)
hgbot   
2015-01-13 12:44   
Repository: tools/automation/pi-mobile
Changeset: 890ed18deca13af1ea6fc7a064acb854db1a84cd
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Sun Jan 04 19:09:24 2015 -0300
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/890ed18deca13af1ea6fc7a064acb854db1a84cd [^]

fixed issue 28457: Added test case

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28457_OpenTicketShouldShowCorrectAfterCashupCancel.java
---
(0073457)
hgbot   
2015-01-13 12:45   
Repository: tools/automation/pi-mobile
Changeset: 437564764d72efb81ed8d9c241497eedb40bec7c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Jan 13 12:25:42 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/437564764d72efb81ed8d9c241497eedb40bec7c [^]

Related to issue 28457: Finished test 'I28457_OpenTicketShouldShowCorrectAfterCashupCancel'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/CashupSuite.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I28457_OpenTicketShouldShowCorrectAfterCashupCancel.java
---
(0076940)
hgbot   
2015-05-04 13:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 37235e8d729ae054946c4355d7cc74bf76168b11
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon May 04 13:47:04 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/37235e8d729ae054946c4355d7cc74bf76168b11 [^]

fixed issue 29747: removed execution of applypromotions when the receipt is cloning and the receipt is saved when calculate gross is executed

when the receipt is cloning, the apply promotions is disabled, because it is generating multiples calls to cloneReceipt method, and it generates that the receipt cloned is corrupted
So, we have problems of refresh of receipt, for example issue 28457 and 27983. To avoid this problems, the order is saved in database local, when calculate gross is executed (to fix of other way the issue 28457)
And removed the fix to issue 27983, now it is working fine with the change to save the receipt in database local when calculate gross is executed

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0076968)
hgbot   
2015-05-04 18:39   
Repository: retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal
Changeset: f012545376ffa1e65269f775f59550391f919457
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon May 04 13:47:04 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal/rev/f012545376ffa1e65269f775f59550391f919457 [^]

fixed issue 29752: removed execution of applypromotions when the receipt is cloning and the receipt is saved when calculate gross is executed

when the receipt is cloning, the apply promotions is disabled, because it is generating multiples calls to cloneReceipt method, and it generates that the receipt cloned is corrupted
So, we have problems of refresh of receipt, for example issue 28457 and 27983. To avoid this problems, the order is saved in database local, when calculate gross is executed (to fix of other way the issue 28457)
And removed the fix to issue 27983, now it is working fine with the change to save the receipt in database local when calculate gross is executed

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---