0028455: [RR14Q3.3] Created quotation details appear in cash up at Step 1 of 5: Review pending receipts

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0028455

Retail Modules

Cash up

public

2014-12-18 19:01

2015-01-08 16:27

Reporter

sureshbabu

Assigned To

malsasua

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR15Q1

Merge Request Status

Review Assigned To

Orekaria

OBNetwork customer

Support ticket

Regression level

QA functional test

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0028455: [RR14Q3.3] Created quotation details appear in cash up at Step 1 of 5: Review pending receipts

Description

Created quotation details appear in cash up at "Step 1 of 5: Review pending receipts" as pending receipts.

Steps To Reproduce

Precondition:
navigate to POS terminal type window and check the option
Generate invoice for orders: checked

1) Create a Quotation and click total amount to complete the Quotation.
2) Then click close button to close the quotation.
3) Then click Cash up process,

Defect:

one can find the above created Quotation details appear as pending receipts at "Step 1 of 5: Review pending receipts"

Note: At cash up process at "Step 1 of 5: Review pending receipts" click cancel button to cancel the cash up process, at webpos screen one can find a new receipt is created automatically using Quotation details.

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to

defect

0028457

closed

malsasua

[RR14Q3.3] Receipt line item details are missing once the user selects the cashup process and cancels twice.

Attached Files

Issue History

Date Modified

Username

Field

Change

2014-12-18 19:01

sureshbabu

New Issue

2014-12-18 19:01

sureshbabu

Assigned To

=> malsasua

2014-12-18 19:01

sureshbabu

OBNetwork customer

=> No

2014-12-18 19:01

sureshbabu

Regression level

=> QA functional test

2014-12-18 19:01

sureshbabu

Triggers an Emergency Pack

=> No

2014-12-18 19:03

sureshbabu

Steps to Reproduce Updated

bug_revision_view_page.php?rev_id=7298#r7298

2014-12-18 19:28

sureshbabu

Steps to Reproduce Updated

bug_revision_view_page.php?rev_id=7299#r7299

2014-12-28 19:05

malsasua

Relationship added

related to 0028457

2014-12-28 19:05

malsasua

Status

new => scheduled

2014-12-28 19:05

malsasua

fix_in_branch

=> pi

2014-12-28 19:05

malsasua

Note Added: 0072844

2014-12-28 19:05

malsasua

Status

scheduled => resolved

2014-12-28 19:05

malsasua

Fixed in Version

=> RR15Q1

2014-12-28 19:05

malsasua

Resolution

open => fixed

2014-12-28 19:06

malsasua

Note Edited: 0072844

bug_revision_view_page.php?bugnote_id=0072844#r7352

2015-01-07 09:59

malsasua

Note Edited: 0072844

bug_revision_view_page.php?bugnote_id=0072844#r7383

2015-01-08 15:57

Orekaria

Review Assigned To

=> Orekaria

2015-01-08 15:57

Orekaria

Note Added: 0073367

2015-01-08 15:57

Orekaria

Status

resolved => closed

2015-01-08 16:27

hgbot

Checkin

2015-01-08 16:27

hgbot

Note Added: 0073370

Notes

fixed by the next changesets:
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 856bc3acf7cb39f542a266088c88ae0e31844d9f
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Fri Dec 19 12:59:13 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/856bc3acf7cb39f542a266088c88ae0e31844d9f [^] [^]

fixed issue 28457: disabled promotions and function taxIdValidation when the receipt is cloning

---
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/components/modalcreateorderfromquotation.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js

************************************************************************

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4d538f3c920baaf9e6e5336624f85fe44fd6aecd
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon Dec 22 10:41:24 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4d538f3c920baaf9e6e5336624f85fe44fd6aecd [^] [^]

fixed issue 28457: when clone receipt, disable promotions with cloningReceipt property, and calculateGross is done

---
M web/org.openbravo.retail.posterminal/js/components/modalcreateorderfromquotation.js
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js

************************************************************************

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8025ce5cca0848c721d2680d1cbfe32e285b3c12
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon Dec 22 14:11:40 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8025ce5cca0848c721d2680d1cbfe32e285b3c12 [^] [^]

fixed issue 28457: enabled applyPromotions when cloning and added idExecution property to enable/disable property cloningReceipt

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js

The fix does that the taxIdValidation function only is executed if the receipt is not cloning. This function calls to save receipt function, but if the receipt is cloning, the receipt is not consistent, and it should not be saved in this status.